Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SN+I authentication with AAD #6694

Merged

Conversation

mikeus-hanzlik
Copy link
Contributor

Fixes #6679

Description

Support SN+I authentication with AAD for CertificateServiceClientCredentialsFactory. Fix of throttling issue caused by fetching a token from AAD for each request.

Specific Changes

  • Added support for sendX5c flag in CertificateServiceClientCredentialsFactory.
  • Reused CertificateAppCredentials to fix throttling issue with AAD.

Testing

Unit test added.

@mikeus-hanzlik mikeus-hanzlik requested a review from a team as a code owner October 4, 2023 11:45
@tracyboehrer tracyboehrer added the Automation: No parity PR does not need to be applied to other languages. label Oct 4, 2023
@tracyboehrer
Copy link
Member

@ceciliaavila Ping on this

@tracyboehrer tracyboehrer merged commit 8cc12b8 into microsoft:main Oct 12, 2023
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automation: No parity PR does not need to be applied to other languages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Throttling exception when acquiring token
5 participants