Cherry-picks for 4.11 (#4929)

* Fix broken help links in uischema files (#4911) * Update Microsoft.LogAction.uischema * fix broken links * add OnChooseIntent uischema (#4914) * Update Microsoft.SendActivity.schema (#4923) * Update test schemas. Co-authored-by: zxyanliu <[email protected]> Co-authored-by: Andy Brown <[email protected]> Co-authored-by: Lu Han <[email protected]>
microsoft · Nov 6, 2020 · c20ee62 · c20ee62
1 parent 39a2fd6
commit c20ee62
Show file tree

Hide file tree

Showing 6 changed files with 33 additions and 19 deletions.
diff --git a/...aries/Microsoft.Bot.Builder.Dialogs.Adaptive/Schemas/Actions/Microsoft.LogAction.uischema b/...aries/Microsoft.Bot.Builder.Dialogs.Adaptive/Schemas/Actions/Microsoft.LogAction.uischema
@@ -3,6 +3,6 @@
     "form": {
         "label": "Log to console",
         "subtitle": "Log Action",
-        "helpLink": "https://aka.ms/bfc-debugging-bots"
+        "helpLink": "https://aka.ms/composer-telemetry"
     }
 }
diff --git a/...ries/Microsoft.Bot.Builder.Dialogs.Adaptive/Schemas/Actions/Microsoft.SendActivity.schema b/...ries/Microsoft.Bot.Builder.Dialogs.Adaptive/Schemas/Actions/Microsoft.SendActivity.schema
@@ -11,12 +11,9 @@
             "description": "Optional id for the dialog"
         },
         "disabled": {
-            "$ref": "schema:#/definitions/stringExpression",
+            "$ref": "schema:#/definitions/booleanExpression",
             "title": "Disabled",
-            "description": "Optional condition which if true will disable this action.",
-            "examples": [
-                "user.age > 3"
-            ]
+            "description": "Optional condition which if true will disable this action."
         },
         "activity": {
             "$kind": "Microsoft.IActivityTemplate",

diff --git a/...s/Microsoft.Bot.Builder.Dialogs.Adaptive/Schemas/Actions/Microsoft.TraceActivity.uischema b/...s/Microsoft.Bot.Builder.Dialogs.Adaptive/Schemas/Actions/Microsoft.TraceActivity.uischema
@@ -3,6 +3,6 @@
     "form": {
         "label": "Emit a trace event",
         "subtitle": "Trace Activity",
-        "helpLink": "https://aka.ms/bfc-debugging-bots"
+        "helpLink": "https://aka.ms/composer-telemetry"
     }
 }
diff --git a/....Bot.Builder.Dialogs.Adaptive/Schemas/TriggerConditions/Microsoft.OnChooseIntent.uischema b/....Bot.Builder.Dialogs.Adaptive/Schemas/TriggerConditions/Microsoft.OnChooseIntent.uischema
@@ -0,0 +1,12 @@
+{
+    "$schema": "https://schemas.botframework.com/schemas/ui/v1.0/ui.schema",
+    "form": {
+        "order": [
+            "condition",
+            "*"
+        ],
+        "hidden": [
+            "actions"
+        ]
+    }
+}
diff --git a/tests/tests.schema b/tests/tests.schema
@@ -774,12 +774,9 @@
           "description": "Optional id for the dialog"
         },
         "disabled": {
-          "$ref": "#/definitions/stringExpression",
+          "$ref": "#/definitions/booleanExpression",
           "title": "Disabled",
-          "description": "Optional condition which if true will disable this action.",
-          "examples": [
-            "user.age > 3"
-          ]
+          "description": "Optional condition which if true will disable this action."
         },
         "activity": {
           "$kind": "Microsoft.IActivityTemplate",
@@ -7916,12 +7913,9 @@
           "description": "Optional id for the dialog"
         },
         "disabled": {
-          "$ref": "#/definitions/stringExpression",
+          "$ref": "#/definitions/booleanExpression",
           "title": "Disabled",
-          "description": "Optional condition which if true will disable this action.",
-          "examples": [
-            "user.age > 3"
-          ]
+          "description": "Optional condition which if true will disable this action."
         },
         "activity": {
           "$kind": "Microsoft.IActivityTemplate",

diff --git a/tests/tests.uischema b/tests/tests.uischema
@@ -319,7 +319,7 @@
   },
   "Microsoft.LogAction": {
     "form": {
-      "helpLink": "https://aka.ms/bfc-debugging-bots",
+      "helpLink": "https://aka.ms/composer-telemetry",
       "label": "Log to console",
       "subtitle": "Log Action"
     }
@@ -401,6 +401,17 @@
       "subtitle": "Cancel dialog event"
     }
   },
+  "Microsoft.OnChooseIntent": {
+    "form": {
+      "hidden": [
+        "actions"
+      ],
+      "order": [
+        "condition",
+        "*"
+      ]
+    }
+  },
   "Microsoft.OnCondition": {
     "form": {
       "hidden": [
@@ -762,7 +773,7 @@
   },
   "Microsoft.TraceActivity": {
     "form": {
-      "helpLink": "https://aka.ms/bfc-debugging-bots",
+      "helpLink": "https://aka.ms/composer-telemetry",
       "label": "Emit a trace event",
       "subtitle": "Trace Activity"
     }