Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arcbox 3.0 - Fixed app and ingress #2621

Merged
merged 47 commits into from
Jul 24, 2024

Conversation

zaidmohd
Copy link
Contributor

  • Fixed app
  • Removed NGINX
  • Fixed CName and ingress

@zaidmohd zaidmohd requested a review from chintalavr July 22, 2024 21:26
Copy link
Contributor

@chintalavr chintalavr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks straight forward. If everything is tested and working as expected go ahead and merge this PR to test from MS repos.

@@ -40,7 +30,7 @@ spec:
spec:
containers:
- name: web
image: azurearcjumpstart.azurecr.io/demoapp:dr
image: jumpstartdev.azurecr.io/demoapp:dr
ports:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this our new ACR for images?

@janegilring janegilring merged commit 7d43192 into microsoft:arcbox_3.0 Jul 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants