Update ArcBox to leverage bicepparam instead of json format for example parameter file #2589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for all flavors Signed-off-by: Jan Egil Ring <[email protected]>
…ameter file. Signed-off-by: Jan Egil Ring <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
azure_jumpstart_arcbox/bicepfiles that involve modifications to parameters and the removal of a JSON file. The most significant changes include making thecustomLocationRPOIDparameter optional inmain.bicep, adding parameters tomain.bicepparam, and removing themain.parameters.jsonfile.Parameter modifications:
azure_jumpstart_arcbox/bicep/main.bicep: ThecustomLocationRPOIDparameter has been made optional.azure_jumpstart_arcbox/bicep/main.bicepparam: Several parameters have been added, includingsshRSAPublicKey,spnClientId,spnClientSecret,spnTenantId,windowsAdminUsername,windowsAdminPassword,logAnalyticsWorkspaceName,flavor,deployBastion, andvmAutologon.File removal:
azure_jumpstart_arcbox/bicep/main.parameters.json: This JSON file, which contained a number of parameters, has been removed.