Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for tenant ID value. Optimized variable references. #2567

Merged

Conversation

janegilring
Copy link
Contributor

This pull request primarily focuses on updating the usage of environment variables in the azure_jumpstart_arcbox/artifacts/ArcServersLogonScript.ps1 and azure_jumpstart_arcbox/artifacts/Bootstrap.ps1 scripts. The changes aim to improve consistency in the code by replacing instances of $env: with the direct use of the variable names. This will likely enhance readability and maintainability of the code.

The most important changes include:

  • In azure_jumpstart_arcbox/artifacts/ArcServersLogonScript.ps1:

    • Replaced $env:subscriptionId with $subscriptionId in the az login and Connect-AzAccount commands.
    • Updated the Get-Content command by replacing $Env:resourceGroup and $Env:subscriptionId with $resourceGroup and $subscriptionId respectively.
    • In the Connect-AzAccount and Get-AzConnectedMachine commands, replaced $env:spntenantId, $env:subscriptionId, and $env:resourceGroup with $spntenantId, $subscriptionId, and $resourceGroup respectively.
  • In azure_jumpstart_arcbox/artifacts/Bootstrap.ps1:

    • Replaced the environment variable names SPN_TENANT_ID and SPN_AUTHORITY with spnTenantId and spnAuthority respectively.

@janegilring janegilring added the ArcBox Jumpstart ArcBox related label May 21, 2024
@janegilring janegilring added this to the June 2024 milestone May 21, 2024
@janegilring janegilring self-assigned this May 21, 2024
@janegilring janegilring merged commit c84ff1a into microsoft:arcbox_3.0 May 21, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ArcBox Jumpstart ArcBox related
Projects
Development

Successfully merging this pull request may close these issues.

1 participant