Bugfix for tenant ID value. Optimized variable references. #2567
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily focuses on updating the usage of environment variables in the
azure_jumpstart_arcbox/artifacts/ArcServersLogonScript.ps1
andazure_jumpstart_arcbox/artifacts/Bootstrap.ps1
scripts. The changes aim to improve consistency in the code by replacing instances of$env:
with the direct use of the variable names. This will likely enhance readability and maintainability of the code.The most important changes include:
In
azure_jumpstart_arcbox/artifacts/ArcServersLogonScript.ps1
:$env:subscriptionId
with$subscriptionId
in theaz login
andConnect-AzAccount
commands.Get-Content
command by replacing$Env:resourceGroup
and$Env:subscriptionId
with$resourceGroup
and$subscriptionId
respectively.Connect-AzAccount
andGet-AzConnectedMachine
commands, replaced$env:spntenantId
,$env:subscriptionId
, and$env:resourceGroup
with$spntenantId
,$subscriptionId
, and$resourceGroup
respectively.In
azure_jumpstart_arcbox/artifacts/Bootstrap.ps1
:SPN_TENANT_ID
andSPN_AUTHORITY
withspnTenantId
andspnAuthority
respectively.