test: add e2e test to ensure we ship with non audio/video codecs #2604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karanbirsingh
commented
May 1, 2020
karanbirsingh
commented
May 1, 2020
dbjorge
reviewed
May 1, 2020
dbjorge
reviewed
May 1, 2020
| afterEach(async () => await appController.stop()); | ||
|
|
||
| // https://html.spec.whatwg.org/multipage/media.html#error-codes:dom-mediaerror-media_err_src_not_supported | ||
| it('has error when loading mp3 <audio> in renderer process', async () => { |
There was a problem hiding this comment.
I really like the design of this test case; this is much cleaner than verifying file hashes like I how I'd imagined this test working initially.
dbjorge
approved these changes
May 1, 2020
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
We ship with a slimmer mirrored version of electron to avoid shipping the non-freely-distributable ffmpeg codecs in the base build. This PR adds an e2e test to ensure node_modules/electron/dist has minimal audio/video capabilities, since we don't need them.
Build without mirror - test fails
Build with mirror - test passes
This test only runs in the release pipeline. The mp3 file is very short white noise.
Pull request checklist
yarn fastpassyarn test)<rootDir>/test-results/unit/coveragefix:,chore:,feat(feature-name):,refactor:). SeeCONTRIBUTING.md.