Skip to content

Commit

Permalink
node version update to 20.17.0
Browse files Browse the repository at this point in the history
  • Loading branch information
v-rakeshsh committed Sep 27, 2024
1 parent 6d48486 commit dfba0be
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 30 deletions.
54 changes: 27 additions & 27 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -79,33 +79,33 @@ jobs:
test-results/unit/coverage/cobertura-coverage.xml
timeout-minutes: 5

publish-code-coverage:
needs: unit-tests # This waits for *all* of the unit-tests jobs
runs-on: ubuntu-20.04
steps:
# This only needs to be present so codecov can use the source tree for some post-processing
# This job doesn't require that we install dependencies
- uses: actions/[email protected]
timeout-minutes: 2

- uses: actions/setup-node@v4
with: { node-version: "${{ env.NODE_VERSION }}" }
timeout-minutes: 2

- uses: actions/download-artifact@v4
with:
name: unit-tests-1-results
path: unit-tests-1-results
timeout-minutes: 2

- uses: actions/download-artifact@v4
with:
name: unit-tests-2-results
path: unit-tests-2-results
timeout-minutes: 2

- run: npx codecov
timeout-minutes: 3
# publish-code-coverage:
# needs: unit-tests # This waits for *all* of the unit-tests jobs
# runs-on: ubuntu-20.04
# steps:
# # This only needs to be present so codecov can use the source tree for some post-processing
# # This job doesn't require that we install dependencies
# - uses: actions/[email protected]
# timeout-minutes: 2

# - uses: actions/setup-node@v4
# with: { node-version: "${{ env.NODE_VERSION }}" }
# timeout-minutes: 2

# - uses: actions/download-artifact@v4
# with:
# name: unit-tests-1-results
# path: unit-tests-1-results
# timeout-minutes: 2

# - uses: actions/download-artifact@v4
# with:
# name: unit-tests-2-results
# path: unit-tests-2-results
# timeout-minutes: 2

# - run: npx codecov
# timeout-minutes: 3

lints:
runs-on: ubuntu-20.04
Expand Down
6 changes: 3 additions & 3 deletions pipeline/build-shared.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,9 @@ extends:
displayName: publish code coverage
timeoutInMinutes: 5

- script: yarn publish-code-coverage -t $(CODECOV_TOKEN)
displayName: Publish code coverage to codecov
timeoutInMinutes: 3
# - script: yarn publish-code-coverage -t $(CODECOV_TOKEN)
# displayName: Publish code coverage to codecov
# timeoutInMinutes: 3

- job: 'publish_build_drops'
templateContext:
Expand Down

0 comments on commit dfba0be

Please sign in to comment.