Skip to content

Commit

Permalink
Add WTI logic to identify when VirtualMachinePlatform needs to be ena…
Browse files Browse the repository at this point in the history
…bled (#11438)
  • Loading branch information
OneBlue authored Apr 9, 2024
1 parent c5439eb commit 8c9883f
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/actions/triage/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,6 @@ runs:
$maybe_comment = @("--comment", "${{ inputs.comment }}")
}
curl.exe -L https://github.com/OneBlue/wti/releases/download/v0.1.4/wti.exe -o triage/wti.exe
curl.exe -L https://github.com/OneBlue/wti/releases/download/v0.1.5/wti.exe -o triage/wti.exe
cd triage && echo -n $message | .\wti.exe --issue ${{ inputs.issue }} --config config.yml --github-token "${{ inputs.token }}" --ignore-tags @maybe_message @maybe_comment
28 changes: 27 additions & 1 deletion triage/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,13 @@ logs_rules:
missing_logs_add_tags: ['needs-author-feedback']
skip_tags: ['feature', 'question', 'emailed-logs', 'network']

optional_component_rules:
- name: VirtualMachinePlatform
set: vmp-oc-enabled

- name: Microsoft-Windows-Subsystem-Linux
set: wsl-oc-enabled

tags_rules:
- contains: '/question'
tag: 'question'
Expand Down Expand Up @@ -97,7 +104,16 @@ rules:
name: vm-failed-to-start
capture:
field4: error


- logline:
provider: Microsoft.Windows.Lxss.Manager
task: Error
field8: '0x8004032D' # 0x8004032D = WSL_E_VIRTUAL_MACHINE_PLATFORM_REQUIRED
set:
name: vmp-required
capture:
field8: error

- logline:
provider: Microsoft.Windows.Lxss.Manager
set: service-running
Expand Down Expand Up @@ -232,3 +248,13 @@ actions:
debug_message: 'Found no WSL traces in the logs'
tag: 'needs-author-feedback'
skip_similar_issues: false

- when:
condition:
and:
- vmp-required
- not: vmp-oc-enabled
debug_message: 'Found evidence of virtual machine platform component missing: $error'
user_message: 'It appears that the VirtualMachinePlatform optional component is not enabled. Please try running: `dism.exe /online /enable-feature /featurename:VirtualMachinePlatform /all /norestart`, then reboot and see if that solves the issue.'
skip_similar_issues: false
tag: 'needs-author-feedback'

0 comments on commit 8c9883f

Please sign in to comment.