-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cell): Relax Global-Shared loader/storer to support all possible tile shape. #47
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit curious: when Swizzle is applied only to a single BaseTile
, it can complete the swapping process on one block. However, this might render the functionality of Swizzle ineffective. For example, using Swizzle<3, 3, 3>
is actually ineffective because it effectively performs the logic of Swizzle<2, 3, 3>
. The same logic is executed in the next basic block as well, which can lead to a 4-way bank conflict.
I'd like to hear how you understand this issue @lcy-seso .
resolve #43 resolve #37 resolve #18 resolve #40
It is not necessary to restrict the tile shape utilized by the loader/storer between global and shared memory. While certain tile shapes may not optimally utilize hardware features when accessing global memory, selecting the most appropriate tile shape can be addressed independently.
I would like to emphasize that swizzling is strictly applied within a BaseTile and will not be applied across BaseTiles.
This pull request relaxes the restrictions on tile shapes used by the loader/storer, allowing all possible tile shapes to be utilized.
Additionally, it aims to improve the implementation by ensuring consistency of all related concepts throughout the codebase.
Tasks: