Switch qcodes to src layout #5427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenshnielsen
force-pushed
the
src_layout
branch
from
d67510e
to
53a75ef
Compare
Codecov Report
@@ Coverage Diff @@
## main #5427 +/- ##
===========================================
+ Coverage 68.36% 81.06% +12.70%
===========================================
Files 341 518 +177
Lines 29994 52346 +22352
===========================================
+ Hits 20505 42436 +21931
- Misses 9489 9910 +421 |
jenshnielsen
force-pushed
the
src_layout
branch
2 times, most recently
from
adf2a78
to
f2f1762
Compare
jenshnielsen
force-pushed
the
src_layout
branch
2 times, most recently
from
ebb5dd6
to
1eb1c4c
Compare
jenshnielsen
force-pushed
the
src_layout
branch
from
1eb1c4c
to
86d6d5b
Compare
astafan8
approved these changes
Oct 19, 2023
This only breaks when something outside reaches in to the src or the other way around. There were a few examples that reached into the test fixtures for files but those have been fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly due to the fact that editable mode does not work well for flat layout pypa/setuptools#3518 which does not seem likely to be fixed anytime soon. This also has the benefit of making it cleaner that tests are executed against an installed version of the code since the src is not on path by default.
It is expected that darker will fail on this branch since all the files counts as new when moved but I have not linted them