Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolution for edge case app startup issue 917 #919

Merged
merged 4 commits into from
Dec 2, 2024

Conversation

ryonsteelemsft
Copy link
Contributor

Resolution for edge case app startup issue 917

  • Resolve startup error in WebApp fails to startup due to mathassistant.py issue #917 by including basecache logic
  • Updated tooling assignment logic. Previously tools variable was being subsequently overridden instead of concatenating
    • Further, the agents only take a single tool input, added instructional comments on agent tooling

@ryonsteelemsft
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Microsoft"

@ruandersMSFT
Copy link
Contributor

Also consider adding #915 reference to the specific Pydantic version in requirements.txt to prevent future Pydantic auto upgrade impacts.

@ryonsteelemsft
Copy link
Contributor Author

Also consider adding #915 reference to the specific Pydantic version in requirements.txt to prevent future Pydantic auto upgrade impacts.

Nice find on the root cause. I will amend the PR within the hour

glensouza added a commit to glensouza/PubSec-Info-Assistant-LACO-PW that referenced this pull request Nov 26, 2024
@bjakems bjakems merged commit eadbb2e into microsoft:main Dec 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants