Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prettier config and style repo accordingly #918

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gsong
Copy link

@gsong gsong commented Nov 22, 2024

  • build: standardize on 2 space indentation
  • style: format according to prettier rules 💅

I think it's much more common in the JS/TS community to have 2 space indentations.

@gsong
Copy link
Author

gsong commented Nov 22, 2024

@microsoft-github-policy-service agree company="Sahaj Software"

Copy link
Contributor

@dayland dayland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need deep review

@gsong
Copy link
Author

gsong commented Nov 25, 2024

Need deep review

FWIW, this is what I did:

  1. Updated app/frontend/.prettierrc.json to remove tabWidth: 4 setting
  2. Ran prettier --write . from the root of the monorepo to make sure all files comply to prettier settings, this will prevent future updates to files from adding unnecessary diffs.

Perhaps .vscode/ should be prettier ignored?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants