Fix linting errors (#2560)

.editorconfig

@@ -23,9 +23,10 @@ indent_size = 2
 # Code style defaults
 csharp_using_directive_placement = outside_namespace:error
 csharp_style_implicit_object_creation_when_type_is_apparent = true:suggestion
-dotnet_sort_system_directives_first = true
+dotnet_sort_system_directives_first = true:error
 dotnet_style_readonly_field = true:suggestion
 csharp_style_namespace_declarations = file_scoped:error
+dotnet_diagnostic.IDE0005.severity = error
 
 # License header
 file_header_template = Copyright (c) Microsoft Corporation.\nLicensed under the MIT License.

.github/workflows/build.yaml

@@ -47,6 +47,11 @@ jobs:
         timeout-minutes: 5
         run: Invoke-Build -Configuration Release -AssertStyle GitHubActions
 
+      - name: Lint .NET
+        shell: pwsh
+        timeout-minutes: 5
+        run: dotnet format --verify-no-changes
+
       - name: Upload module
         uses: actions/upload-artifact@v4
         with:

PSRule.sln

@@ -3,14 +3,16 @@ Microsoft Visual Studio Solution File, Format Version 12.00
 # Visual Studio Version 17
 VisualStudioVersion = 17.2.32602.215
 MinimumVisualStudioVersion = 10.0.40219.1
+Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "PSRule.Types", "src\PSRule.Types\PSRule.Types.csproj", "{5FE4DB0B-63D1-4DDB-9762-9C0D29168BC9}"
+EndProject
+Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "PSRule.Badges", "src\PSRule.Badges\PSRule.Badges.csproj", "{309BED8B-4E60-4C42-A2B4-37A2E7EBEF3F}"
+EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "PSRule", "src\PSRule\PSRule.csproj", "{0130215D-58EB-4887-B6FA-31ED02500569}"
 EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "PSRule.Benchmark", "src\PSRule.Benchmark\PSRule.Benchmark.csproj", "{3EC0912F-BFC7-4B53-A1A1-0BA993C6282E}"
 EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "PSRule.Tests", "tests\PSRule.Tests\PSRule.Tests.csproj", "{D3488CE2-779F-4474-B38A-F894A4B689F7}"
 EndProject
-Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "PSRule.Badges", "src\PSRule.Badges\PSRule.Badges.csproj", "{309BED8B-4E60-4C42-A2B4-37A2E7EBEF3F}"
-EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "PSRule.BuildTool", "src\PSRule.BuildTool\PSRule.BuildTool.csproj", "{20DDCC65-8A9A-4BDC-91EC-C3BE6F32E52E}"
 EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "PSRule.SDK", "src\PSRule.SDK\PSRule.SDK.csproj", "{07A84E67-1CA3-4766-B9EA-1FDD9DF6516F}"
@@ -22,8 +24,6 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution
 		src\PSRule.Common.props = src\PSRule.Common.props
 	EndProjectSection
 EndProject
-Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "PSRule.Types", "src\PSRule.Types\PSRule.Types.csproj", "{5FE4DB0B-63D1-4DDB-9762-9C0D29168BC9}"
-EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "PSRule.MSBuild", "src\PSRule.MSBuild\PSRule.MSBuild.csproj", "{872D2648-2F00-475E-84B5-F08BE07385B7}"
 EndProject
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "tests", "tests", "{E0EA0CBA-96C5-4447-8B69-BC13EF0D7A4A}"

src/PSRule.Badges/Properties/AssemblyInfo.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation.
+// Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
 using System.Runtime.CompilerServices;

src/PSRule.CommandLine/Commands/ModuleCommand.cs

@@ -5,7 +5,9 @@
 using System.Diagnostics.CodeAnalysis;
 using System.Management.Automation;
 using Newtonsoft.Json;
+using NuGet.Common;
 using NuGet.Configuration;
+using NuGet.Packaging;
 using NuGet.Protocol;
 using NuGet.Protocol.Core.Types;
 using NuGet.Versioning;
@@ -15,8 +17,6 @@
 using PSRule.Data;
 using PSRule.Pipeline.Dependencies;
 using SemanticVersion = PSRule.Data.SemanticVersion;
-using NuGet.Packaging;
-using NuGet.Common;
 
 namespace PSRule.CommandLine.Commands;
 

src/PSRule.Types/Definitions/IResourceAnnotations.cs

@@ -7,5 +7,5 @@ namespace PSRule.Definitions;
 /// 
 /// </summary>
 public interface IResourceAnnotations : IDictionary<string, object>
-{ 
+{
 }

src/PSRule.Types/Definitions/IResourceMetadata.cs

@@ -11,5 +11,5 @@ public interface IResourceMetadata
     /// <summary>
     /// Annotations on the resource.
     /// </summary>
-    public IResourceAnnotations Annotations { get;}
+    public IResourceAnnotations Annotations { get; }
 }

src/PSRule.Types/Definitions/ResourceHelpInfo.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation.
+// Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
 using Newtonsoft.Json;

src/PSRule.Types/Definitions/ResourceIdKind.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation.
+// Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
 namespace PSRule.Definitions;

src/PSRule.Types/Emitters/InternalFileStream.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation.
+// Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
 namespace PSRule.Emitters;
@@ -8,4 +8,4 @@ internal class InternalFileStream
     public InternalFileStream()
     {
     }
-}
+}

src/PSRule.Types/Options/IOption.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation.
+// Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
 namespace PSRule.Options;

src/PSRule.Types/Options/IOptionContext.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation.
+// Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
 namespace PSRule.Options;

src/PSRule.Types/Runtime/NullLogger_T.cs

@@ -22,6 +22,6 @@ public bool IsEnabled(LogLevel logLevel)
     /// <inheritdoc/>
     public void Log<TState>(LogLevel logLevel, EventId eventId, TState state, Exception? exception, Func<TState, Exception?, string> formatter)
     {
-        
+
     }
 }

src/PSRule/Annotations/CommentMetadata.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation.
+// Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
 using System.Diagnostics;

src/PSRule/Commands/AssertAllOfCommand.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation.
+// Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
 using System.Management.Automation;

src/PSRule/Commands/AssertAnyOfCommand.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation.
+// Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
 using System.Management.Automation;

src/PSRule/Commands/ExportConventionCommand.cs

@@ -1,7 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
-using System.Diagnostics.CodeAnalysis;
 using System.Management.Automation;
 using PSRule.Definitions;
 using PSRule.Definitions.Conventions;

src/PSRule/Commands/InvokeConventionCommand.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation.
+// Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
 using System.Management.Automation;

src/PSRule/Commands/InvokeRuleBlockCommand.cs

@@ -2,7 +2,6 @@
 // Licensed under the MIT License.
 
 using System.Management.Automation;
-using PSRule.Configuration;
 using PSRule.Definitions;
 using PSRule.Pipeline;
 using PSRule.Resources;

src/PSRule/Commands/LanguageKeywords.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation.
+// Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
 namespace PSRule.Commands;

src/PSRule/Commands/RuleLanguageNouns.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation.
+// Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
 namespace PSRule.Commands;

src/PSRule/Common/ListExtensions.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation.
+// Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
 namespace PSRule;

src/PSRule/Common/LoggerExtensions.cs

@@ -1,7 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
-using System.Management.Automation;
 using PSRule.Definitions;
 using PSRule.Pipeline;
 using PSRule.Resources;

src/PSRule/Common/RuleOutcomeExtensions.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation.
+// Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
 using PSRule.Rules;

src/PSRule/Configuration/OutputStyle.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation.
+// Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
 using Newtonsoft.Json;

src/PSRule/Configuration/PSRuleOption.cs

@@ -4,7 +4,6 @@
 using System.Collections;
 using System.Diagnostics;
 using System.Management.Automation;
-using Newtonsoft.Json;
 using PSRule.Converters.Yaml;
 using PSRule.Definitions.Baselines;
 using PSRule.Pipeline;

src/PSRule/Data/IInputFileInfoCollection.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation.
+// Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
 namespace PSRule.Data;

src/PSRule/Data/TargetIssueCollection.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation.
+// Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
 namespace PSRule.Data;

src/PSRule/Data/TargetSourceCollection.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation.
+// Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
 namespace PSRule.Data;

src/PSRule/Definitions/AnnotatedExtensions.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation.
+// Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
 namespace PSRule.Definitions;

src/PSRule/Definitions/Baselines/BaselineFilter.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation.
+// Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
 using System.Management.Automation;

src/PSRule/Definitions/Baselines/BaselineRef.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation.
+// Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
 using PSRule.Pipeline;

src/PSRule/Definitions/Baselines/BaselineSpec.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation.
+// Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
 using PSRule.Configuration;

src/PSRule/Definitions/Baselines/IBaselineV1Spec.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation.
+// Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
 using PSRule.Configuration;

src/PSRule/Definitions/Conventions/ConventionFilter.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation.
+// Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
 using System.Management.Automation;

src/PSRule/Definitions/Expressions/LanguageExpressionBuilder.cs

@@ -2,7 +2,6 @@
 // Licensed under the MIT License.
 
 using System.Diagnostics;
-using PSRule.Configuration;
 using PSRule.Resources;
 using PSRule.Runtime;
 

src/PSRule/Definitions/Expressions/Primitives.cs

@@ -2,7 +2,6 @@
 // Licensed under the MIT License.
 
 using System.Diagnostics;
-using PSRule.Pipeline;
 
 namespace PSRule.Definitions.Expressions;
 

src/PSRule/Definitions/IConditionResult.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation.
+// Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
 namespace PSRule.Definitions;

src/PSRule/Definitions/IDetailedRuleResultV2.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation.
+// Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
 using System.Collections;

src/PSRule/Definitions/IResourceFilter.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation.
+// Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
 namespace PSRule.Definitions;

src/PSRule/Definitions/IResultDetailV2.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation.
+// Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
 namespace PSRule.Definitions;

src/PSRule/Definitions/IResultReasonV2.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation.
+// Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
 namespace PSRule.Definitions;

src/PSRule/Definitions/ISpecDescriptor.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation.
+// Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
 using PSRule.Annotations;

src/PSRule/Definitions/ISuppressionInfoComparer.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation.
+// Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
 namespace PSRule.Definitions;

src/PSRule/Definitions/ModuleConfigs/ModuleConfigV1Spec.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation.
+// Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
 using PSRule.Configuration;

src/PSRule/Definitions/Resource.cs

@@ -2,7 +2,6 @@
 // Licensed under the MIT License.
 
 using System.Diagnostics;
-using System.Net.Http.Headers;
 using PSRule.Pipeline;
 using YamlDotNet.Serialization;
 

src/PSRule/Definitions/Rules/IRuleSpec.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation.
+// Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
 using PSRule.Definitions.Expressions;

src/PSRule/Definitions/Rules/RuleV1Spec.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation.
+// Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
 using PSRule.Definitions.Expressions;

src/PSRule/Definitions/Rules/RuleVisitor.cs

@@ -4,7 +4,6 @@
 using System.Diagnostics;
 using System.Management.Automation;
 using PSRule.Definitions.Expressions;
-using PSRule.Pipeline;
 using PSRule.Resources;
 using PSRule.Runtime;
 

src/PSRule/Definitions/Selectors/ISelector.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation.
+// Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
 namespace PSRule.Definitions.Selectors;

src/PSRule/Definitions/Selectors/SelectorV1.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation.
+// Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
 using PSRule.Pipeline;

src/PSRule/Definitions/SpecAttribute.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation.
+// Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
 namespace PSRule.Definitions;

src/PSRule/Definitions/SuppressionGroups/ISuppressionGroupV1Spec.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation.
+// Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
 using PSRule.Definitions.Expressions;

src/PSRule/Definitions/SuppressionGroups/SuppressionGroupV1Spec.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation.
+// Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
 using PSRule.Definitions.Expressions;