Skip to content

Commit

Permalink
Fix Oryx-CI build (#64)
Browse files Browse the repository at this point in the history
* Tag build image with build name and number

* allowing uppercase docker tags

* Fixing timeout for build step

* Fix indentation

* More indentation

* removing tag command
  • Loading branch information
gpcastro authored Apr 10, 2019
1 parent cbf9f3d commit 26510ac
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
4 changes: 4 additions & 0 deletions vsts/pipelines/_buildTemplate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ steps:
action: 'Push images'
imageNamesPath: '$(Build.ArtifactStagingDirectory)/images/build-images.txt'
includeLatestTag: false
enforceDockerNamingConvention: false
condition: and(succeeded(), eq(variables['PushBuildImages'], 'true'), eq(variables['BuildBuildImages'], 'true'))

- task: Docker@1
Expand All @@ -151,6 +152,7 @@ steps:
pushMultipleImages: true
imageNamesPath: '$(Build.ArtifactStagingDirectory)/images/build-images-acr.txt'
includeLatestTag: false
enforceDockerNamingConvention: false
condition: and(succeeded(), eq(variables['PushBuildImages'], 'true'), eq(variables['BuildBuildImages'], 'true'))

- task: Docker@0
Expand All @@ -161,6 +163,7 @@ steps:
action: 'Push images'
imageNamesPath: '$(Build.ArtifactStagingDirectory)/images/runtime-images.txt'
includeLatestTag: false
enforceDockerNamingConvention: false
condition: and(succeeded(), eq(variables['PushRuntimeImages'], 'true'), eq(variables['BuildRuntimeImages'], 'true'))

- task: Docker@1
Expand All @@ -172,6 +175,7 @@ steps:
pushMultipleImages: true
imageNamesPath: '$(Build.ArtifactStagingDirectory)/images/runtime-images-acr.txt'
includeLatestTag: false
enforceDockerNamingConvention: false
condition: and(succeeded(), eq(variables['PushRuntimeImages'], 'true'), eq(variables['BuildRuntimeImages'], 'true'))

- task: ShellScript@2
Expand Down
4 changes: 1 addition & 3 deletions vsts/pipelines/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,17 +17,16 @@ jobs:
demands:
- msbuild
- visualstudio

variables:
SignType: 'test'

steps:
- template: _signbinary.yml

- job: Job_3
displayName: Build and Publish Oryx Images
dependsOn: Job_2
condition: succeeded()
timeoutInMinutes: 120
pool:
name: OryxLinux
steps:
Expand All @@ -41,7 +40,6 @@ jobs:
echo "##vso[task.setvariable variable=PushRuntimeImages;]true"
echo "##vso[task.setvariable variable=EmbedBuildContextInImages;]true"
displayName: 'Set variables'
- template: _buildTemplate.yml

trigger: none

0 comments on commit 26510ac

Please sign in to comment.