Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstract customData simplification & retrieving in historian with customization #23208

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Abstract customData simplification & retrieving in historian with customization #23208

wants to merge 1 commit into from

Conversation

zhajie
Copy link
Contributor

@zhajie zhajie commented Nov 26, 2024

Description

A concise description of the changes (bug or feature) and their impact/motivation.
If this description is short enough to be used as the title, delete this section and just use the title.

For bug fixes, also include specifics of how to reproduce it / confirm it is fixed.

If this Pull Request should close/resolve any issues when merged, use the special syntax for that here.

Reviewer Guidance

The review process is outlined on this wiki page.

List any specific things you want to get reviewer opinions on, and anything a reviewer would need to know to review this PR effectively.
Things you might want to include:

  • Questions about how to properly make automated tests for your changes.
  • Questions about design choices you made.
  • Descriptions of how to manually test the changes (and how much of that you have done).
  • etc.

If you have any questions in this section, consider making the PR a draft until all questions have been resolved.

@github-actions github-actions bot added area: server Server related issues (routerlicious) base: main PRs targeted against main branch labels Nov 26, 2024
@zhajie zhajie changed the title Abstract customized customData conversion in historian Abstract customized customData simplification & retrieving in historian Nov 26, 2024
@zhajie zhajie changed the title Abstract customized customData simplification & retrieving in historian Abstract customData simplification & retrieving in historian with customization Nov 26, 2024
zhajie
zhajie commented Nov 26, 2024
View reviewed changes
server/historian/packages/historian-base/src/routes/utils.ts
@@ -263,6 +267,7 @@ export async function createGitService(createArgs: createGitServiceArgs): Promis
}
const details = await tenantService.getTenant(tenantId, token, allowDisabledTenant);
const customData: ITenantCustomDataExternal = details.customData;
const simplifiedCustomData = simplifiedCustomDataRetriever?.get(customData);
Copy link
Contributor Author

@zhajie zhajie Nov 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At runtime, retrieve simplified CustomData here with customized FRS implementation here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunho-microsoft yunho-microsoft Awaiting requested review from yunho-microsoft

@znewton znewton Awaiting requested review from znewton

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area: server Server related issues (routerlicious) base: main PRs targeted against main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zhajie