Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(client-presence): Presence AzureClient E2E test setup #23203

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

WillieHabi
Copy link
Contributor

@WillieHabi WillieHabi commented Nov 25, 2024

Description

This PR is a preliminary setup for E2E/audience integration testing for new presence package.

Currently the best way to test E2E capabilities of declarative model, without exposing any internal packages, is through the service clients. Here we can run real service tests against AFR, Tinylicious, and ODSP. While this PR only includes tests for AFR/Tinylicious, upon approval we can setup for odsp-client as well. There has also been talk of merging into one service-client package. Testing in service clients is also beneficial because we're truly testing the entire end to end experience that customers will have when using Presence.

For the test setup, I followed a similar pattern for how we currently test SharedTree here #20925

@github-actions github-actions bot added dependencies Pull requests that update a dependency file base: main PRs targeted against main branch labels Nov 25, 2024
Copy link
Collaborator

@msfluid-bot msfluid-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Coverage Summary

No packages impacted by the change.


Baseline commit: fa4a02e
Baseline build: 309873
Happy Coding!!

Code coverage comparison check passed!!

@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Nov 26, 2024

@fluid-example/bundle-size-tests: +245 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 467.08 KB 467.11 KB +35 Bytes
azureClient.js 563.85 KB 563.9 KB +49 Bytes
connectionState.js 724 Bytes 724 Bytes No change
containerRuntime.js 263.27 KB 263.29 KB +14 Bytes
fluidFramework.js 428.71 KB 428.73 KB +14 Bytes
loader.js 134.18 KB 134.19 KB +14 Bytes
map.js 42.71 KB 42.71 KB +7 Bytes
matrix.js 150.15 KB 150.16 KB +7 Bytes
odspClient.js 530.45 KB 530.5 KB +49 Bytes
odspDriver.js 98.65 KB 98.67 KB +21 Bytes
odspPrefetchSnapshot.js 43.04 KB 43.05 KB +14 Bytes
sharedString.js 166.23 KB 166.24 KB +7 Bytes
sharedTree.js 419.17 KB 419.18 KB +7 Bytes
Total Size 3.38 MB 3.38 MB +245 Bytes

Baseline commit: fa4a02e

Generated by 🚫 dangerJS against 7f725d5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base: main PRs targeted against main branch dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants