Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require __STDC_LIMIT_MACROS and others #6976

Conversation

amaiorano
Copy link
Collaborator

Apply LLVM patch: https://reviews.llvm.org/D21553
GitHub commit: llvm/llvm-project@f4437e9#diff-5fb0c3e347a7fc69d806be92c7b786cda1018152b3d264e3293697a1ac41eb7eR61

This fixes compilation of DXC with latest libc++, which removes C headers like locale.h and stdint.h:
llvm/llvm-project@aa7f377

Apply LLVM patch: https://reviews.llvm.org/D21553
GitHub commit: llvm/llvm-project@f4437e9#diff-5fb0c3e347a7fc69d806be92c7b786cda1018152b3d264e3293697a1ac41eb7eR61

This fixes compilation of DXC with latest libc++, which removes C
headers like locale.h and stdint.h:
llvm/llvm-project@aa7f377
@amaiorano amaiorano requested a review from a team as a code owner October 21, 2024 14:30
Copy link
Collaborator

@llvm-beanz llvm-beanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amaiorano amaiorano merged commit a023a95 into microsoft:main Oct 22, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants