Set the layout rule explicitly for raw buffer operations #6701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first first fix in microsoft#5392 was not correct. It relied on the layout rule for the address to be the correct layout rule, but that is not always the case. The address is just an integer that could exist in any storage class. The correct solution is to explicitly set the layout rule for the BitCast operation when expanding the RawBuffer* functions. We know that the result of the BitCast is a pointer to the physical storage buffer storage class, so we know the layout need to be the storage buffer layout. Fixes microsoft#6554
|
Does this also fix #6541 ? |
No, it does not. They are similar in that the layout of the BitCast is wrong, but different because with the inline spir-v, the compiler does not know what the layout should be. |
Keenuts
approved these changes
Jun 24, 2024
sudonatalie
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first first fix in #5392 was not correct. It relied on the layout
rule for the address to be the correct layout rule, but that is not
always the case. The address is just an integer that could exist in any
storage class. The correct solution is to explicitly set the layout rule
for the BitCast operation when expanding the RawBuffer* functions. We
know that the result of the BitCast is a pointer to the physical storage
buffer storage class, so we know the layout need to be the storage
buffer layout.
Fixes #6554