Adding the new feature of FPDT #6462
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delock
reviewed
Aug 30, 2024
deepspeed/sequence/fpdt_layer.py
Outdated
| return out, lse | ||
|
|
||
|
|
||
| def single_all_to_all(input_, scatter_idx, gather_idx, group): |
There was a problem hiding this comment.
Hi @YJHMITWEB is this single_all_to_all the same as the one in
DeepSpeed/deepspeed/sequence/layer.py
Line 41 in 89c4d9f
There was a problem hiding this comment.
We have not tested the non-blocking All2all with our FPDT design, therefore, we use the original non-blocking version. If this is preferred, we can test this.
There was a problem hiding this comment.
This is fixed. We will now use the single_all_to_all from layer.py
delock
reviewed
Aug 30, 2024
deepspeed/sequence/fpdt_layer.py
Outdated
|
|
||
| compute_stream.wait_stream(offload_stream) | ||
| compute_stream.synchronize() | ||
| with torch.cuda.stream(offload_stream): |
There was a problem hiding this comment.
torch.cuda.stream(stream) should be replaced by get_accelerator().stream(stream), same of other occurance in this file.
delock
reviewed
Aug 30, 2024
deepspeed/sequence/fpdt_layer.py
Outdated
| grad_qkv_linear_bias = torch.zeros(qkv_linear_bias.shape, device=qkv_linear_weight.device, dtype=torch.float) | ||
|
|
||
| grad_global_attn_output_chunk = single_all_to_all(grad_output[:, :chunk_size].contiguous(), scatter_idx, gather_idx, spg) | ||
| torch.cuda.synchronize() |
There was a problem hiding this comment.
Here is should be get_accelerator().synchronize()
There was a problem hiding this comment.
This one is solved.
inkcherry
reviewed
Aug 30, 2024
deepspeed/sequence/layer.py
Outdated
| @@ -168,7 +196,8 @@ def __init__( | |||
| self.gather_idx = gather_idx | |||
| self.sp_overlap_comm = False | |||
| self.overlap_handles = None | |||
| self.sp_stream = sp_stream | |||
| self.sp_stream = None | |||
| # self.sp_stream = sp_stream | |||
There was a problem hiding this comment.
Why comment out this line?
There was a problem hiding this comment.
This one is solved.
tohtana
reviewed
Aug 30, 2024
tohtana
reviewed
Aug 30, 2024
fix format and add unit test for fpdt
tohtana
approved these changes
Nov 26, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 26, 2024
[FPDT](https://arxiv.org/abs/2408.16978) can only be used with [this version](microsoft/Megatron-DeepSpeed#441) of Megatron-DeepSpeed. --------- Co-authored-by: Jinghan Yao <[email protected]> Co-authored-by: Sam Ade Jacobs <[email protected]> Co-authored-by: Jinghan Yao <[email protected]> Co-authored-by: Logan Adams <[email protected]> Co-authored-by: Olatunji Ruwase <[email protected]> Co-authored-by: Jinghan Yao <[email protected]> Co-authored-by: Logan Adams <[email protected]> Co-authored-by: Masahiro Tanaka <[email protected]> Co-authored-by: Masahiro Tanaka <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 26, 2024
[FPDT](https://arxiv.org/abs/2408.16978) can only be used with [this version](microsoft/Megatron-DeepSpeed#441) of Megatron-DeepSpeed. --------- Co-authored-by: Jinghan Yao <[email protected]> Co-authored-by: Sam Ade Jacobs <[email protected]> Co-authored-by: Jinghan Yao <[email protected]> Co-authored-by: Logan Adams <[email protected]> Co-authored-by: Olatunji Ruwase <[email protected]> Co-authored-by: Jinghan Yao <[email protected]> Co-authored-by: Logan Adams <[email protected]> Co-authored-by: Masahiro Tanaka <[email protected]> Co-authored-by: Masahiro Tanaka <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FPDT can only be used with this version of Megatron-DeepSpeed.