Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Table.GenerateByPage to handle empty tables being returned #484

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Update Table.GenerateByPage to handle empty tables being returned #484

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
223d1b2
Updating to handle an empty table being returned
bgribaudo Mar 24, 2022
ec12ddf
Updating to not use Table.Combine + allow providing of table type
bgribaudo Mar 25, 2022
ee61429
Refactoring
bgribaudo Mar 25, 2022
3f1a035
Adjusting error propagation
bgribaudo Apr 14, 2022
10bf748
Reverting last change to avoid triggering a row fetch
bgribaudo May 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 22 additions & 22 deletions samples/TripPin/9-TestConnection/Table.GenerateByPage.pqm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,23 @@
(getNextPage as function) as table =>
let
(
getNextPage as function,
optional tableType as type
) as table =>
let
listOfPages = List.Generate(
() => getNextPage(null), // get the first page of data
(lastPage) => lastPage <> null, // stop when the function returns null
(lastPage) => getNextPage(lastPage) // pass the previous page to the next function call
),
// concatenate the pages together
tableOfPages = Table.FromList(listOfPages, Splitter.SplitByNothing(), {"Column1"}),
firstRow = tableOfPages{0}?
in
// if we didn't get back any pages of data, return an empty table
// otherwise set the table type based on the columns of the first page
if (firstRow = null) then
Table.FromRows({})
// check for empty first table
else if (Table.IsEmpty(firstRow[Column1])) then
firstRow[Column1]
else
Value.ReplaceType(
Table.ExpandTableColumn(tableOfPages, "Column1", Table.ColumnNames(firstRow[Column1])),
Value.Type(firstRow[Column1])
)
() => getNextPage(null),
(lastPage) => lastPage <> null,
(lastPage) => getNextPage(lastPage)
),
filteredListOfPages = List.Select(listOfPages, each not Table.IsEmpty(_)),
tableOfPages = Table.FromList(filteredListOfPages, Splitter.SplitByNothing(), {"Column1"}),
firstRow = tableOfPages{0}?,
appliedType =
if tableType <> null then tableType
else if firstRow <> null then Value.Type(firstRow[Column1])
else type table[],
columns = Record.FieldNames(Type.RecordFields(Type.TableRow(appliedType)))
in
Value.ReplaceType(
Table.ExpandTableColumn(tableOfPages, "Column1", columns),
appliedType
)