Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Diagnostics for error scenarios with authoring projects #1863

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

chenss3
Copy link

@chenss3 chenss3 commented Nov 8, 2024

Related to bug #1428

Create more specific diagnostic information when source generator fails. Build will also error so the user cannot use the broken winmd/projection anymore.

Also rerouted the error messages to go to StandardError instead of StandardOutput.

image

@chenss3 chenss3 marked this pull request as ready for review November 11, 2024 18:59
Copy link
Member

@Sergio0694 Sergio0694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! 👀

src/Authoring/WinRT.SourceGenerator/Generator.cs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants