Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Authoring] Allow custom overloads #1795

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[Authoring] Allow custom overloads #1795

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3e08d37
Allow custom overloads
dongle-the-gadget Sep 20, 2024
9e037b3
Remove unnecessary log.
dongle-the-gadget Sep 20, 2024
04b30c3
Move overload check to before while loop
dongle-the-gadget Sep 20, 2024
ae77643
Merge branch 'microsoft:master' into overload
dongle-the-gadget Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Authoring/WinRT.SourceGenerator/WinRTTypeWriter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1561,6 +1561,10 @@ private void AddOverloadAttributeForInterfaceMethods(TypeDeclaration interfaceTy
continue;
}

bool alreadyHasOverload = method.TryGetAttributeWithType(Model.Compilation.GetTypeByMetadataName("Windows.Foundation.Metadata.OverloadAttribute"), out AttributeData _);
if (alreadyHasOverload)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should be skipping when there is an attribute or if we should be checking the overloaded method name in the attribute if one is set and then using that below rather than the one we generate. Once you add the test case, we should be able to see whether the overload attribute is ending up in the winmd or not.

continue;

string overloadedMethodName = methodName.Key + (++lastSuffix);
while (interfaceTypeDeclaration.MethodsByName.ContainsKey(overloadedMethodName))
{
Expand Down