Fix reading the primary key property of resolved entities #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 8, 2024 15:55
…d entity from an abstract manifest. Currently fails due to incompatible types.
The attRef returned can be cast to the base CdmObject type in order to just retrieve the object definition name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes an issue where, when reading the
PrimaryKeyproperty of an entity which was resolved from an abstract manifest (with theidentifiedBypurpose on an attribute), the value cannot be retrieved.When
FetchTraitReferenceArgumentValuereturns the value of the argument for the resolvedis.identifiedBytrait, it returns either astringor aCdmAttributeReference. However, the subsequent process was looking to cast to aCdmTypeAttributeDefinition, which is not a compatible type. Since the only thing the code needs from that object is the name, it is safe to cast to theCdmObjectinstead and call the underlyingFetchObjectDefinitionName()method.This change makes the cast to
CdmObjectand returns the value successfully.A unit test which addresses this situation is also included in the changes.