Revert runtime snapshot fetching #6727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achamayou
approved these changes
Jan 7, 2025
2 tasks
eddyashton
added a commit
to eddyashton/CCF
that referenced
this pull request
Jan 15, 2025
This reverts commit 21197eb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #6700 and follow-up #6719.
This change had unintended consequences - linking
curlpulls in a (dynamically-linked)nghttp2whichlibcurldepends on. This is a very different version than what we have vendored, resulting in ABI mismatches and awkward segfaults.For now, we'll revert so this so we can cut
dev11with other desired changes. The longer-term resolution (to restore this snapshot-fetching behaviour via curl) is likely to changedlopenflags, but we need to confirm what we're doing with other cross-boundary dependencies (egsnmalloc) first.