Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace more of the public headers #6279

Merged
merged 9 commits into from
Jun 19, 2024

Conversation

achamayou
Copy link
Member

@achamayou achamayou commented Jun 17, 2024

See #3580.

  • ::ds is now ccf::ds
  • ::siphash is now ccf::siphash
  • ::threading is now ccf::threading, and ccf/ds/thread_ids.h has moved to ccf/threading/thread_ids.h
  • ::consensus is now ccf::consensus
  • ::tls is now ccf::tls

As we head towards 5.0 final, we have another opportunity to at least have a single top-level namespace, tighten public headers, and perhaps rationalise file and directory names.

@achamayou achamayou requested a review from a team June 17, 2024 16:25
Copy link
Member

@eddyashton eddyashton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a CHANGELOG.

@achamayou achamayou changed the title Namespace public parts of ds Namespace more of the public headers Jun 18, 2024
@achamayou achamayou merged commit dcb1329 into microsoft:main Jun 19, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants