Update protobufjs
#6254
Closed
Update protobufjs
#6254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps towards resolving CI failures.
A recent version of
protobufjshas reorganised the internal files, meaning the browser bundle include we previously used to work around protobufjs/protobuf.js#1402 was no longer available. I'm pinning to protobufjs7.2.4for now. Once we've resolved the other CI failures, I'll see if we can move to the more recent release and remove the import workaround.EDIT: Thought I was losing my mind investigating this, because it suddenly started working again. That's because there's a new-new release of protobuf.
Updated version requirement to
^7.3.2.