Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getters and versioned API to DynamicJSEndpointRegistry #6234

Merged
merged 21 commits into from
Jun 7, 2024
Merged

Add getters and versioned API to DynamicJSEndpointRegistry #6234

merged 21 commits into from
Jun 7, 2024

Conversation

eddyashton
Copy link
Member

I think we want to version the methods here, as we do for get_view_for_seqno_v1 etc. Additionally, I think we need some getter methods, so that apps can implement endpoints to read the installed JS app. This adds both.

eddyashton added 14 commits June 4, 2024 09:12
@eddyashton
Rename install_custom_endpoints to install_custom_endpoints_v1
74409bf
@eddyashton
Version custom_endpoints methods, add some getters
a727e68
@eddyashton
Implement get_custom_endpoints_v1
974a5d5
@eddyashton
Add an example GET endpoint, and a quick test of it
f687dd9
@eddyashton
Fewer hacks, try to return what you exactly what was written!
bf4ac12
@eddyashton
Quick test of module loading
e6c0239
@eddyashton
Merge branch 'main' of github.com:microsoft/CCF into versioned_instal…
f50f14a 
…l_custom_endpoints
@eddyashton
Fixup
abcd645
@eddyashton
Add a getter endpoint, and test
de5820d
@eddyashton
Merge branch 'main' of github.com:microsoft/CCF into versioned_instal…
2a072e0 
…l_custom_endpoints
@eddyashton
Bundle, not BundleWrapper
f29d432
@eddyashton
Normalise module paths, don't try to normalise anything else
efe6f6d
@eddyashton
Reproduce normalisation client side, so we can test equality
281d297
@eddyashton
Switch to query param for module_name
2dfbb10
@eddyashton eddyashton requested a review from a team June 6, 2024 10:54
achamayou
achamayou reviewed Jun 7, 2024
View reviewed changes
tests/programmability.py Outdated Show resolved Hide resolved
@eddyashton eddyashton enabled auto-merge (squash) June 7, 2024 15:28
@eddyashton eddyashton merged commit e7464e4 into microsoft:main Jun 7, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achamayou achamayou achamayou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eddyashton @achamayou