Ask ruff to autofix Python lint errors, where possible
#5903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achamayou
approved these changes
Jan 9, 2024
I don't think there was a reason, I think there were no group headings at first, then someone added them just for CI but didn't want to make the regular output more verbose. The script only did clang-format and pylint at first, with very minimal output, but has grown to call a whole bunch of things, so I agree that having the headings now makes a lot of sense. |
|
ci_checks_fix_ruff@80111 aka 20240110.6 vs main ewma over 20 builds from 79836 to 80102 Click to see tablemain
ci_checks_fix_ruff
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some errors that ruff spots, such as unused includes, it will print an error along the lines of "I could have tried to fix this automatically, if you'd given me the
--fixarg". It's odd-to-annoying ifthat appears when we have passed the-f[ix]arg to ourci-checkswrapper!So the wrapper's
fixmode now enables ruff'sfixmode, as it does with similar tools.Also, because we have mixed verbosity of the tools called from this wrapper, I've modified it to always print group headings. There might be a reason this was disabled, that I've forgotten? But I think it makes the output far more readable.