Discard malformed traffic sent to node-to-node ports #5889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achamayou
approved these changes
Jan 5, 2024
achamayou
added
auto-backport
|
node_to_node_robustness@80008 aka 20240108.24 vs main ewma over 20 builds from 79750 to 80001 Click to see tablemain
node_to_node_robustness
|
…nto node_to_node_robustness
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
achamayou
pushed a commit
to achamayou/CCF
that referenced
this pull request
Jan 9, 2024
(cherry picked from commit e618e51) # Conflicts: # CHANGELOG.md
achamayou
added a commit
that referenced
this pull request
Jan 9, 2024
…node ports (#5889) (#5900) Co-authored-by: Eddy Ashton <[email protected]>
eddyashton
added a commit
that referenced
this pull request
Jan 10, 2024
ghost
pushed a commit
that referenced
this pull request
Jan 10, 2024
(cherry picked from commit a56cf5c)
achamayou
pushed a commit
that referenced
this pull request
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Response to #5882.
Catch errors from malformed traffic, and close the sending TCP channel.
There may be some missed cases here, as we don't have exhaustive testing or fuzzing.
Also, some of this traffic that looks plausible enough to reach the enclave will still result in
[fail]messages which were previously present (eg - "Exception in recv_key_exchange_message"), whereas the newly dropped cases are only logged at[debug]. I've not dropped the verbosity of those existing messages now, though we may want to in future; for parity with the equivalent logging on the RPC ports, where we don't want random internet probing to result in worrying logs on running services.