Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow driver to name the first node #5876

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

achamayou
Copy link
Member

Useful for #5875, since the first node is usually known as "n1" in the spec, rather than "0" in the driver.

@achamayou achamayou requested a review from a team December 19, 2023 14:04
@ghost
Copy link

ghost commented Dec 19, 2023

driver_allows_naming_first_node@79620 aka 20231219.20 vs main ewma over 20 builds from 79268 to 79611

Click to see table

main

build_id build_number Commit latency factor tpcc_virtual_cft^ ls_virtual_cft^ pi_ls_virtual_cft^ pi_basic_virtual_cft^ pi_basic_js_virtual_cft^ ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ ls_js_virtual_cft^ ls_full_js_virtual_cft^ ls_js_jwt_virtual_cft^ hist_sgx_cft^ pi_basic_mt_sgx_cft^ pi_basic_mt_sgx_cft_mem tpcc_sgx_cft^ tpcc_sgx_cft_mem pi_basic_mt_virtual_cft^ ls_sgx_cft^ ls_sgx_cft_mem pi_ls_sgx_cft^ pi_ls_sgx_cft_mem pi_basic_sgx_cft^ pi_basic_sgx_cft_mem pi_basic_js_sgx_cft^ pi_basic_js_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^ tlc_3node_fixed_duration_s tlc_3node_fixed_states tlc_atomic_reconfig_duration_s tlc_atomic_reconfig_states tlc_reconfig_duration_s tlc_reconfig_states tlc_sim_traces tlc_sim_levelmean
79268 20231208.2 0.785068 17335.8 45512 48794.1 53682.9 4409.2 17151.7 19765.2 17409.1 14956.2 9763.8 44756.5 28108.2 2.51822e+07 5622.4 8.59996e+07 88746.9 14132.8 1.67936e+07 14180.7 1.05021e+07 15657.7 1.46964e+07 1434 1.25993e+07 6845.5 1.67936e+07 6976.9 6.30784e+06 5785.97 1.67936e+07 5729.53 1.67936e+07 3991.09 1.67936e+07 834932 1.18108e+06 8.15261e+06 3.08053e+07 6 86496 436 1.2541e+07 232 6.31473e+06 2275 403
79292 20231208.9 0.797384 17338.6 45729.5 48178.4 54133 4443 17002.7 19108 17651.6 14964 10050.8 35885.4 27684.3 2.51822e+07 5531.68 8.59996e+07 80975.3 14006.4 1.88908e+07 14091.2 1.05021e+07 15504.4 1.46964e+07 1436.4 1.25993e+07 6801.38 1.67936e+07 7135.7 6.30784e+06 5797.37 1.67936e+07 5478.95 1.67936e+07 3957.99 1.67936e+07 819873 1.17941e+06 8.13551e+06 3.12467e+07 6 86496 427 1.2541e+07 237 6.31473e+06 2408 403
79308 20231208.12 0.801386 17436.2 45781 49272.7 54718.5 4426.2 17304.6 19277.9 17480.2 15002.8 9762.56 45705.6 28212 2.30851e+07 5607.69 8.59996e+07 78390.1 14051.2 1.67936e+07 14091 1.05021e+07 15501.9 1.46964e+07 1434 1.25993e+07 7256.97 1.67936e+07 7079.1 6.30784e+06 5800.38 1.67936e+07 5451.23 1.67936e+07 3992.9 1.67936e+07 834092 1.18295e+06 8.14395e+06 3.07526e+07 7 86496 420 1.2541e+07 235 6.31473e+06 2391 403
79317 20231208.15 0.808619 17307.4 53155.6 56932.4 61359.2 4636.8 20997.1 21096.2 17801.8 17657.1 11585.4 41880.6 27807.3 2.30851e+07 5551.82 8.59996e+07 79114.7 14015.7 1.88908e+07 14114.4 1.05021e+07 15543.7 1.46964e+07 1435.1 1.25993e+07 7188.29 1.67936e+07 6913.9 6.30784e+06 5771.41 1.67936e+07 5421.15 1.67936e+07 3989.04 1.67936e+07 839369 1.18189e+06 8.15225e+06 3.04359e+07 6 86496 420 1.2541e+07 241 6.31473e+06 2262 403
79332 20231211.2 0.823766 17433.7 52927 56003.9 61022.8 4599.2 21051.1 21582 17445.1 17594.9 11551.9 45474 27810 2.30851e+07 5612.64 8.59996e+07 76565.5 14003.1 1.88908e+07 14079.5 1.05021e+07 15466.3 1.25993e+07 1435.6 1.25993e+07 6811.41 1.67936e+07 6925.1 6.30784e+06 5768.4 1.67936e+07 5468.54 1.67936e+07 3978.67 1.67936e+07 839138 1.18428e+06 8.08027e+06 3.07757e+07 7 86496 432 1.2541e+07 231 6.31473e+06 2304 403
79357 20231212.4 0.797083 17429.2 52984.5 56319 61280.2 4532.6 20801.4 22012.4 17643 17170 11561.7 45359.7 27519.2 2.51822e+07 5638.77 8.59996e+07 90921.5 14115.2 1.67936e+07 14088 1.05021e+07 15713.4 1.25993e+07 1435.1 1.05021e+07 6838.13 1.67936e+07 6976.5 6.30784e+06 5804.09 1.67936e+07 5497.14 1.88908e+07 3997.04 1.67936e+07 834796 1.18343e+06 8.15332e+06 3.14801e+07 6 86496 432 1.2541e+07 242 6.31473e+06 2399 403
79380 20231212.12 0.773242 17262.8 53208.5 55601.6 61170.8 4550.4 20701.5 21695.3 17743.3 17512.3 11736.7 45417.5 27820.3 2.51822e+07 5592.9 8.59996e+07 77796 14015.4 1.88908e+07 14143.2 1.05021e+07 15551.8 1.46964e+07 1430.7 1.25993e+07 6835.22 1.67936e+07 7038.9 6.30784e+06 5795.89 1.67936e+07 5455.38 1.67936e+07 3995.96 1.67936e+07 840421 1.1803e+06 8.14742e+06 3.0842e+07 6 86496 430 1.2541e+07 235 6.31473e+06 2276 403
79417 20231213.3 0.799203 17331.5 54074.6 55998.3 60854.9 4549.1 20830.3 21405.9 17583.1 17498.7 11795.5 40941.2 27977.8 2.51822e+07 5526.57 8.59996e+07 89315.5 13978 1.88908e+07 14050.6 1.05021e+07 15412.9 1.46964e+07 1422.3 1.25993e+07 7246.14 1.88908e+07 6986.5 6.30784e+06 5779.44 1.67936e+07 5496.45 1.67936e+07 3973.3 1.67936e+07 829829 1.18044e+06 8.14858e+06 3.06005e+07 7 86496 442 1.2541e+07 238 6.31473e+06 2231 403
79434 20231213.8 0.816491 17275 53213.7 57513.6 61723.7 4644.4 20960 22217.8 17470.1 17491.8 11851.5 45577.4 27808 2.51822e+07 5530.83 8.59996e+07 92614.6 13984.3 1.88908e+07 14104.9 1.05021e+07 15480.1 1.25993e+07 1431.7 1.25993e+07 7211.96 1.67936e+07 6886.8 6.30784e+06 5788.56 1.67936e+07 5440.74 1.67936e+07 3983.96 1.67936e+07 827161 1.18375e+06 8.14508e+06 3.08313e+07 6 86496 421 1.2541e+07 237 6.31473e+06 2233 403
79446 20231213.12 0.782907 23236.9 53060.2 56877 59818.1 4634.8 21298.4 21380.3 17316.3 17304.3 11684.8 45557.5 28186.7 2.51822e+07 5593.19 8.59996e+07 97090.7 14039.6 1.88908e+07 14149 1.05021e+07 15674.5 1.25993e+07 1436.6 1.25993e+07 7242.4 1.67936e+07 6984.3 6.30784e+06 5762.91 1.67936e+07 5427.06 1.67936e+07 3973.75 1.67936e+07 831821 1.17979e+06 8.15128e+06 3.07586e+07 6 86496 444 1.2541e+07 238 6.31473e+06 2434 403
79465 20231215.1 0.802551 17381.5 52770.6 48250.9 60902.4 4637.4 20733.7 21714.1 17823.5 17608.6 11850.7 46707.8 28034.7 2.51822e+07 5576.96 8.59996e+07 67952.2 14020.3 1.67936e+07 14139.8 1.05021e+07 15670.6 1.25993e+07 1428 1.25993e+07 6830.63 1.67936e+07 6979 6.30784e+06 5760.95 1.67936e+07 5458.5 1.67936e+07 3975.21 1.67936e+07 828628 1.17744e+06 8.15021e+06 3.07318e+07 6 86496 434 1.2541e+07 237 6.31473e+06 2529 403
79490 20231215.10 0.808629 17439.7 52882.3 57690.4 62945.6 4626.7 20983.4 22139.1 17810 17538.5 11709.8 43227.4 28234.5 2.51822e+07 5581.2 8.59996e+07 69636.7 13949.6 1.88908e+07 14031.2 1.05021e+07 15543 1.25993e+07 1424.1 1.25993e+07 6842.77 1.88908e+07 6872.4 6.30784e+06 5783.56 1.67936e+07 5437.74 1.67936e+07 3980.64 1.67936e+07 817356 1.17889e+06 8.03891e+06 3.07291e+07 6 86496 424 1.2541e+07 236 6.31473e+06 2218 403
79498 20231218.1 0.807324 17430.6 52804.9 57344.7 62811.8 4625.2 20662.5 22235.6 17248.4 17457.6 11779.1 43141.9 28418.5 2.51822e+07 5622.59 8.59996e+07 79157.2 14045 1.88908e+07 14148.1 1.05021e+07 15600.2 1.46964e+07 1432.7 1.25993e+07 6851.44 1.67936e+07 6983.3 6.30784e+06 5798.43 1.67936e+07 5498.66 1.88908e+07 4001.71 1.67936e+07 828229 1.16693e+06 8.11829e+06 3.09015e+07 6 86496 434 1.2541e+07 246 6.31473e+06 2301 403
79519 20231218.10 0.798259 17354 53225.5 57562.6 63172.6 4571.7 20561.7 22192.6 20824.9 17639.3 11774 43611.9 28034.3 2.30851e+07 5649.04 8.59996e+07 88022.4 14073.9 1.67936e+07 14131.2 1.05021e+07 15680.1 1.25993e+07 1434.1 1.25993e+07 7257.49 1.67936e+07 6926.8 6.30784e+06 5796.44 1.67936e+07 5496.59 1.88908e+07 4000.63 1.67936e+07 839283 1.18148e+06 8.14091e+06 3.13836e+07 6 86496 442 1.2541e+07 234 6.31473e+06 2266 403
79527 20231218.12 0.804365 17343.5 53109.2 56861.5 63383 4615.7 20975.3 21199 17583.3 17621.2 10246.3 41214.1 27882.3 2.51822e+07 5652.5 8.59996e+07 87764.2 14054.9 1.88908e+07 14156.8 1.05021e+07 15651.7 1.25993e+07 1434.7 1.25993e+07 7256.84 1.67936e+07 6931.3 6.30784e+06 5812.28 1.67936e+07 5490.43 1.67936e+07 3970.69 1.67936e+07 832631 1.18361e+06 8.16366e+06 3.09979e+07 6 86496 432 1.2541e+07 234 6.31473e+06 2415 403
79542 20231218.17 0.804376 16839.2 53015.6 56723.7 62722.4 4557.8 20754.6 21126.9 17414.4 17483.6 11568.2 43143.5 28109.4 2.51822e+07 5515.18 8.59996e+07 69097.4 14007.3 1.88908e+07 14094.4 1.05021e+07 15548.3 1.25993e+07 1421.3 1.25993e+07 6831.17 1.67936e+07 6933.8 6.30784e+06 5752.49 1.67936e+07 5482.48 1.67936e+07 3989.6 1.67936e+07 844389 1.17243e+06 8.14447e+06 3.0803e+07 6 86496 444 1.2541e+07 240 6.31473e+06 2402 403
79567 20231219.3 0.795646 17368.8 55627.2 56626.1 62713.3 4630.4 20932.7 21734.4 17750.5 17590.3 11679.7 41599.6 28206.2 2.51822e+07 5611.75 8.59996e+07 81521.8 14063.6 1.67936e+07 14157.8 1.05021e+07 15638.2 1.46964e+07 1436.2 1.25993e+07 7272.8 1.67936e+07 6997.9 6.30784e+06 5800.99 1.67936e+07 5722.19 1.88908e+07 3967.94 1.67936e+07 833208 1.18146e+06 8.13641e+06 3.33991e+07 6 86496 430 1.2541e+07 233 6.31473e+06 2184 403
79588 20231219.11 0.814283 17317.5 53109.2 56478.3 58259.5 4621.8 20778.6 21632.8 20842.2 17459.4 11668.3 45838.7 27802.7 2.30851e+07 5611.96 8.59996e+07 74190.4 14052.5 1.88908e+07 14207.7 1.05021e+07 15610.1 1.25993e+07 1427.9 1.25993e+07 7239.63 1.67936e+07 6934.5 6.30784e+06 5752.75 1.67936e+07 5730.57 1.88908e+07 3975.98 1.67936e+07 828389 1.18457e+06 8.13215e+06 3.19566e+07 6 86496 423 1.2541e+07 242 6.31473e+06 2351 403
79604 20231219.15 0.806726 17471.7 53128.4 57049.3 63174.4 4649.5 20576.8 21778 17665.7 17429 11721.7 46717.2 28041.5 2.51822e+07 5652.29 8.59996e+07 98705.3 14034.6 1.88908e+07 14150.8 1.05021e+07 15632 1.25993e+07 1432.3 1.25993e+07 6876.9 1.67936e+07 6919.6 6.30784e+06 5771.57 1.67936e+07 5738.72 1.67936e+07 3971.34 1.67936e+07 832710 1.17881e+06 8.16395e+06 3.10661e+07 6 86496 433 1.2541e+07 240 6.31473e+06 2346 403
79611 20231219.17 0.822773 17836.6 53012.7 56994.3 62802.2 4503.5 20997.7 22145.9 17826.8 17670.9 11664.7 41541.3 27994.7 2.51822e+07 5549.24 8.59996e+07 75455.9 13991.6 1.67936e+07 14084.8 1.05021e+07 15528.8 1.46964e+07 1416.9 1.25993e+07 6888.13 1.88908e+07 6885 6.30784e+06 5798.46 1.67936e+07 5454.42 1.67936e+07 3798.13 1.67936e+07 828514 1.18511e+06 8.1358e+06 3.07457e+07 6 86496 426 1.2541e+07 241 6.31473e+06 2317 403

driver_allows_naming_first_node

build_id build_number pi_basic_mt_sgx_cft^ pi_basic_mt_sgx_cft_mem Commit latency factor tpcc_sgx_cft^ tpcc_sgx_cft_mem tpcc_virtual_cft^ ls_virtual_cft^ pi_ls_virtual_cft^ pi_basic_virtual_cft^ ls_sgx_cft^ ls_sgx_cft_mem pi_ls_sgx_cft^ pi_ls_sgx_cft_mem pi_basic_js_virtual_cft^ pi_basic_sgx_cft^ pi_basic_sgx_cft_mem ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ ls_js_virtual_cft^ ls_full_js_virtual_cft^ ls_js_jwt_virtual_cft^ pi_basic_js_sgx_cft^ pi_basic_js_sgx_cft_mem pi_basic_mt_virtual_cft^ ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem hist_sgx_cft^ ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem tlc_3node_fixed_duration_s tlc_3node_fixed_states tlc_atomic_reconfig_duration_s tlc_atomic_reconfig_states tlc_reconfig_duration_s tlc_reconfig_states RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^ tlc_sim_traces tlc_sim_levelmean
79620 20231219.20 27926 2.30851e+07 0.843912 5642.98 8.59996e+07 17443.7 53129.4 56145.1 62044.6 14054.3 1.88908e+07 14124.2 1.05021e+07 4597.3 15636.9 1.46964e+07 20679 21833.1 17569.7 17275.5 11613.2 1440 1.25993e+07 85242.1 7195.1 1.67936e+07 6984.2 6.30784e+06 5775.35 1.67936e+07 43796 5486.98 1.67936e+07 3998.35 1.67936e+07 6 86496 421 1.2541e+07 240 6.31473e+06 810146 1.18098e+06 8.16506e+06 3.07438e+07 2370 403

images

@achamayou achamayou merged commit 5daf0c7 into microsoft:main Dec 19, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant