Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ccf::historical::adapter_v2 #5873

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

achamayou
Copy link
Member

adapter_v3 was first introduced in 2.0.0.

@achamayou achamayou requested a review from a team December 19, 2023 09:19
@ghost
Copy link

ghost commented Dec 19, 2023

remove_historical_adapter_v2@79582 aka 20231219.8 vs main ewma over 20 builds from 79229 to 79567

Click to see table

main

build_id build_number pi_basic_mt_sgx_cft^ pi_basic_mt_sgx_cft_mem Commit latency factor pi_basic_mt_virtual_cft^ tpcc_sgx_cft^ tpcc_sgx_cft_mem tpcc_virtual_cft^ ls_virtual_cft^ pi_ls_virtual_cft^ pi_basic_virtual_cft^ ls_sgx_cft^ ls_sgx_cft_mem pi_ls_sgx_cft^ pi_ls_sgx_cft_mem pi_basic_js_virtual_cft^ pi_basic_sgx_cft^ pi_basic_sgx_cft_mem ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ ls_js_virtual_cft^ ls_full_js_virtual_cft^ ls_js_jwt_virtual_cft^ pi_basic_js_sgx_cft^ pi_basic_js_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem hist_sgx_cft^ ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem tlc_3node_fixed_duration_s tlc_3node_fixed_states tlc_atomic_reconfig_duration_s tlc_atomic_reconfig_states tlc_reconfig_duration_s tlc_reconfig_states RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^ tlc_sim_traces tlc_sim_levelmean
79229 20231207.3 27926.5 2.30851e+07 0.776247 75875.6 5576.6 8.59996e+07 17255.2 45542.6 48633.4 53726.7 13955.9 1.88908e+07 14087.4 1.05021e+07 4386.5 15602.3 1.46964e+07 17128.4 19449.2 17242 14480.2 10294.2 1420.3 1.25993e+07 7247.5 1.67936e+07 7153.1 6.30784e+06 5768.83 1.67936e+07 43978.5 5480.6 1.67936e+07 3988.57 1.67936e+07 6 86496 427 1.2541e+07 240 6.31473e+06 807709 1.17338e+06 8.14541e+06 3.0748e+07 2349 403
79234 20231207.5 27907.2 2.30851e+07 0.787179 83093.4 5559.41 8.59996e+07 17330.6 45876.2 49246.5 53613.6 14029 1.88908e+07 14143.7 1.05021e+07 4405.8 15552.2 1.46964e+07 17443.4 19927.1 17334.1 14833.1 9850.31 1426.4 1.25993e+07 6881.89 1.67936e+07 6972.6 6.30784e+06 5798.24 1.67936e+07 42217.5 5492.31 1.88908e+07 3987.77 1.67936e+07 6 86496 421 1.2541e+07 235 6.31473e+06 834683 1.17911e+06 8.13234e+06 3.12109e+07 2368 403
79265 20231207.15 28128.3 2.51822e+07 0.787657 83400.4 5571.27 8.59996e+07 17117.4 45634.9 49763.9 53593.9 14013.5 1.88908e+07 14038.2 1.05021e+07 4364.3 15575 1.46964e+07 17149.3 19160.8 17062.5 15007.2 9901.93 1429.5 1.25993e+07 7214.04 1.67936e+07 6968.4 6.30784e+06 5796.77 1.67936e+07 45208.2 5482.18 1.67936e+07 3997.21 1.67936e+07 6 86496 418 1.2541e+07 232 6.31473e+06 844021 1.18032e+06 8.15491e+06 3.079e+07 2369 403
79268 20231208.2 28108.2 2.51822e+07 0.785068 88746.9 5622.4 8.59996e+07 17335.8 45512 48794.1 53682.9 14132.8 1.67936e+07 14180.7 1.05021e+07 4409.2 15657.7 1.46964e+07 17151.7 19765.2 17409.1 14956.2 9763.8 1434 1.25993e+07 6845.5 1.67936e+07 6976.9 6.30784e+06 5785.97 1.67936e+07 44756.5 5729.53 1.67936e+07 3991.09 1.67936e+07 6 86496 436 1.2541e+07 232 6.31473e+06 834932 1.18108e+06 8.15261e+06 3.08053e+07 2275 403
79292 20231208.9 27684.3 2.51822e+07 0.797384 80975.3 5531.68 8.59996e+07 17338.6 45729.5 48178.4 54133 14006.4 1.88908e+07 14091.2 1.05021e+07 4443 15504.4 1.46964e+07 17002.7 19108 17651.6 14964 10050.8 1436.4 1.25993e+07 6801.38 1.67936e+07 7135.7 6.30784e+06 5797.37 1.67936e+07 35885.4 5478.95 1.67936e+07 3957.99 1.67936e+07 6 86496 427 1.2541e+07 237 6.31473e+06 819873 1.17941e+06 8.13551e+06 3.12467e+07 2408 403
79308 20231208.12 28212 2.30851e+07 0.801386 78390.1 5607.69 8.59996e+07 17436.2 45781 49272.7 54718.5 14051.2 1.67936e+07 14091 1.05021e+07 4426.2 15501.9 1.46964e+07 17304.6 19277.9 17480.2 15002.8 9762.56 1434 1.25993e+07 7256.97 1.67936e+07 7079.1 6.30784e+06 5800.38 1.67936e+07 45705.6 5451.23 1.67936e+07 3992.9 1.67936e+07 7 86496 420 1.2541e+07 235 6.31473e+06 834092 1.18295e+06 8.14395e+06 3.07526e+07 2391 403
79317 20231208.15 27807.3 2.30851e+07 0.808619 79114.7 5551.82 8.59996e+07 17307.4 53155.6 56932.4 61359.2 14015.7 1.88908e+07 14114.4 1.05021e+07 4636.8 15543.7 1.46964e+07 20997.1 21096.2 17801.8 17657.1 11585.4 1435.1 1.25993e+07 7188.29 1.67936e+07 6913.9 6.30784e+06 5771.41 1.67936e+07 41880.6 5421.15 1.67936e+07 3989.04 1.67936e+07 6 86496 420 1.2541e+07 241 6.31473e+06 839369 1.18189e+06 8.15225e+06 3.04359e+07 2262 403
79332 20231211.2 27810 2.30851e+07 0.823766 76565.5 5612.64 8.59996e+07 17433.7 52927 56003.9 61022.8 14003.1 1.88908e+07 14079.5 1.05021e+07 4599.2 15466.3 1.25993e+07 21051.1 21582 17445.1 17594.9 11551.9 1435.6 1.25993e+07 6811.41 1.67936e+07 6925.1 6.30784e+06 5768.4 1.67936e+07 45474 5468.54 1.67936e+07 3978.67 1.67936e+07 7 86496 432 1.2541e+07 231 6.31473e+06 839138 1.18428e+06 8.08027e+06 3.07757e+07 2304 403
79357 20231212.4 27519.2 2.51822e+07 0.797083 90921.5 5638.77 8.59996e+07 17429.2 52984.5 56319 61280.2 14115.2 1.67936e+07 14088 1.05021e+07 4532.6 15713.4 1.25993e+07 20801.4 22012.4 17643 17170 11561.7 1435.1 1.05021e+07 6838.13 1.67936e+07 6976.5 6.30784e+06 5804.09 1.67936e+07 45359.7 5497.14 1.88908e+07 3997.04 1.67936e+07 6 86496 432 1.2541e+07 242 6.31473e+06 834796 1.18343e+06 8.15332e+06 3.14801e+07 2399 403
79380 20231212.12 27820.3 2.51822e+07 0.773242 77796 5592.9 8.59996e+07 17262.8 53208.5 55601.6 61170.8 14015.4 1.88908e+07 14143.2 1.05021e+07 4550.4 15551.8 1.46964e+07 20701.5 21695.3 17743.3 17512.3 11736.7 1430.7 1.25993e+07 6835.22 1.67936e+07 7038.9 6.30784e+06 5795.89 1.67936e+07 45417.5 5455.38 1.67936e+07 3995.96 1.67936e+07 6 86496 430 1.2541e+07 235 6.31473e+06 840421 1.1803e+06 8.14742e+06 3.0842e+07 2276 403
79417 20231213.3 27977.8 2.51822e+07 0.799203 89315.5 5526.57 8.59996e+07 17331.5 54074.6 55998.3 60854.9 13978 1.88908e+07 14050.6 1.05021e+07 4549.1 15412.9 1.46964e+07 20830.3 21405.9 17583.1 17498.7 11795.5 1422.3 1.25993e+07 7246.14 1.88908e+07 6986.5 6.30784e+06 5779.44 1.67936e+07 40941.2 5496.45 1.67936e+07 3973.3 1.67936e+07 7 86496 442 1.2541e+07 238 6.31473e+06 829829 1.18044e+06 8.14858e+06 3.06005e+07 2231 403
79434 20231213.8 27808 2.51822e+07 0.816491 92614.6 5530.83 8.59996e+07 17275 53213.7 57513.6 61723.7 13984.3 1.88908e+07 14104.9 1.05021e+07 4644.4 15480.1 1.25993e+07 20960 22217.8 17470.1 17491.8 11851.5 1431.7 1.25993e+07 7211.96 1.67936e+07 6886.8 6.30784e+06 5788.56 1.67936e+07 45577.4 5440.74 1.67936e+07 3983.96 1.67936e+07 6 86496 421 1.2541e+07 237 6.31473e+06 827161 1.18375e+06 8.14508e+06 3.08313e+07 2233 403
79446 20231213.12 28186.7 2.51822e+07 0.782907 97090.7 5593.19 8.59996e+07 23236.9 53060.2 56877 59818.1 14039.6 1.88908e+07 14149 1.05021e+07 4634.8 15674.5 1.25993e+07 21298.4 21380.3 17316.3 17304.3 11684.8 1436.6 1.25993e+07 7242.4 1.67936e+07 6984.3 6.30784e+06 5762.91 1.67936e+07 45557.5 5427.06 1.67936e+07 3973.75 1.67936e+07 6 86496 444 1.2541e+07 238 6.31473e+06 831821 1.17979e+06 8.15128e+06 3.07586e+07 2434 403
79465 20231215.1 28034.7 2.51822e+07 0.802551 67952.2 5576.96 8.59996e+07 17381.5 52770.6 48250.9 60902.4 14020.3 1.67936e+07 14139.8 1.05021e+07 4637.4 15670.6 1.25993e+07 20733.7 21714.1 17823.5 17608.6 11850.7 1428 1.25993e+07 6830.63 1.67936e+07 6979 6.30784e+06 5760.95 1.67936e+07 46707.8 5458.5 1.67936e+07 3975.21 1.67936e+07 6 86496 434 1.2541e+07 237 6.31473e+06 828628 1.17744e+06 8.15021e+06 3.07318e+07 2529 403
79490 20231215.10 28234.5 2.51822e+07 0.808629 69636.7 5581.2 8.59996e+07 17439.7 52882.3 57690.4 62945.6 13949.6 1.88908e+07 14031.2 1.05021e+07 4626.7 15543 1.25993e+07 20983.4 22139.1 17810 17538.5 11709.8 1424.1 1.25993e+07 6842.77 1.88908e+07 6872.4 6.30784e+06 5783.56 1.67936e+07 43227.4 5437.74 1.67936e+07 3980.64 1.67936e+07 6 86496 424 1.2541e+07 236 6.31473e+06 817356 1.17889e+06 8.03891e+06 3.07291e+07 2218 403
79498 20231218.1 28418.5 2.51822e+07 0.807324 79157.2 5622.59 8.59996e+07 17430.6 52804.9 57344.7 62811.8 14045 1.88908e+07 14148.1 1.05021e+07 4625.2 15600.2 1.46964e+07 20662.5 22235.6 17248.4 17457.6 11779.1 1432.7 1.25993e+07 6851.44 1.67936e+07 6983.3 6.30784e+06 5798.43 1.67936e+07 43141.9 5498.66 1.88908e+07 4001.71 1.67936e+07 6 86496 434 1.2541e+07 246 6.31473e+06 828229 1.16693e+06 8.11829e+06 3.09015e+07 2301 403
79519 20231218.10 28034.3 2.30851e+07 0.798259 88022.4 5649.04 8.59996e+07 17354 53225.5 57562.6 63172.6 14073.9 1.67936e+07 14131.2 1.05021e+07 4571.7 15680.1 1.25993e+07 20561.7 22192.6 20824.9 17639.3 11774 1434.1 1.25993e+07 7257.49 1.67936e+07 6926.8 6.30784e+06 5796.44 1.67936e+07 43611.9 5496.59 1.88908e+07 4000.63 1.67936e+07 6 86496 442 1.2541e+07 234 6.31473e+06 839283 1.18148e+06 8.14091e+06 3.13836e+07 2266 403
79527 20231218.12 27882.3 2.51822e+07 0.804365 87764.2 5652.5 8.59996e+07 17343.5 53109.2 56861.5 63383 14054.9 1.88908e+07 14156.8 1.05021e+07 4615.7 15651.7 1.25993e+07 20975.3 21199 17583.3 17621.2 10246.3 1434.7 1.25993e+07 7256.84 1.67936e+07 6931.3 6.30784e+06 5812.28 1.67936e+07 41214.1 5490.43 1.67936e+07 3970.69 1.67936e+07 6 86496 432 1.2541e+07 234 6.31473e+06 832631 1.18361e+06 8.16366e+06 3.09979e+07 2415 403
79542 20231218.17 28109.4 2.51822e+07 0.804376 69097.4 5515.18 8.59996e+07 16839.2 53015.6 56723.7 62722.4 14007.3 1.88908e+07 14094.4 1.05021e+07 4557.8 15548.3 1.25993e+07 20754.6 21126.9 17414.4 17483.6 11568.2 1421.3 1.25993e+07 6831.17 1.67936e+07 6933.8 6.30784e+06 5752.49 1.67936e+07 43143.5 5482.48 1.67936e+07 3989.6 1.67936e+07 6 86496 444 1.2541e+07 240 6.31473e+06 844389 1.17243e+06 8.14447e+06 3.0803e+07 2402 403
79567 20231219.3 28206.2 2.51822e+07 0.795646 81521.8 5611.75 8.59996e+07 17368.8 55627.2 56626.1 62713.3 14063.6 1.67936e+07 14157.8 1.05021e+07 4630.4 15638.2 1.46964e+07 20932.7 21734.4 17750.5 17590.3 11679.7 1436.2 1.25993e+07 7272.8 1.67936e+07 6997.9 6.30784e+06 5800.99 1.67936e+07 41599.6 5722.19 1.88908e+07 3967.94 1.67936e+07 6 86496 430 1.2541e+07 233 6.31473e+06 833208 1.18146e+06 8.13641e+06 3.33991e+07 2184 403

remove_historical_adapter_v2

build_id build_number Commit latency factor tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_sgx_cft^ ls_sgx_cft_mem pi_ls_sgx_cft^ pi_ls_sgx_cft_mem pi_basic_sgx_cft^ pi_basic_sgx_cft_mem pi_basic_js_sgx_cft^ pi_basic_js_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem hist_sgx_cft^ RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^ pi_basic_mt_sgx_cft^ pi_basic_mt_sgx_cft_mem tlc_3node_fixed_duration_s tlc_3node_fixed_states tlc_atomic_reconfig_duration_s tlc_atomic_reconfig_states tlc_reconfig_duration_s tlc_reconfig_states tpcc_virtual_cft^ ls_virtual_cft^ pi_ls_virtual_cft^ pi_basic_virtual_cft^ pi_basic_js_virtual_cft^ ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ ls_js_virtual_cft^ ls_full_js_virtual_cft^ pi_basic_mt_virtual_cft^ ls_js_jwt_virtual_cft^ tlc_sim_traces tlc_sim_levelmean
79582 20231219.8 0.80741 5620.43 8.59996e+07 14068.4 1.88908e+07 14144.5 1.05021e+07 15709.5 1.25993e+07 1436.2 1.25993e+07 7265.02 1.67936e+07 7066.4 6.30784e+06 5791.84 1.67936e+07 5487.59 1.67936e+07 3996.02 1.67936e+07 40531 831748 1.17841e+06 8.13809e+06 3.07245e+07 28142.9 2.30851e+07 6 86496 431 1.2541e+07 238 6.31473e+06 17410.1 52909.5 56402.9 62074.5 4618.7 21149.2 21871.8 20803.2 17768.1 71120.2 11646.2 2341 403

images

@achamayou achamayou merged commit 2ea3867 into microsoft:main Dec 19, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant