Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow explicit port in SNP endorsements config #5858

Merged

Conversation

achamayou
Copy link
Member

@achamayou achamayou commented Dec 7, 2023

Allow specifying explicit ports in snp endorsement URLs.

@achamayou achamayou requested a review from a team December 7, 2023 17:07
@ghost
Copy link

ghost commented Dec 7, 2023

allow_explicit_port_in_snp_endorsements@79277 aka 20231208.5 vs main ewma over 20 builds from 78953 to 79268

Click to see table

main

build_id build_number Commit latency factor tpcc_sgx_cft^ tpcc_sgx_cft_mem tlc_3node_fixed_duration_s tlc_3node_fixed_states tlc_atomic_reconfig_duration_s tlc_atomic_reconfig_states tlc_reconfig_duration_s tlc_reconfig_states ls_sgx_cft^ ls_sgx_cft_mem pi_ls_sgx_cft^ pi_ls_sgx_cft_mem pi_basic_sgx_cft^ pi_basic_sgx_cft_mem pi_basic_js_sgx_cft^ pi_basic_js_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem pi_basic_mt_virtual_cft^ hist_sgx_cft^ RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^ tpcc_virtual_cft^ tlc_sim_traces tlc_sim_levelmean ls_virtual_cft^ pi_ls_virtual_cft^ pi_basic_virtual_cft^ pi_basic_js_virtual_cft^ ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ ls_js_virtual_cft^ ls_full_js_virtual_cft^ ls_js_jwt_virtual_cft^ pi_basic_mt_sgx_cft^ pi_basic_mt_sgx_cft_mem
78953 20231123.8 0.810533 5604.37 8.59996e+07 6 86496 420 1.2541e+07 237 6.31473e+06 14030.4 1.88908e+07 14076.6 1.05021e+07 15674 1.46964e+07 1437.1 1.25993e+07 6830.93 1.67936e+07 6958.4 6.30784e+06 5765.5 1.67936e+07 5731.04 1.88908e+07 3993.18 1.67936e+07 75339 45694.6 829649 1.17942e+06 8.14279e+06 3.07688e+07 17264.5 2331 403 45863.8 49175.8 53925.3 4391.7 17295.3 19719.6 17605.8 14888.2 10394.9 27789.8 2.51822e+07
78967 20231124.2 0.782565 5619.27 8.59996e+07 6 86496 439 1.2541e+07 240 6.31473e+06 14047.6 1.88908e+07 14120.8 1.05021e+07 15603.3 1.46964e+07 1434.1 1.25993e+07 6862.89 1.88908e+07 7057.8 6.30784e+06 5805.21 1.67936e+07 5477.8 1.67936e+07 3995.96 1.67936e+07 72019.2 43678.4 833717 1.17934e+06 8.1552e+06 3.07882e+07 17245.4 2280 403 45777.6 49218.4 54646.7 4429.9 17407.9 19488.2 17750.3 14995.5 10073.9 27595.4 2.51822e+07
78987 20231127.2 0.791971 5574.76 8.59996e+07 6 86496 424 1.2541e+07 238 6.31473e+06 14018.8 1.67936e+07 14108.5 1.05021e+07 15515 1.46964e+07 1433.2 1.25993e+07 7228.12 1.67936e+07 7141.5 6.30784e+06 5801.53 1.67936e+07 5724.29 1.88908e+07 3966.89 1.67936e+07 72391.9 39610.6 828249 1.18027e+06 8.13531e+06 3.11147e+07 17383.7 2249 403 45643.3 47824.5 52921.6 4384.3 17164.6 19797.7 17253.6 14765 10224.5 27968.2 2.30851e+07
79003 20231128.3 0.808064 5630.81 8.59996e+07 6 86496 436 1.2541e+07 238 6.31473e+06 14033.1 1.88908e+07 14112.5 1.05021e+07 15713.1 1.25993e+07 1443.3 1.25993e+07 7243.52 1.67936e+07 6982.1 6.30784e+06 5774.56 1.67936e+07 5499.24 1.67936e+07 4000 1.67936e+07 74088.1 45424.2 832500 1.18572e+06 8.1335e+06 3.08016e+07 17241.6 2261 403 45776.3 49222.8 54048.1 4425.8 17355.8 19581 17718.1 14977.7 10405.5 28069.8 2.51822e+07
79017 20231128.8 0.777555 5513.34 8.59996e+07 7 86496 423 1.2541e+07 235 6.31473e+06 13929.8 1.67936e+07 14036.2 1.05021e+07 15556.7 1.46964e+07 1424.7 1.05021e+07 6825.88 1.88908e+07 6924.2 6.30784e+06 5756.18 1.67936e+07 5452.73 1.67936e+07 3981.38 1.67936e+07 87116.5 45536.5 834575 1.18271e+06 8.12869e+06 3.11886e+07 17368.5 2348 403 45922.7 48602.4 52895.1 4381.8 17214.7 19210.1 14772.6 14769.4 9844.71 28108.5 2.51822e+07
79027 20231129.3 0.850433 5633.41 8.59996e+07 6 86496 430 1.2541e+07 241 6.31473e+06 14061.7 1.67936e+07 14072.4 1.05021e+07 15503.4 1.25993e+07 1445.1 1.25993e+07 7250.65 1.67936e+07 6971.9 6.30784e+06 5764.23 1.67936e+07 5492.7 1.67936e+07 3989.44 1.67936e+07 77809.8 44876.6 827666 1.18103e+06 8.17317e+06 3.05084e+07 17328 2207 403 45518.3 48796.2 54537.1 4360.3 17258.6 19599.4 17278.1 14638.3 10065.2 28279.5 2.51822e+07
79046 20231130.2 0.83449 5576.15 8.59996e+07 6 86496 443 1.2541e+07 244 6.31473e+06 14053 1.88908e+07 14169 1.05021e+07 15651.9 1.46964e+07 1431.6 1.25993e+07 7264.35 1.67936e+07 7007.9 6.30784e+06 5802.34 1.67936e+07 5487.61 1.88908e+07 3997.16 1.67936e+07 63701.8 47192 826230 1.18553e+06 8.15429e+06 3.07836e+07 17294.1 2107 403 45702.6 48491.2 54537.7 4355.6 17328.1 19849.1 15010.4 14818.5 10271.1 28025.3 2.30851e+07
79070 20231201.3 0.810711 5560.05 8.59996e+07 6 86496 438 1.2541e+07 242 6.31473e+06 14004.4 1.88908e+07 14042.9 1.05021e+07 15546.5 1.25993e+07 1427.9 1.25993e+07 7200.49 1.67936e+07 6928.4 6.30784e+06 5794.45 1.67936e+07 5473.42 1.67936e+07 3989.21 1.67936e+07 86296.3 40218.5 836232 1.18818e+06 8.16652e+06 3.16176e+07 17453.8 2362 403 45445.2 49724 55215.6 4354.4 17090.5 19141.3 17522.5 15060.7 9957.13 27858.8 2.51822e+07
79105 20231204.2 0.815873 5602.98 8.59996e+07 6 86496 428 1.2541e+07 239 6.31473e+06 14008.7 1.88908e+07 14125.9 1.05021e+07 15572.3 1.25993e+07 1437 1.05021e+07 6851.44 1.88908e+07 6973.1 6.30784e+06 5750.64 1.67936e+07 5733.89 1.88908e+07 3965.95 1.67936e+07 73754 46153.5 840283 1.17731e+06 8.13547e+06 3.07046e+07 17179.5 2385 403 45756.3 47733.8 54949.6 4389.4 17055.4 19057.1 17280.4 14880.9 10265.5 27999.5 2.30851e+07
79118 20231204.7 0.84316 5635.13 8.80968e+07 6 86496 433 1.2541e+07 239 6.31473e+06 14068.5 1.88908e+07 14171.9 1.05021e+07 15653.9 1.46964e+07 1432.9 1.25993e+07 6802.32 1.67936e+07 6974.7 6.30784e+06 5792.64 1.67936e+07 5741.3 1.67936e+07 3997.22 1.67936e+07 75841.7 46677 825189 1.18013e+06 8.15465e+06 3.09674e+07 17330.1 2246 403 45759.3 47756.9 54515.7 4374.4 17110.2 19464.3 14917.2 14816.1 10346.3 27945 2.30851e+07
79134 20231204.11 0.815447 5641.99 8.59996e+07 6 86496 419 1.2541e+07 238 6.31473e+06 14020.8 1.88908e+07 14079.7 1.05021e+07 15626.3 1.46964e+07 1427.2 1.25993e+07 7228.64 1.67936e+07 6997.8 6.30784e+06 5768.48 1.67936e+07 5727.26 1.67936e+07 3996.59 1.67936e+07 78037.6 41803.1 828515 1.17548e+06 8.154e+06 3.14453e+07 17141.9 2306 403 45772 48406.7 55596 4381.4 17174.3 19191.6 17496.7 14891.7 9761.62 28102.5 2.51822e+07
79141 20231204.13 0.803932 5596.8 8.59996e+07 7 86496 437 1.2541e+07 236 6.31473e+06 14021.8 1.88908e+07 14166.7 1.05021e+07 15588.9 1.46964e+07 1424.7 1.25993e+07 6827.57 1.67936e+07 6930.3 6.30784e+06 5758.06 1.67936e+07 5444.11 1.67936e+07 3958.22 1.67936e+07 68327.2 42083.3 837008 1.16971e+06 8.15053e+06 3.08527e+07 17326.7 2347 403 45803.4 48363.9 54732.4 4380.2 17105.9 19712.6 17469.6 14760 9752.86 27783.3 2.51822e+07
79155 20231205.3 0.815693 5640.34 8.59996e+07 7 86496 445 1.2541e+07 245 6.31473e+06 14015.6 1.88908e+07 14121.4 1.05021e+07 15576.6 1.25993e+07 1421.7 1.25993e+07 7225.51 1.67936e+07 6929.8 6.30784e+06 5803.52 1.67936e+07 5488.73 1.67936e+07 3996.47 1.67936e+07 62066.6 43564.2 828148 1.18265e+06 8.14427e+06 3.06798e+07 17317.4 2148 403 45707.7 48471.2 55405.6 4408 17078.1 19050.9 17418.2 14930.7 10292.2 28082.1 2.51822e+07
79174 20231205.9 0.832702 5588.32 8.59996e+07 7 86496 427 1.2541e+07 247 6.31473e+06 14034.2 1.88908e+07 14128.5 1.05021e+07 15569 1.25993e+07 1437.6 1.25993e+07 7243.3 1.67936e+07 6934 6.30784e+06 5805.18 1.67936e+07 5487.13 1.67936e+07 3984.99 1.67936e+07 59992.5 42419.1 818484 1.18115e+06 8.15014e+06 3.08411e+07 17291.4 2348 403 45646.2 48780.5 54658 4392.8 17097.2 19587.1 17435.5 14830.4 10290.4 28158.4 2.30851e+07
79191 20231206.3 0.807565 5586.2 8.59996e+07 6 86496 425 1.2541e+07 232 6.31473e+06 13984 1.88908e+07 14096.6 1.05021e+07 15550.9 1.46964e+07 1433.3 1.05021e+07 6873.92 1.88908e+07 6934.2 6.30784e+06 5757.97 1.67936e+07 5477.84 1.67936e+07 3988.75 1.67936e+07 80506.2 44489 811835 1.17162e+06 8.15462e+06 3.06807e+07 17240.9 2348 403 45694.4 47829.7 55088.2 4390.5 17224.7 19225.6 17518.6 16586.7 9748.83 27937.7 2.51822e+07
79212 20231206.9 0.787436 5550.7 8.59996e+07 6 86496 422 1.2541e+07 237 6.31473e+06 13991.9 1.88908e+07 14088.3 1.05021e+07 15563.8 1.46964e+07 1431.7 1.25993e+07 6829.75 1.67936e+07 7031.6 6.30784e+06 5794.64 1.67936e+07 5485.33 1.67936e+07 3993.8 1.67936e+07 76936.9 45135.1 836211 1.18495e+06 8.16066e+06 3.20255e+07 17165.4 2341 403 45737.6 43246.8 55022.1 4400.7 17059.5 19190.5 17109.9 14889.3 9772.13 27757.3 2.30851e+07
79229 20231207.3 0.776247 5576.6 8.59996e+07 6 86496 427 1.2541e+07 240 6.31473e+06 13955.9 1.88908e+07 14087.4 1.05021e+07 15602.3 1.46964e+07 1420.3 1.25993e+07 7247.5 1.67936e+07 7153.1 6.30784e+06 5768.83 1.67936e+07 5480.6 1.67936e+07 3988.57 1.67936e+07 75875.6 43978.5 807709 1.17338e+06 8.14541e+06 3.0748e+07 17255.2 2349 403 45542.6 48633.4 53726.7 4386.5 17128.4 19449.2 17242 14480.2 10294.2 27926.5 2.30851e+07
79234 20231207.5 0.787179 5559.41 8.59996e+07 6 86496 421 1.2541e+07 235 6.31473e+06 14029 1.88908e+07 14143.7 1.05021e+07 15552.2 1.46964e+07 1426.4 1.25993e+07 6881.89 1.67936e+07 6972.6 6.30784e+06 5798.24 1.67936e+07 5492.31 1.88908e+07 3987.77 1.67936e+07 83093.4 42217.5 834683 1.17911e+06 8.13234e+06 3.12109e+07 17330.6 2368 403 45876.2 49246.5 53613.6 4405.8 17443.4 19927.1 17334.1 14833.1 9850.31 27907.2 2.30851e+07
79265 20231207.15 0.787657 5571.27 8.59996e+07 6 86496 418 1.2541e+07 232 6.31473e+06 14013.5 1.88908e+07 14038.2 1.05021e+07 15575 1.46964e+07 1429.5 1.25993e+07 7214.04 1.67936e+07 6968.4 6.30784e+06 5796.77 1.67936e+07 5482.18 1.67936e+07 3997.21 1.67936e+07 83400.4 45208.2 844021 1.18032e+06 8.15491e+06 3.079e+07 17117.4 2369 403 45634.9 49763.9 53593.9 4364.3 17149.3 19160.8 17062.5 15007.2 9901.93 28128.3 2.51822e+07
79268 20231208.2 0.785068 5622.4 8.59996e+07 6 86496 436 1.2541e+07 232 6.31473e+06 14132.8 1.67936e+07 14180.7 1.05021e+07 15657.7 1.46964e+07 1434 1.25993e+07 6845.5 1.67936e+07 6976.9 6.30784e+06 5785.97 1.67936e+07 5729.53 1.67936e+07 3991.09 1.67936e+07 88746.9 44756.5 834932 1.18108e+06 8.15261e+06 3.08053e+07 17335.8 2275 403 45512 48794.1 53682.9 4409.2 17151.7 19765.2 17409.1 14956.2 9763.8 28108.2 2.51822e+07

allow_explicit_port_in_snp_endorsements

build_id build_number Commit latency factor tpcc_sgx_cft^ tpcc_sgx_cft_mem pi_basic_mt_virtual_cft^ pi_basic_mt_sgx_cft^ pi_basic_mt_sgx_cft_mem ls_sgx_cft^ ls_sgx_cft_mem pi_ls_sgx_cft^ pi_ls_sgx_cft_mem pi_basic_sgx_cft^ pi_basic_sgx_cft_mem tpcc_virtual_cft^ pi_basic_js_sgx_cft^ pi_basic_js_sgx_cft_mem ls_virtual_cft^ ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_ls_virtual_cft^ pi_basic_virtual_cft^ pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem pi_basic_js_virtual_cft^ ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_virtual_cft^ ls_full_js_virtual_cft^ ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem ls_js_jwt_virtual_cft^ tlc_3node_fixed_duration_s tlc_3node_fixed_states tlc_atomic_reconfig_duration_s tlc_atomic_reconfig_states tlc_reconfig_duration_s tlc_reconfig_states hist_sgx_cft^ RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^ tlc_sim_traces tlc_sim_levelmean
79245 20231207.8 0.789874 5616 8.59996e+07 86166.5 27952.4 2.51822e+07 14064.7 1.88908e+07 14146.9 1.05021e+07 15599.4 1.46964e+07 17318.8 1424.3 1.05021e+07 45712 7249.6 1.67936e+07 48795.7 54625.3 7050.7 6.30784e+06 4431.9 5807.72 1.67936e+07 17318.5 19839.7 5479.06 1.88908e+07 17501.3 14861.4 3997.56 1.67936e+07 10063.3 6 86496 429 1.2541e+07 243 6.31473e+06 45620.2 832517 1.17288e+06 8.12312e+06 3.1163e+07 2305 403
79277 20231208.5 0.816182 5536.39 8.59996e+07 60784.9 28111.3 2.51822e+07 14010.3 1.67936e+07 14094.5 1.05021e+07 15413.9 1.25993e+07 17293.6 1428.2 1.05021e+07 45562.8 6760.53 1.67936e+07 48466.8 54081.2 6930.2 6.30784e+06 4413.8 5795 1.67936e+07 17008.8 19237.4 5719.9 1.88908e+07 17221.1 14676.2 3972.99 1.67936e+07 10190.3 6 86496 430 1.2541e+07 232 6.31473e+06 40520.7 836617 1.1701e+06 8.15141e+06 3.06435e+07 2234 403

images

@achamayou achamayou merged commit 5c11f47 into microsoft:main Dec 8, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant