Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct state digest key for classic version of the API #5833

Closed

Conversation

achamayou
Copy link
Member

Closes #5816.

@achamayou achamayou requested a review from a team November 13, 2023 16:31
@ghost
Copy link

ghost commented Nov 13, 2023

correct_state_digest_key_in_old_api@78708 aka 20231113.13 vs main ewma over 20 builds from 78358 to 78691

Click to see table

main

build_id build_number Commit latency factor tpcc_sgx_cft^ tpcc_sgx_cft_mem pi_basic_mt_sgx_cft^ pi_basic_mt_sgx_cft_mem tpcc_virtual_cft^ ls_sgx_cft^ ls_sgx_cft_mem pi_ls_sgx_cft^ pi_ls_sgx_cft_mem pi_basic_sgx_cft^ pi_basic_sgx_cft_mem ls_virtual_cft^ pi_ls_virtual_cft^ pi_basic_virtual_cft^ pi_basic_js_virtual_cft^ ls_jwt_virtual_cft^ pi_basic_js_sgx_cft^ pi_basic_js_sgx_cft_mem pi_ls_jwt_virtual_cft^ pi_basic_mt_virtual_cft^ ls_js_virtual_cft^ ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_full_js_virtual_cft^ ls_js_jwt_virtual_cft^ ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem hist_sgx_cft^ RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^ tlc_3node_fixed_duration_s tlc_3node_fixed_states tlc_atomic_reconfig_duration_s tlc_atomic_reconfig_states tlc_reconfig_duration_s tlc_reconfig_states tlc_sim_traces tlc_sim_levelmean
78358 20231103.3 0.80868 5613.85 8.59996e+07 27874.4 2.51822e+07 17311.7 14024 1.88908e+07 14173.7 1.05021e+07 15658 1.46964e+07 43799.2 48061.9 53988.3 4395.8 17328 1431 1.25993e+07 19780 73888.9 17379.4 6848.6 1.88908e+07 6936 6.30784e+06 14648.9 10273.9 5795.98 1.67936e+07 5450.88 1.67936e+07 3999.15 1.67936e+07 45285.7 829705 1.18299e+06 8.14787e+06 3.0569e+07 nan nan nan nan nan nan nan nan
78365 20231103.6 0.787105 5629.97 8.59996e+07 28034 2.30851e+07 17440.6 14078.6 1.88908e+07 14064.8 1.05021e+07 15659.9 1.25993e+07 45729.3 48139.6 54762.3 4342.9 17317.7 1424 1.25993e+07 19576 72764.7 15085.7 6812 1.67936e+07 6988 6.30784e+06 14683.7 9954.18 5761.67 1.67936e+07 5755.45 1.67936e+07 3977.18 1.67936e+07 43491.4 829913 1.18447e+06 8.14194e+06 3.07286e+07 nan nan nan nan nan nan nan nan
78372 20231103.8 0.811727 5578.73 8.59996e+07 27795.9 2.30851e+07 17281.7 13977.9 1.88908e+07 14087 1.05021e+07 15549.8 1.25993e+07 45628 48368.5 53990.3 4355.3 17137.4 1424.7 1.25993e+07 19422.4 90924.9 14922.2 6788.55 1.88908e+07 6925.3 6.30784e+06 14674.6 10171.6 5793.13 1.67936e+07 5490.55 1.88908e+07 3975.67 1.67936e+07 44113 838885 1.18174e+06 8.15439e+06 3.16504e+07 nan nan nan nan nan nan nan nan
78384 20231103.12 0.802159 5517.44 8.59996e+07 27988.7 2.30851e+07 17108.5 13977 1.88908e+07 14136.3 1.05021e+07 15467.4 1.46964e+07 43878.6 47871.9 52246 4407.6 17039.1 1436.3 1.05021e+07 19823.6 74382.9 17407.9 6845.18 1.88908e+07 6873 6.30784e+06 14732.2 10283.4 5794.5 1.67936e+07 5481.25 1.67936e+07 3986.29 1.67936e+07 45856.3 827005 1.1842e+06 8.15429e+06 3.09913e+07 nan nan nan nan nan nan nan nan
78407 20231103.18 0.797156 5591.14 8.59996e+07 28323.1 2.30851e+07 17161.2 13982.6 1.88908e+07 14162.3 1.05021e+07 15482.2 1.25993e+07 43521.6 46519.9 53186.1 4343 16972 1429.7 1.25993e+07 19625.2 59381.6 14970 6854.13 1.67936e+07 7087.8 6.30784e+06 14529.4 10096.1 5753.69 1.67936e+07 5469.17 1.67936e+07 3986.36 1.67936e+07 40541.7 829355 1.18365e+06 8.17382e+06 3.16191e+07 nan nan nan nan nan nan nan nan
78430 20231106.1 0.785044 5655.91 8.59996e+07 27904 2.30851e+07 17142.7 14049.4 1.88908e+07 14103.2 1.05021e+07 15592 1.46964e+07 45699 47880.3 54141.9 4390.8 17165.6 1438.6 1.05021e+07 19773.4 75314.2 15067.1 6904.68 1.88908e+07 7080.2 6.30784e+06 14805.8 10259.9 5768.13 1.67936e+07 5444.99 1.67936e+07 4003.81 1.67936e+07 45223.5 830876 1.1802e+06 8.13838e+06 3.08745e+07 nan nan nan nan nan nan nan nan
78447 20231107.4 0.803997 5657.58 8.59996e+07 27883.9 2.30851e+07 17233.7 14082.8 1.67936e+07 14226.4 1.05021e+07 15619.5 1.46964e+07 43850.9 46545.8 53892.3 4342.9 16914.1 1439.7 1.25993e+07 19725.8 63226 17400.6 7269.63 1.67936e+07 7062.6 6.30784e+06 14863.8 10109.8 5804.83 1.67936e+07 5742.73 1.67936e+07 3981.14 1.67936e+07 43312.1 834561 1.18331e+06 8.16776e+06 3.07268e+07 nan nan nan nan nan nan nan nan
78486 20231107.16 0.801874 5617.84 8.59996e+07 27770.8 2.51822e+07 17279.4 14085.9 1.88908e+07 14206.9 1.05021e+07 15610.5 1.46964e+07 43772.2 47733.8 54072.7 4379 16987.8 1438 1.25993e+07 19100.7 87344 15027.3 6857.21 1.88908e+07 6977.6 6.30784e+06 14993.4 10303.6 5803.25 1.67936e+07 5736.63 1.67936e+07 3971.58 1.67936e+07 44144 838496 1.18042e+06 8.15371e+06 2.9949e+07 131 1.97092e+06 nan nan nan nan nan nan
78494 20231108.1 0.78468 5532.27 8.59996e+07 27924.2 2.51822e+07 17313.3 13978.1 1.67936e+07 14115.2 1.05021e+07 15527.7 1.25993e+07 45642.2 47648.1 54269.5 4387.4 17062.1 1433.1 1.25993e+07 19037.5 80711.6 15166.2 6857.9 1.88908e+07 6971.4 6.30784e+06 15030.2 10352.8 5796.65 1.67936e+07 5489.21 1.67936e+07 3996.02 1.67936e+07 41476.9 804898 1.17648e+06 8.09413e+06 3.07706e+07 124 1.97092e+06 nan nan nan nan nan nan
78534 20231108.16 0.814001 5508.65 8.59996e+07 27940.7 2.51822e+07 17305.2 14045.8 1.67936e+07 14093.1 1.05021e+07 15472.9 1.46964e+07 43733.1 47228.6 53728.9 4372.2 17222.8 1417.5 1.25993e+07 19593.2 71362 14958.9 6760.42 1.67936e+07 7034.2 6.30784e+06 14561.2 10207.8 5797.13 1.67936e+07 5482.75 1.67936e+07 3994.88 1.67936e+07 43059 834726 1.17855e+06 8.17421e+06 3.284e+07 127 1.97092e+06 412 1.17179e+07 229 5.94846e+06 nan nan
78546 20231108.20 0.803831 5562.49 8.59996e+07 27842.3 2.30851e+07 17193.3 13953.9 1.88908e+07 13971.1 1.05021e+07 15327 1.46964e+07 45583.3 47085.4 53757.4 4369.1 17214.2 1401.6 1.25993e+07 19185.4 70955 17445.6 6825.09 1.88908e+07 6884.7 6.30784e+06 14796.9 10162.5 5756.81 1.67936e+07 5462.49 1.67936e+07 3947.94 1.67936e+07 43053.4 834314 1.17795e+06 8.1518e+06 3.07434e+07 132 1.97092e+06 423 1.17179e+07 222 5.94846e+06 nan nan
78558 20231108.24 0.791062 5555.81 8.59996e+07 27852.3 2.30851e+07 17037.4 14017.9 1.88908e+07 14164.4 1.05021e+07 15546.1 1.46964e+07 43865.1 47170 52802.9 4353.3 17050 1433.9 1.25993e+07 18865.8 87493 17186.9 6787.99 1.67936e+07 6940.2 6.30784e+06 14777.5 10241.2 5809.33 1.67936e+07 5447.34 1.67936e+07 3968.11 1.67936e+07 41786.3 834125 1.18208e+06 8.1247e+06 3.0595e+07 120 1.97092e+06 398 1.17179e+07 224 5.94846e+06 nan nan
78568 20231109.3 0.799269 5598.12 8.59996e+07 27939.1 2.51822e+07 17264.6 14087.6 1.88908e+07 14194.3 1.05021e+07 15680 1.46964e+07 43783.2 47435.4 53481.3 4385.9 17091 1434.2 1.25993e+07 19520.6 87721.9 14848.6 7226.55 1.67936e+07 7100.8 6.30784e+06 14708.1 10132.6 5793.83 1.67936e+07 5483.14 1.67936e+07 3971.48 1.67936e+07 44947.9 834758 1.18204e+06 8.14421e+06 3.08257e+07 139 1.97092e+06 428 1.17179e+07 238 5.94846e+06 nan nan
78597 20231110.2 0.820217 5574.8 8.59996e+07 28119.2 2.51822e+07 17438.9 14024.1 1.88908e+07 14119.9 1.05021e+07 15507.8 1.46964e+07 45782.2 48199 54129.5 4406.4 17319.5 1421.1 1.25993e+07 19699.8 89644 14922.9 7248.55 1.67936e+07 7079.1 6.30784e+06 14864.4 10196.3 5793.81 1.67936e+07 5494.3 1.67936e+07 3999.09 1.67936e+07 45165.9 835013 1.18481e+06 8.14223e+06 3.07975e+07 124 1.97092e+06 410 1.17179e+07 227 5.94846e+06 nan nan
78603 20231110.5 0.800484 5580.74 8.59996e+07 28155.1 2.30851e+07 17135.5 14024.5 1.88908e+07 14134.4 1.05021e+07 15453.5 1.46964e+07 43772.8 47530.3 54447 4438.1 17217.2 1435.7 1.25993e+07 19690.9 73387.6 17424.3 7234.68 1.67936e+07 6947 6.30784e+06 15192.4 10204.5 5801.75 1.67936e+07 5489.21 1.67936e+07 4002.28 1.67936e+07 38563.2 834638 1.17761e+06 8.0415e+06 3.07975e+07 122 1.97092e+06 414 1.17179e+07 227 5.94846e+06 nan nan
78616 20231110.10 0.803176 5620.57 8.59996e+07 27789.4 2.51822e+07 17222.8 14024.6 1.88908e+07 14178.4 1.05021e+07 15586.9 1.25993e+07 43599.4 47949.9 53841.8 4400.4 17024.2 1421.1 1.25993e+07 19096.7 80935.3 15032.3 6883.97 1.88908e+07 7094.6 6.30784e+06 14891.5 10161.5 5767.02 1.67936e+07 5739.27 1.67936e+07 3985.71 1.67936e+07 43058 835116 1.18152e+06 8.15241e+06 3.07646e+07 124 1.97092e+06 411 1.17179e+07 227 5.94846e+06 nan nan
78639 20231110.19 0.781922 5627.55 8.59996e+07 27614.7 2.30851e+07 17359.9 14013.2 1.88908e+07 14116.4 1.05021e+07 15570.1 1.46964e+07 45728.6 48073.9 54500.8 4431.6 17027.1 1433.9 1.25993e+07 19186.5 69445.7 17302.6 6786.6 1.88908e+07 7029.2 6.30784e+06 14918.9 10196.6 5799.06 1.67936e+07 5444.62 1.67936e+07 3992.6 1.67936e+07 43277.5 825457 1.18272e+06 8.08601e+06 3.06931e+07 113 1.97092e+06 378 1.15766e+07 210 5.93588e+06 nan nan
78665 20231110.28 0.829089 5521.39 8.59996e+07 27942.5 2.30851e+07 17261.7 13953.4 1.67936e+07 14022.3 1.05021e+07 15426.4 1.46964e+07 43577 47253.6 53692.9 4381.6 17122.1 1419.1 1.25993e+07 19584.8 78278.4 17455.2 6850.16 1.88908e+07 6826.1 6.30784e+06 14674.7 10149.5 5759.17 1.67936e+07 5468.42 1.67936e+07 3980.3 1.67936e+07 34232.3 834429 1.18129e+06 8.12782e+06 2.99599e+07 116 1.97092e+06 366 1.15766e+07 217 5.93588e+06 2416 403
78675 20231113.1 0.772318 5608.64 8.59996e+07 28037.5 2.30851e+07 17202.4 14062 1.88908e+07 14142.3 1.05021e+07 15671.4 1.46964e+07 43696.7 47707.9 54236.9 4382.9 17139.4 1433.4 1.05021e+07 19492.8 85964 17411.1 7255.39 1.67936e+07 7047.1 6.30784e+06 14847.1 10307.4 5802 1.67936e+07 5740.22 1.67936e+07 4009.3 1.67936e+07 40992.2 836904 1.1866e+06 8.15861e+06 3.08281e+07 115 1.97092e+06 380 1.15766e+07 212 5.93588e+06 2538 403
78691 20231113.9 0.791184 5691.43 8.59996e+07 27756.8 2.30851e+07 17369 14078.8 1.67936e+07 14181.9 1.05021e+07 15617.9 1.25993e+07 43715 47183.2 50236.1 4411.9 16973.5 1436.5 1.25993e+07 19099.3 71746.7 17221 6928.05 1.88908e+07 6981.4 6.30784e+06 14850.3 10152.1 5791.47 1.67936e+07 5496.97 1.67936e+07 3962.59 1.67936e+07 42889.5 826371 1.18244e+06 8.15452e+06 3.08192e+07 112 1.97092e+06 376 1.15766e+07 201 5.93588e+06 2455 403

correct_state_digest_key_in_old_api

build_id build_number Commit latency factor tpcc_sgx_cft^ tpcc_sgx_cft_mem pi_basic_mt_sgx_cft^ pi_basic_mt_sgx_cft_mem ls_sgx_cft^ ls_sgx_cft_mem pi_ls_sgx_cft^ pi_ls_sgx_cft_mem pi_basic_sgx_cft^ pi_basic_sgx_cft_mem pi_basic_js_sgx_cft^ pi_basic_js_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem tlc_3node_fixed_duration_s tlc_3node_fixed_states tlc_atomic_reconfig_duration_s tlc_atomic_reconfig_states tlc_reconfig_duration_s tlc_reconfig_states hist_sgx_cft^ RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^ tpcc_virtual_cft^ pi_basic_mt_virtual_cft^ ls_virtual_cft^ pi_ls_virtual_cft^ pi_basic_virtual_cft^ pi_basic_js_virtual_cft^ ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ ls_js_virtual_cft^ ls_full_js_virtual_cft^ ls_js_jwt_virtual_cft^ tlc_sim_traces tlc_sim_levelmean
78705 20231113.12 0.783458 5590.55 8.59996e+07 28031 2.30851e+07 14002.4 1.88908e+07 14157 1.05021e+07 15610.5 1.25993e+07 1433.4 1.25993e+07 6857.64 1.88908e+07 6919.1 6.30784e+06 5769.35 1.67936e+07 5456.32 1.67936e+07 3999.43 1.67936e+07 122 1.97092e+06 389 1.15766e+07 218 5.93588e+06 43182.6 799262 1.16132e+06 8.14259e+06 2.75106e+07 17235.3 90012.1 45620.4 47622.2 53606.5 4255.5 16971.7 19375.7 17265 14886.7 10328.1 2347 403
78708 20231113.13 0.781101 5554.83 8.59996e+07 28084.4 2.30851e+07 14034 1.88908e+07 14114.6 1.05021e+07 15597.2 1.46964e+07 1436.2 1.25993e+07 6874.45 1.88908e+07 6345.7 6.30784e+06 5801.25 1.67936e+07 5488.05 1.88908e+07 3999.32 1.67936e+07 118 1.97092e+06 373 1.15766e+07 219 5.93588e+06 39113.3 832601 1.18081e+06 8.15047e+06 3.01491e+07 17357.7 86838.8 45864.9 47589.6 53130.8 4384.1 17254.4 18984.3 17442.7 14874.2 10132.9 2524 403

images

src/node/gov/handlers/acks.h Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Acks submitted with old tooling don't work because they send "state_digest" rather than "stateDigest"
2 participants