Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NotifyCommit to bring spec closer to implementation #5826

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

achamayou
Copy link
Member

Closes #5280

@ghost
Copy link

ghost commented Nov 10, 2023

remove_notify_commit@78624 aka 20231110.12 vs main ewma over 20 builds from 78261 to 78616

Click to see table

main

build_id build_number Commit latency factor tpcc_virtual_cft^ ls_virtual_cft^ pi_ls_virtual_cft^ pi_basic_mt_sgx_cft^ pi_basic_mt_sgx_cft_mem pi_basic_virtual_cft^ pi_basic_js_virtual_cft^ ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ pi_basic_mt_virtual_cft^ tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_js_virtual_cft^ ls_full_js_virtual_cft^ ls_js_jwt_virtual_cft^ ls_sgx_cft^ ls_sgx_cft_mem pi_ls_sgx_cft^ pi_ls_sgx_cft_mem pi_basic_sgx_cft^ pi_basic_sgx_cft_mem hist_sgx_cft^ pi_basic_js_sgx_cft^ pi_basic_js_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^ tlc_3node_fixed_duration_s tlc_3node_fixed_states tlc_atomic_reconfig_duration_s tlc_atomic_reconfig_states tlc_reconfig_duration_s tlc_reconfig_states
78261 20231101.25 0.81842 17440.2 45894.6 47638.6 28224.5 2.51822e+07 53299.1 4380.3 17042 19569.5 69365.6 5612.19 8.59996e+07 17247.3 14729.7 10279.9 14117.8 1.88908e+07 14186 1.05021e+07 15647.1 1.25993e+07 43354.3 1436.8 1.25993e+07 7264.49 1.67936e+07 7000.4 6.30784e+06 5797.39 1.67936e+07 5486.18 1.67936e+07 3994.48 1.67936e+07 835866 1.1715e+06 8.14353e+06 3.07998e+07 nan nan nan nan nan nan
78284 20231102.4 0.775601 17090 43810.2 47171.4 27902.1 2.30851e+07 53039.6 4380.6 16902.4 19632.5 74128.5 5607 8.59996e+07 14945.6 14982 10242.7 14039.4 1.88908e+07 14144.7 1.05021e+07 15534.3 1.46964e+07 40950.5 1433.6 1.25993e+07 6870.67 1.88908e+07 7007.8 6.30784e+06 5753.55 1.67936e+07 5431.34 1.67936e+07 3982.9 1.67936e+07 830357 1.18333e+06 8.13473e+06 3.08373e+07 nan nan nan nan nan nan
78305 20231102.12 0.78799 17322.6 45645.4 48989.3 27661.5 2.30851e+07 53847.3 4386.2 17291.3 19701.3 88216.8 5520.15 8.59996e+07 17082.4 14871.8 10051.9 14034 1.88908e+07 14105 1.05021e+07 15532.4 1.25993e+07 40964.4 1421.1 1.25993e+07 6844.95 1.88908e+07 7082.4 6.30784e+06 5797.56 1.67936e+07 5725.47 1.88908e+07 4001.42 1.67936e+07 822024 1.17786e+06 8.15592e+06 3.10807e+07 nan nan nan nan nan nan
78319 20231102.17 0.793434 17142.8 45692.3 48014.1 27989.4 2.30851e+07 53896.9 4359.7 17057.3 19245.9 83397.2 5616.9 8.59996e+07 17127.5 14800.7 10296.3 13956 1.88908e+07 14087.7 1.05021e+07 15500.2 1.46964e+07 45008.6 1432 1.25993e+07 6839.82 1.67936e+07 6924.1 6.30784e+06 5801.1 1.67936e+07 5739.65 1.67936e+07 3972.71 1.67936e+07 834976 1.18569e+06 8.12273e+06 3.07789e+07 nan nan nan nan nan nan
78358 20231103.3 0.80868 17311.7 43799.2 48061.9 27874.4 2.51822e+07 53988.3 4395.8 17328 19780 73888.9 5613.85 8.59996e+07 17379.4 14648.9 10273.9 14024 1.88908e+07 14173.7 1.05021e+07 15658 1.46964e+07 45285.7 1431 1.25993e+07 6848.6 1.88908e+07 6936 6.30784e+06 5795.98 1.67936e+07 5450.88 1.67936e+07 3999.15 1.67936e+07 829705 1.18299e+06 8.14787e+06 3.0569e+07 nan nan nan nan nan nan
78365 20231103.6 0.787105 17440.6 45729.3 48139.6 28034 2.30851e+07 54762.3 4342.9 17317.7 19576 72764.7 5629.97 8.59996e+07 15085.7 14683.7 9954.18 14078.6 1.88908e+07 14064.8 1.05021e+07 15659.9 1.25993e+07 43491.4 1424 1.25993e+07 6812 1.67936e+07 6988 6.30784e+06 5761.67 1.67936e+07 5755.45 1.67936e+07 3977.18 1.67936e+07 829913 1.18447e+06 8.14194e+06 3.07286e+07 nan nan nan nan nan nan
78372 20231103.8 0.811727 17281.7 45628 48368.5 27795.9 2.30851e+07 53990.3 4355.3 17137.4 19422.4 90924.9 5578.73 8.59996e+07 14922.2 14674.6 10171.6 13977.9 1.88908e+07 14087 1.05021e+07 15549.8 1.25993e+07 44113 1424.7 1.25993e+07 6788.55 1.88908e+07 6925.3 6.30784e+06 5793.13 1.67936e+07 5490.55 1.88908e+07 3975.67 1.67936e+07 838885 1.18174e+06 8.15439e+06 3.16504e+07 nan nan nan nan nan nan
78384 20231103.12 0.802159 17108.5 43878.6 47871.9 27988.7 2.30851e+07 52246 4407.6 17039.1 19823.6 74382.9 5517.44 8.59996e+07 17407.9 14732.2 10283.4 13977 1.88908e+07 14136.3 1.05021e+07 15467.4 1.46964e+07 45856.3 1436.3 1.05021e+07 6845.18 1.88908e+07 6873 6.30784e+06 5794.5 1.67936e+07 5481.25 1.67936e+07 3986.29 1.67936e+07 827005 1.1842e+06 8.15429e+06 3.09913e+07 nan nan nan nan nan nan
78407 20231103.18 0.797156 17161.2 43521.6 46519.9 28323.1 2.30851e+07 53186.1 4343 16972 19625.2 59381.6 5591.14 8.59996e+07 14970 14529.4 10096.1 13982.6 1.88908e+07 14162.3 1.05021e+07 15482.2 1.25993e+07 40541.7 1429.7 1.25993e+07 6854.13 1.67936e+07 7087.8 6.30784e+06 5753.69 1.67936e+07 5469.17 1.67936e+07 3986.36 1.67936e+07 829355 1.18365e+06 8.17382e+06 3.16191e+07 nan nan nan nan nan nan
78430 20231106.1 0.785044 17142.7 45699 47880.3 27904 2.30851e+07 54141.9 4390.8 17165.6 19773.4 75314.2 5655.91 8.59996e+07 15067.1 14805.8 10259.9 14049.4 1.88908e+07 14103.2 1.05021e+07 15592 1.46964e+07 45223.5 1438.6 1.05021e+07 6904.68 1.88908e+07 7080.2 6.30784e+06 5768.13 1.67936e+07 5444.99 1.67936e+07 4003.81 1.67936e+07 830876 1.1802e+06 8.13838e+06 3.08745e+07 nan nan nan nan nan nan
78447 20231107.4 0.803997 17233.7 43850.9 46545.8 27883.9 2.30851e+07 53892.3 4342.9 16914.1 19725.8 63226 5657.58 8.59996e+07 17400.6 14863.8 10109.8 14082.8 1.67936e+07 14226.4 1.05021e+07 15619.5 1.46964e+07 43312.1 1439.7 1.25993e+07 7269.63 1.67936e+07 7062.6 6.30784e+06 5804.83 1.67936e+07 5742.73 1.67936e+07 3981.14 1.67936e+07 834561 1.18331e+06 8.16776e+06 3.07268e+07 nan nan nan nan nan nan
78486 20231107.16 0.801874 17279.4 43772.2 47733.8 27770.8 2.51822e+07 54072.7 4379 16987.8 19100.7 87344 5617.84 8.59996e+07 15027.3 14993.4 10303.6 14085.9 1.88908e+07 14206.9 1.05021e+07 15610.5 1.46964e+07 44144 1438 1.25993e+07 6857.21 1.88908e+07 6977.6 6.30784e+06 5803.25 1.67936e+07 5736.63 1.67936e+07 3971.58 1.67936e+07 838496 1.18042e+06 8.15371e+06 2.9949e+07 131 1.97092e+06 nan nan nan nan
78494 20231108.1 0.78468 17313.3 45642.2 47648.1 27924.2 2.51822e+07 54269.5 4387.4 17062.1 19037.5 80711.6 5532.27 8.59996e+07 15166.2 15030.2 10352.8 13978.1 1.67936e+07 14115.2 1.05021e+07 15527.7 1.25993e+07 41476.9 1433.1 1.25993e+07 6857.9 1.88908e+07 6971.4 6.30784e+06 5796.65 1.67936e+07 5489.21 1.67936e+07 3996.02 1.67936e+07 804898 1.17648e+06 8.09413e+06 3.07706e+07 124 1.97092e+06 nan nan nan nan
78534 20231108.16 0.814001 17305.2 43733.1 47228.6 27940.7 2.51822e+07 53728.9 4372.2 17222.8 19593.2 71362 5508.65 8.59996e+07 14958.9 14561.2 10207.8 14045.8 1.67936e+07 14093.1 1.05021e+07 15472.9 1.46964e+07 43059 1417.5 1.25993e+07 6760.42 1.67936e+07 7034.2 6.30784e+06 5797.13 1.67936e+07 5482.75 1.67936e+07 3994.88 1.67936e+07 834726 1.17855e+06 8.17421e+06 3.284e+07 127 1.97092e+06 412 1.17179e+07 229 5.94846e+06
78546 20231108.20 0.803831 17193.3 45583.3 47085.4 27842.3 2.30851e+07 53757.4 4369.1 17214.2 19185.4 70955 5562.49 8.59996e+07 17445.6 14796.9 10162.5 13953.9 1.88908e+07 13971.1 1.05021e+07 15327 1.46964e+07 43053.4 1401.6 1.25993e+07 6825.09 1.88908e+07 6884.7 6.30784e+06 5756.81 1.67936e+07 5462.49 1.67936e+07 3947.94 1.67936e+07 834314 1.17795e+06 8.1518e+06 3.07434e+07 132 1.97092e+06 423 1.17179e+07 222 5.94846e+06
78558 20231108.24 0.791062 17037.4 43865.1 47170 27852.3 2.30851e+07 52802.9 4353.3 17050 18865.8 87493 5555.81 8.59996e+07 17186.9 14777.5 10241.2 14017.9 1.88908e+07 14164.4 1.05021e+07 15546.1 1.46964e+07 41786.3 1433.9 1.25993e+07 6787.99 1.67936e+07 6940.2 6.30784e+06 5809.33 1.67936e+07 5447.34 1.67936e+07 3968.11 1.67936e+07 834125 1.18208e+06 8.1247e+06 3.0595e+07 120 1.97092e+06 398 1.17179e+07 224 5.94846e+06
78568 20231109.3 0.799269 17264.6 43783.2 47435.4 27939.1 2.51822e+07 53481.3 4385.9 17091 19520.6 87721.9 5598.12 8.59996e+07 14848.6 14708.1 10132.6 14087.6 1.88908e+07 14194.3 1.05021e+07 15680 1.46964e+07 44947.9 1434.2 1.25993e+07 7226.55 1.67936e+07 7100.8 6.30784e+06 5793.83 1.67936e+07 5483.14 1.67936e+07 3971.48 1.67936e+07 834758 1.18204e+06 8.14421e+06 3.08257e+07 139 1.97092e+06 428 1.17179e+07 238 5.94846e+06
78597 20231110.2 0.820217 17438.9 45782.2 48199 28119.2 2.51822e+07 54129.5 4406.4 17319.5 19699.8 89644 5574.8 8.59996e+07 14922.9 14864.4 10196.3 14024.1 1.88908e+07 14119.9 1.05021e+07 15507.8 1.46964e+07 45165.9 1421.1 1.25993e+07 7248.55 1.67936e+07 7079.1 6.30784e+06 5793.81 1.67936e+07 5494.3 1.67936e+07 3999.09 1.67936e+07 835013 1.18481e+06 8.14223e+06 3.07975e+07 124 1.97092e+06 410 1.17179e+07 227 5.94846e+06
78603 20231110.5 0.800484 17135.5 43772.8 47530.3 28155.1 2.30851e+07 54447 4438.1 17217.2 19690.9 73387.6 5580.74 8.59996e+07 17424.3 15192.4 10204.5 14024.5 1.88908e+07 14134.4 1.05021e+07 15453.5 1.46964e+07 38563.2 1435.7 1.25993e+07 7234.68 1.67936e+07 6947 6.30784e+06 5801.75 1.67936e+07 5489.21 1.67936e+07 4002.28 1.67936e+07 834638 1.17761e+06 8.0415e+06 3.07975e+07 122 1.97092e+06 414 1.17179e+07 227 5.94846e+06
78616 20231110.10 0.803176 17222.8 43599.4 47949.9 27789.4 2.51822e+07 53841.8 4400.4 17024.2 19096.7 80935.3 5620.57 8.59996e+07 15032.3 14891.5 10161.5 14024.6 1.88908e+07 14178.4 1.05021e+07 15586.9 1.25993e+07 43058 1421.1 1.25993e+07 6883.97 1.88908e+07 7094.6 6.30784e+06 5767.02 1.67936e+07 5739.27 1.67936e+07 3985.71 1.67936e+07 835116 1.18152e+06 8.15241e+06 3.07646e+07 124 1.97092e+06 411 1.17179e+07 227 5.94846e+06

remove_notify_commit

build_id build_number pi_basic_mt_sgx_cft^ pi_basic_mt_sgx_cft_mem Commit latency factor pi_basic_mt_virtual_cft^ tpcc_virtual_cft^ ls_virtual_cft^ pi_ls_virtual_cft^ tpcc_sgx_cft^ tpcc_sgx_cft_mem pi_basic_virtual_cft^ pi_basic_js_virtual_cft^ ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ ls_js_virtual_cft^ ls_sgx_cft^ ls_sgx_cft_mem ls_full_js_virtual_cft^ pi_ls_sgx_cft^ pi_ls_sgx_cft_mem pi_basic_sgx_cft^ pi_basic_sgx_cft_mem ls_js_jwt_virtual_cft^ pi_basic_js_sgx_cft^ pi_basic_js_sgx_cft_mem hist_sgx_cft^ ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem tlc_3node_fixed_duration_s tlc_3node_fixed_states tlc_atomic_reconfig_duration_s tlc_atomic_reconfig_states tlc_reconfig_duration_s tlc_reconfig_states RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
78624 20231110.12 27841.5 2.30851e+07 0.812788 82615.3 17082 41852.9 47223.7 5629.33 8.59996e+07 53098 4351.6 16937.8 19266 17379.4 14059.4 1.67936e+07 14634 14114.1 1.05021e+07 15602.6 1.25993e+07 10118.5 1432.6 1.25993e+07 41554.2 7248.28 1.67936e+07 7051.1 6.30784e+06 5793.7 1.67936e+07 5477.7 1.67936e+07 3994.25 1.67936e+07 117 1.97092e+06 369 1.15766e+07 208 5.93588e+06 828060 1.18181e+06 8.14007e+06 3.08304e+07

images

@achamayou achamayou marked this pull request as ready for review November 10, 2023 11:49
@achamayou achamayou requested review from a team and heidihoward November 10, 2023 11:49
@achamayou achamayou added the tla TLA+ specifications label Nov 10, 2023
@achamayou achamayou merged commit 56ee39e into microsoft:main Nov 10, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tla TLA+ specifications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check if NotifyCommit messages in TLA+ are safe
2 participants