Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align leadership state naming with implementation #5823

Merged
merged 5 commits into from
Nov 10, 2023

Conversation

achamayou
Copy link
Member

@achamayou achamayou commented Nov 9, 2023

A small change, extracted from #5769, but useful for trace validation with the realistic startup.

@achamayou achamayou requested a review from a team November 9, 2023 11:41
@ghost
Copy link

ghost commented Nov 9, 2023

align_leadership_state_naming@78613 aka 20231110.8 vs main ewma over 20 builds from 78246 to 78603

Click to see table

main

build_id build_number Commit latency factor tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_sgx_cft^ ls_sgx_cft_mem tpcc_virtual_cft^ pi_ls_sgx_cft^ pi_ls_sgx_cft_mem pi_basic_mt_sgx_cft^ pi_basic_mt_sgx_cft_mem pi_basic_sgx_cft^ pi_basic_sgx_cft_mem ls_virtual_cft^ pi_ls_virtual_cft^ pi_basic_virtual_cft^ pi_basic_mt_virtual_cft^ pi_basic_js_virtual_cft^ pi_basic_js_sgx_cft^ pi_basic_js_sgx_cft_mem ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_js_virtual_cft^ pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_full_js_virtual_cft^ ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_js_jwt_virtual_cft^ ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem hist_sgx_cft^ RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^ tlc_3node_fixed_duration_s tlc_3node_fixed_states tlc_atomic_reconfig_duration_s tlc_atomic_reconfig_states tlc_reconfig_duration_s tlc_reconfig_states
78246 20231101.20 0.784451 5643.71 8.59996e+07 14099.1 1.88908e+07 17123.7 14165.3 1.05021e+07 27565 2.30851e+07 15684.7 1.46964e+07 45792.5 46974.8 53423.6 70500.2 4408.4 1423.7 1.25993e+07 17022.2 19427.7 7247.5 1.67936e+07 15054.6 6996.2 6.30784e+06 14945.9 5794.78 1.67936e+07 10275.3 5485.63 1.67936e+07 3992.72 1.67936e+07 45075.5 837584 1.17997e+06 8.17199e+06 3.10982e+07 nan nan nan nan nan nan
78261 20231101.25 0.81842 5612.19 8.59996e+07 14117.8 1.88908e+07 17440.2 14186 1.05021e+07 28224.5 2.51822e+07 15647.1 1.25993e+07 45894.6 47638.6 53299.1 69365.6 4380.3 1436.8 1.25993e+07 17042 19569.5 7264.49 1.67936e+07 17247.3 7000.4 6.30784e+06 14729.7 5797.39 1.67936e+07 10279.9 5486.18 1.67936e+07 3994.48 1.67936e+07 43354.3 835866 1.1715e+06 8.14353e+06 3.07998e+07 nan nan nan nan nan nan
78284 20231102.4 0.775601 5607 8.59996e+07 14039.4 1.88908e+07 17090 14144.7 1.05021e+07 27902.1 2.30851e+07 15534.3 1.46964e+07 43810.2 47171.4 53039.6 74128.5 4380.6 1433.6 1.25993e+07 16902.4 19632.5 6870.67 1.88908e+07 14945.6 7007.8 6.30784e+06 14982 5753.55 1.67936e+07 10242.7 5431.34 1.67936e+07 3982.9 1.67936e+07 40950.5 830357 1.18333e+06 8.13473e+06 3.08373e+07 nan nan nan nan nan nan
78305 20231102.12 0.78799 5520.15 8.59996e+07 14034 1.88908e+07 17322.6 14105 1.05021e+07 27661.5 2.30851e+07 15532.4 1.25993e+07 45645.4 48989.3 53847.3 88216.8 4386.2 1421.1 1.25993e+07 17291.3 19701.3 6844.95 1.88908e+07 17082.4 7082.4 6.30784e+06 14871.8 5797.56 1.67936e+07 10051.9 5725.47 1.88908e+07 4001.42 1.67936e+07 40964.4 822024 1.17786e+06 8.15592e+06 3.10807e+07 nan nan nan nan nan nan
78319 20231102.17 0.793434 5616.9 8.59996e+07 13956 1.88908e+07 17142.8 14087.7 1.05021e+07 27989.4 2.30851e+07 15500.2 1.46964e+07 45692.3 48014.1 53896.9 83397.2 4359.7 1432 1.25993e+07 17057.3 19245.9 6839.82 1.67936e+07 17127.5 6924.1 6.30784e+06 14800.7 5801.1 1.67936e+07 10296.3 5739.65 1.67936e+07 3972.71 1.67936e+07 45008.6 834976 1.18569e+06 8.12273e+06 3.07789e+07 nan nan nan nan nan nan
78358 20231103.3 0.80868 5613.85 8.59996e+07 14024 1.88908e+07 17311.7 14173.7 1.05021e+07 27874.4 2.51822e+07 15658 1.46964e+07 43799.2 48061.9 53988.3 73888.9 4395.8 1431 1.25993e+07 17328 19780 6848.6 1.88908e+07 17379.4 6936 6.30784e+06 14648.9 5795.98 1.67936e+07 10273.9 5450.88 1.67936e+07 3999.15 1.67936e+07 45285.7 829705 1.18299e+06 8.14787e+06 3.0569e+07 nan nan nan nan nan nan
78365 20231103.6 0.787105 5629.97 8.59996e+07 14078.6 1.88908e+07 17440.6 14064.8 1.05021e+07 28034 2.30851e+07 15659.9 1.25993e+07 45729.3 48139.6 54762.3 72764.7 4342.9 1424 1.25993e+07 17317.7 19576 6812 1.67936e+07 15085.7 6988 6.30784e+06 14683.7 5761.67 1.67936e+07 9954.18 5755.45 1.67936e+07 3977.18 1.67936e+07 43491.4 829913 1.18447e+06 8.14194e+06 3.07286e+07 nan nan nan nan nan nan
78372 20231103.8 0.811727 5578.73 8.59996e+07 13977.9 1.88908e+07 17281.7 14087 1.05021e+07 27795.9 2.30851e+07 15549.8 1.25993e+07 45628 48368.5 53990.3 90924.9 4355.3 1424.7 1.25993e+07 17137.4 19422.4 6788.55 1.88908e+07 14922.2 6925.3 6.30784e+06 14674.6 5793.13 1.67936e+07 10171.6 5490.55 1.88908e+07 3975.67 1.67936e+07 44113 838885 1.18174e+06 8.15439e+06 3.16504e+07 nan nan nan nan nan nan
78384 20231103.12 0.802159 5517.44 8.59996e+07 13977 1.88908e+07 17108.5 14136.3 1.05021e+07 27988.7 2.30851e+07 15467.4 1.46964e+07 43878.6 47871.9 52246 74382.9 4407.6 1436.3 1.05021e+07 17039.1 19823.6 6845.18 1.88908e+07 17407.9 6873 6.30784e+06 14732.2 5794.5 1.67936e+07 10283.4 5481.25 1.67936e+07 3986.29 1.67936e+07 45856.3 827005 1.1842e+06 8.15429e+06 3.09913e+07 nan nan nan nan nan nan
78407 20231103.18 0.797156 5591.14 8.59996e+07 13982.6 1.88908e+07 17161.2 14162.3 1.05021e+07 28323.1 2.30851e+07 15482.2 1.25993e+07 43521.6 46519.9 53186.1 59381.6 4343 1429.7 1.25993e+07 16972 19625.2 6854.13 1.67936e+07 14970 7087.8 6.30784e+06 14529.4 5753.69 1.67936e+07 10096.1 5469.17 1.67936e+07 3986.36 1.67936e+07 40541.7 829355 1.18365e+06 8.17382e+06 3.16191e+07 nan nan nan nan nan nan
78430 20231106.1 0.785044 5655.91 8.59996e+07 14049.4 1.88908e+07 17142.7 14103.2 1.05021e+07 27904 2.30851e+07 15592 1.46964e+07 45699 47880.3 54141.9 75314.2 4390.8 1438.6 1.05021e+07 17165.6 19773.4 6904.68 1.88908e+07 15067.1 7080.2 6.30784e+06 14805.8 5768.13 1.67936e+07 10259.9 5444.99 1.67936e+07 4003.81 1.67936e+07 45223.5 830876 1.1802e+06 8.13838e+06 3.08745e+07 nan nan nan nan nan nan
78447 20231107.4 0.803997 5657.58 8.59996e+07 14082.8 1.67936e+07 17233.7 14226.4 1.05021e+07 27883.9 2.30851e+07 15619.5 1.46964e+07 43850.9 46545.8 53892.3 63226 4342.9 1439.7 1.25993e+07 16914.1 19725.8 7269.63 1.67936e+07 17400.6 7062.6 6.30784e+06 14863.8 5804.83 1.67936e+07 10109.8 5742.73 1.67936e+07 3981.14 1.67936e+07 43312.1 834561 1.18331e+06 8.16776e+06 3.07268e+07 nan nan nan nan nan nan
78486 20231107.16 0.801874 5617.84 8.59996e+07 14085.9 1.88908e+07 17279.4 14206.9 1.05021e+07 27770.8 2.51822e+07 15610.5 1.46964e+07 43772.2 47733.8 54072.7 87344 4379 1438 1.25993e+07 16987.8 19100.7 6857.21 1.88908e+07 15027.3 6977.6 6.30784e+06 14993.4 5803.25 1.67936e+07 10303.6 5736.63 1.67936e+07 3971.58 1.67936e+07 44144 838496 1.18042e+06 8.15371e+06 2.9949e+07 131 1.97092e+06 nan nan nan nan
78494 20231108.1 0.78468 5532.27 8.59996e+07 13978.1 1.67936e+07 17313.3 14115.2 1.05021e+07 27924.2 2.51822e+07 15527.7 1.25993e+07 45642.2 47648.1 54269.5 80711.6 4387.4 1433.1 1.25993e+07 17062.1 19037.5 6857.9 1.88908e+07 15166.2 6971.4 6.30784e+06 15030.2 5796.65 1.67936e+07 10352.8 5489.21 1.67936e+07 3996.02 1.67936e+07 41476.9 804898 1.17648e+06 8.09413e+06 3.07706e+07 124 1.97092e+06 nan nan nan nan
78534 20231108.16 0.814001 5508.65 8.59996e+07 14045.8 1.67936e+07 17305.2 14093.1 1.05021e+07 27940.7 2.51822e+07 15472.9 1.46964e+07 43733.1 47228.6 53728.9 71362 4372.2 1417.5 1.25993e+07 17222.8 19593.2 6760.42 1.67936e+07 14958.9 7034.2 6.30784e+06 14561.2 5797.13 1.67936e+07 10207.8 5482.75 1.67936e+07 3994.88 1.67936e+07 43059 834726 1.17855e+06 8.17421e+06 3.284e+07 127 1.97092e+06 412 1.17179e+07 229 5.94846e+06
78546 20231108.20 0.803831 5562.49 8.59996e+07 13953.9 1.88908e+07 17193.3 13971.1 1.05021e+07 27842.3 2.30851e+07 15327 1.46964e+07 45583.3 47085.4 53757.4 70955 4369.1 1401.6 1.25993e+07 17214.2 19185.4 6825.09 1.88908e+07 17445.6 6884.7 6.30784e+06 14796.9 5756.81 1.67936e+07 10162.5 5462.49 1.67936e+07 3947.94 1.67936e+07 43053.4 834314 1.17795e+06 8.1518e+06 3.07434e+07 132 1.97092e+06 423 1.17179e+07 222 5.94846e+06
78558 20231108.24 0.791062 5555.81 8.59996e+07 14017.9 1.88908e+07 17037.4 14164.4 1.05021e+07 27852.3 2.30851e+07 15546.1 1.46964e+07 43865.1 47170 52802.9 87493 4353.3 1433.9 1.25993e+07 17050 18865.8 6787.99 1.67936e+07 17186.9 6940.2 6.30784e+06 14777.5 5809.33 1.67936e+07 10241.2 5447.34 1.67936e+07 3968.11 1.67936e+07 41786.3 834125 1.18208e+06 8.1247e+06 3.0595e+07 120 1.97092e+06 398 1.17179e+07 224 5.94846e+06
78568 20231109.3 0.799269 5598.12 8.59996e+07 14087.6 1.88908e+07 17264.6 14194.3 1.05021e+07 27939.1 2.51822e+07 15680 1.46964e+07 43783.2 47435.4 53481.3 87721.9 4385.9 1434.2 1.25993e+07 17091 19520.6 7226.55 1.67936e+07 14848.6 7100.8 6.30784e+06 14708.1 5793.83 1.67936e+07 10132.6 5483.14 1.67936e+07 3971.48 1.67936e+07 44947.9 834758 1.18204e+06 8.14421e+06 3.08257e+07 139 1.97092e+06 428 1.17179e+07 238 5.94846e+06
78597 20231110.2 0.820217 5574.8 8.59996e+07 14024.1 1.88908e+07 17438.9 14119.9 1.05021e+07 28119.2 2.51822e+07 15507.8 1.46964e+07 45782.2 48199 54129.5 89644 4406.4 1421.1 1.25993e+07 17319.5 19699.8 7248.55 1.67936e+07 14922.9 7079.1 6.30784e+06 14864.4 5793.81 1.67936e+07 10196.3 5494.3 1.67936e+07 3999.09 1.67936e+07 45165.9 835013 1.18481e+06 8.14223e+06 3.07975e+07 124 1.97092e+06 410 1.17179e+07 227 5.94846e+06
78603 20231110.5 0.800484 5580.74 8.59996e+07 14024.5 1.88908e+07 17135.5 14134.4 1.05021e+07 28155.1 2.30851e+07 15453.5 1.46964e+07 43772.8 47530.3 54447 73387.6 4438.1 1435.7 1.25993e+07 17217.2 19690.9 7234.68 1.67936e+07 17424.3 6947 6.30784e+06 15192.4 5801.75 1.67936e+07 10204.5 5489.21 1.67936e+07 4002.28 1.67936e+07 38563.2 834638 1.17761e+06 8.0415e+06 3.07975e+07 122 1.97092e+06 414 1.17179e+07 227 5.94846e+06

align_leadership_state_naming

build_id build_number pi_basic_mt_sgx_cft^ pi_basic_mt_sgx_cft_mem pi_basic_mt_virtual_cft^ Commit latency factor tpcc_virtual_cft^ ls_virtual_cft^ pi_ls_virtual_cft^ tpcc_sgx_cft^ tpcc_sgx_cft_mem pi_basic_virtual_cft^ pi_basic_js_virtual_cft^ ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ ls_js_virtual_cft^ ls_sgx_cft^ ls_sgx_cft_mem ls_full_js_virtual_cft^ pi_ls_sgx_cft^ pi_ls_sgx_cft_mem pi_basic_sgx_cft^ pi_basic_sgx_cft_mem ls_js_jwt_virtual_cft^ pi_basic_js_sgx_cft^ pi_basic_js_sgx_cft_mem hist_sgx_cft^ ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem tlc_3node_fixed_duration_s tlc_3node_fixed_states tlc_atomic_reconfig_duration_s tlc_atomic_reconfig_states tlc_reconfig_duration_s tlc_reconfig_states RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
78576 20231109.6 27987.5 2.30851e+07 78022.4 0.823271 17448.5 43665.5 46817.4 5587.27 8.59996e+07 53580.3 4375.7 17130.9 19383.6 14919.4 14042.2 1.88908e+07 14758.3 14137 1.05021e+07 15595.2 1.46964e+07 10215.1 1434.6 1.25993e+07 43821.3 6876.97 1.88908e+07 7102.7 6.30784e+06 5766.59 1.67936e+07 5483.9 1.88908e+07 3974.73 1.67936e+07 122 1.97092e+06 396 1.17179e+07 238 5.94846e+06 834364 1.17553e+06 8.15248e+06 3.06449e+07
78579 20231109.7 28053.6 2.51822e+07 73518.8 0.771446 17306.7 46023.1 47600.9 5561.44 8.59996e+07 54282.5 4435 17053.6 19261.1 17290 14026.1 1.88908e+07 14974.3 14172.8 1.05021e+07 15563.7 1.46964e+07 10218.3 1424.1 1.25993e+07 41559.7 6853.41 1.67936e+07 6932.9 6.30784e+06 5751.58 1.67936e+07 5490.24 1.67936e+07 3976.07 1.67936e+07 139 1.97092e+06 419 1.17179e+07 229 5.94846e+06 838767 1.17328e+06 8.13577e+06 3.24724e+07
78613 20231110.8 27897.1 2.30851e+07 64940.1 0.802293 17445.3 45785 47137.3 5638.43 8.59996e+07 52432.7 4436 17055.3 19007.8 17262.5 14074 1.88908e+07 14708.4 14199 1.05021e+07 15645.8 1.25993e+07 10202.6 1441.4 1.25993e+07 45220.6 6874.28 1.88908e+07 6954.8 6.30784e+06 5806.68 1.67936e+07 5736.54 1.67936e+07 3998.01 1.67936e+07 124 1.97092e+06 418 1.17179e+07 229 5.94846e+06 828610 1.18148e+06 8.15563e+06 3.07434e+07

images

@achamayou achamayou requested a review from heidihoward November 9, 2023 13:24
tla/consensus/ccfraft.tla Outdated Show resolved Hide resolved
tla/consensus/ccfraft.tla Outdated Show resolved Hide resolved
tla/consensus/ccfraft.tla Outdated Show resolved Hide resolved
@achamayou achamayou merged commit 942ff3a into microsoft:main Nov 10, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants