Adding TLC stats to cimetrics #5807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tla-cimetrics@78481 aka 20231107.14 vs main ewma over 20 builds from 78115 to 78447 Click to see tablemain
tla-cimetrics
|
lemmy
added a commit
to tlaplus/CommunityModules
that referenced
this pull request
Nov 1, 2023
Json!ndJsonSerialize. Related to microsoft/CCF#5807 [Feature][TLC]
|
@eddyashton @achamayou Still a WIP but I'd appreciate feedback at this stage. I've deliberately omitted |
lemmy
reviewed
Nov 2, 2023
RonSheely
pushed a commit
to RonSheely/tlaplus
that referenced
this pull request
Nov 3, 2023
Json!ndJsonSerialize. Related to microsoft/CCF#5807 [Feature][TLC]
achamayou
approved these changes
Nov 7, 2023
|
@heidihoward if you would like a different category, you can add a line in https://github.com/microsoft/CCF/blob/main/metrics.yml, something like "TLC": "tlc_.*", before the "Others" catch-all (they are evaluated in order). |
done in e1e3cc4 |
heidihoward
changed the title
achamayou
reviewed
Nov 7, 2023
achamayou
reviewed
Nov 7, 2023
|
Yay, this is now working! |
achamayou
approved these changes
Nov 7, 2023
|
Looking at the CI output wheel is complaining a bit but it seems to work anyways. I think actually it might be best to switch to cimetrics_env.sh so only cimetrics is installed. I did spot this handy script the first time around but did not use it as I wrongly assumed we didn't need a virtual env. PS: Sorry, I don't know how to post a link to ADO pipelines, copying and pasting the URL gives this fun error |
|
@heidihoward you're absolutely right, I'd completely forgotten about that script. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some TLC stats to the cimetrics. To keep things simple, this PR just adds the duration and number of distinct states for
MCccfraft.tlabut we can easily extended this.