Minimal repro triggering the issue in ccfraft.tla AdvanceCommitIndex #5798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 30, 2023
|
repro_scenario_for_advance_commit_index_bug@79900 aka 20240105.5 vs main ewma over 20 builds from 79642 to 79901 Click to see tablemain
repro_scenario_for_advance_commit_index_bug
|
5 tasks
…/github.com/achamayou/CCF into repro_scenario_for_advance_commit_index_bug
|
Build is green because *_deprecated scenarios do not run. |
lemmy
added a commit
that referenced
this pull request
Dec 20, 2023
…reas raft.h advances to the largest possible one. Originally found in #5798.
lemmy
added a commit
that referenced
this pull request
Jan 2, 2024
…reas raft.h advances to the largest possible one. Originally found in #5798.
|
The link to the trace is no longer working. Would it be possible to increase the retention time for ADO build logs? |
If you need to recreate the trace/log, checking out the commit on a Codespace is relatively straight forward. |
lemmy
added a commit
that referenced
this pull request
Jan 4, 2024
…reas raft.h advances to the largest possible one. Originally found in #5798.
|
I had a go at reproducing this against the latest version but it wasn't successful, I assume that is due to the changes in the trace validation since. Output |
|
@heidihoward it looks like that did not check anything: I believe this is fixed by #5879, we can hopefully make progress on the realistic scenarios again with that out of the way. |
lemmy
added a commit
that referenced
this pull request
Jan 5, 2024
…reas raft.h advances to the largest possible one. Originally found in #5798.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AdvanceCommitIndex always picks the smallest possible index to move commit to, which breaks on traces as soon as there is more than one signature pending.
See trace produced under https://dev.azure.com/MSRC-CCF/CCF/_build/results?buildId=78092&view=logs&j=0c81e209-1101-513f-1f15-37e9c3575eb2&t=a05664f3-ab91-5eb2-6acd-14e2179ad708