Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/4.x] Cherry pick: Simplify construction of JS globals (#5385) #5736

Merged
merged 3 commits into from
Oct 17, 2023
Merged

[release/4.x] Cherry pick: Simplify construction of JS globals (#5385) #5736

merged 3 commits into from
Oct 17, 2023

Conversation

achamayou
Copy link
Member

Backports the following commits to release/4.x:

@eddyashton
Simplify construction of JS globals (microsoft#5385)
0c35044 
(cherry picked from commit 2dc8cf2)

# Conflicts:
#	src/node/rpc/member_frontend.h
@achamayou achamayou requested a review from a team October 17, 2023 10:37
@achamayou achamayou added the 4.x-backport Highlights PRs targeting the 4.x branch label Oct 17, 2023
@achamayou achamayou enabled auto-merge (squash) October 17, 2023 10:37
@ghost
Copy link

ghost commented Oct 17, 2023

backport/release/4.x/pr-5385@77325 aka 20231017.11 vs release/4.x ewma over 20 builds from 76099 to 77301

Click to see table

release/4.x

build_id build_number Commit latency factor ls_virtual_cft^ ls_sgx_cft^ ls_sgx_cft_mem pi_ls_virtual_cft^ pi_ls_sgx_cft^ pi_ls_sgx_cft_mem ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_js_virtual_cft^ ls_full_js_virtual_cft^ ls_js_jwt_virtual_cft^ ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem hist_sgx_cft^ ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem tpcc_virtual_cft^ tpcc_sgx_cft^ tpcc_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
76099 20230920.3 0.769422 45650 14114.6 1.88908e+07 47597.3 14259.7 1.05021e+07 16959.6 18965.6 6818.42 1.88908e+07 7040.6 6.30784e+06 4438.6 3745.31 3796.36 1462.46 1.05021e+07 1281.88 1.05021e+07 45383.9 1303.32 1.05021e+07 17448.2 5659.06 8.59996e+07 834668 1.1819e+06 8.15507e+06 3.07535e+07
76166 20230921.4 0.813695 45733.3 14082.6 1.88908e+07 47828.6 14266.1 1.05021e+07 17192.7 18659.5 6868.35 1.67936e+07 7201.7 6.30784e+06 4396.97 3744.51 3768.92 1463.7 1.05021e+07 1266.47 1.05021e+07 45721.1 1291.86 1.05021e+07 17169.6 5615.09 8.59996e+07 838024 1.18114e+06 8.15316e+06 3.07434e+07
76285 20230922.2 0.799862 45581.8 14059.7 1.67936e+07 44511.9 14232 1.05021e+07 17549.7 19018.3 6855.98 1.67936e+07 7188.2 6.30784e+06 4173.08 3702.99 3752.96 1459.98 1.05021e+07 1280.53 1.05021e+07 45567.2 1303.05 1.05021e+07 17350 5608.04 8.59996e+07 828183 1.17868e+06 8.15433e+06 3.27753e+07
76346 20230925.2 0.802053 45524.2 14074.3 1.67936e+07 47345.8 14227.9 1.05021e+07 17115.4 18542.9 6855.82 1.88908e+07 7201.3 6.30784e+06 4434.67 3732.99 3768.27 1463.13 1.05021e+07 1287.44 1.05021e+07 45953.9 1291.03 1.05021e+07 17402 5628.1 8.59996e+07 829606 1.18042e+06 8.15173e+06 3.04223e+07
76414 20230926.2 0.806567 45685.2 14011.4 1.88908e+07 47422.8 14207.5 1.05021e+07 17283.8 19351.7 6871.45 1.67936e+07 7215.8 6.30784e+06 4426.62 3727.77 3798.16 1460.64 1.05021e+07 1281.73 1.05021e+07 43863.4 1303.32 1.05021e+07 17370 5625.01 8.59996e+07 832445 1.17954e+06 8.14952e+06 3.10845e+07
76475 20230927.2 0.780784 45614.3 14075.4 1.88908e+07 47089.7 14197.5 1.05021e+07 17216.6 19016.1 7247.5 1.67936e+07 7196.3 6.30784e+06 4438.51 3715.17 3773.47 1458.67 1.05021e+07 1277.25 1.05021e+07 46912.3 1290.57 1.05021e+07 17481.1 5567.13 8.59996e+07 842542 1.18151e+06 8.14758e+06 3.08127e+07
76523 20230928.3 0.791744 43847.3 14099.3 1.88908e+07 45927.4 14254.2 1.05021e+07 17480.9 18743.8 7283.92 1.67936e+07 7199.6 6.30784e+06 4282.92 3599.56 3669.41 1459.87 1.05021e+07 1279.14 1.05021e+07 38874.5 1303.57 1.05021e+07 17121.8 5624.66 8.59996e+07 830623 1.17622e+06 8.14917e+06 3.07471e+07
76605 20230929.3 0.794619 43675.5 14071.7 1.88908e+07 46882.3 14194.2 1.05021e+07 17153.9 19083.2 6845.03 1.67936e+07 7250.6 6.30784e+06 4422.03 3728.57 3781.93 1464.52 1.05021e+07 1275.46 1.05021e+07 43156.9 1294.89 1.05021e+07 17372.9 5528.1 8.59996e+07 828515 1.18256e+06 8.15241e+06 3.07106e+07
76682 20231002.2 0.795416 43807.5 14015.5 1.67936e+07 47103.8 14169.9 1.05021e+07 17037.9 18973.2 6825.93 1.67936e+07 7155.8 6.30784e+06 4404.17 3765.78 3788.71 1454.37 1.05021e+07 1280.24 1.05021e+07 43221.9 1290.23 1.05021e+07 17429.7 5537.99 8.59996e+07 831957 1.17075e+06 8.15274e+06 3.06734e+07
76732 20231003.2 0.789944 43762.2 14045.5 1.67936e+07 33974.1 14208.5 1.05021e+07 17430.4 18760.3 6884.55 1.88908e+07 7181.8 6.30784e+06 4283.27 3637.4 3653.99 1461.28 1.05021e+07 1279.86 1.05021e+07 39282.7 1292.28 1.05021e+07 17593.2 5609.42 8.59996e+07 835629 1.17736e+06 8.15137e+06 3.08434e+07
76819 20231004.3 0.807069 43715.9 14113.4 1.88908e+07 46504.9 14220.3 1.05021e+07 16985.8 18920.4 6865.25 1.88908e+07 7243.5 6.30784e+06 4419.47 3722.08 3784.97 1458.38 1.05021e+07 1279.5 1.05021e+07 41835.8 1287.07 1.05021e+07 17249.3 5610.64 8.59996e+07 832050 1.18486e+06 8.16984e+06 3.12138e+07
76925 20231005.3 0.809171 43629.6 14059.8 1.88908e+07 47004.2 14206 1.05021e+07 17192.2 19133.3 7261.85 1.67936e+07 7175.8 6.30784e+06 4463.56 3727.51 3645.37 1458.85 1.05021e+07 1280.05 1.05021e+07 41890.8 1295.18 1.05021e+07 17203.2 5582.63 8.59996e+07 839833 1.18299e+06 8.15501e+06 3.07614e+07
76943 20231006.2 0.798662 43888.7 14121.4 1.67936e+07 47048.9 14246.3 1.05021e+07 17190.8 18742.7 7265.4 1.67936e+07 7203.3 6.30784e+06 4412.46 3728.69 3774.03 1461.24 1.05021e+07 1279.48 1.05021e+07 47974.2 1302.52 1.05021e+07 17653.3 5596.91 8.59996e+07 820948 1.17955e+06 8.13289e+06 3.14269e+07
76983 20231009.3 0.801814 43711.1 14042.4 1.88908e+07 46975.3 14247.5 1.05021e+07 17186.3 18705.9 6895.13 1.88908e+07 7205.1 6.30784e+06 4427.63 3717.55 3774.24 1453.99 1.05021e+07 1272.37 1.05021e+07 45279.1 1301.06 1.05021e+07 17117.3 5632.92 8.59996e+07 841366 1.17618e+06 8.15361e+06 3.07378e+07
77013 20231010.3 0.790055 43629.4 14078.3 1.88908e+07 45985.3 14234.8 1.05021e+07 17459.9 19035.3 6858.07 1.88908e+07 7198.5 6.30784e+06 4444.61 3749.53 3802.96 1454.78 1.05021e+07 1276.23 1.05021e+07 43378.3 1290 1.05021e+07 17138.2 5597.26 8.59996e+07 818831 1.17724e+06 8.15361e+06 3.07826e+07
77078 20231011.5 0.808507 43765 14145.9 1.88908e+07 46636.5 14265.2 1.05021e+07 17221.8 19288.2 6839.81 1.67936e+07 7203.8 6.30784e+06 4428.07 3728.86 3784.44 1456.17 1.05021e+07 1275.03 1.05021e+07 41537.1 1291.12 1.05021e+07 17129.1 5624.05 8.59996e+07 830593 1.18037e+06 8.15394e+06 3.16235e+07
77151 20231012.4 0.778621 43692.3 14083.6 1.67936e+07 46548.2 14213.5 1.05021e+07 17205.3 18575.2 6913.46 1.88908e+07 7207.5 6.30784e+06 4428.27 3710.96 3759.24 1460.52 1.05021e+07 1290.17 1.05021e+07 40524 1306.04 1.05021e+07 17109.5 5665.85 8.59996e+07 834428 1.17973e+06 8.14949e+06 3.06711e+07
77198 20231013.2 0.787261 43684.6 14098.5 1.88908e+07 46802.9 14250.2 1.05021e+07 17059.9 19065 6890.78 1.88908e+07 7251.2 6.30784e+06 4413.96 3698.72 3756.52 1460.18 1.05021e+07 1275.87 1.05021e+07 39916.8 1303.97 1.05021e+07 17262.9 5622.53 8.59996e+07 828399 1.18608e+06 8.17304e+06 3.06918e+07
77230 20231016.2 0.777841 43703.4 14053.7 1.88908e+07 46945.7 14246.7 1.05021e+07 16904.9 18828.1 6881.04 1.67936e+07 7263.4 6.30784e+06 4438.99 3724.28 3789.57 1464.6 1.05021e+07 1284.76 1.05021e+07 45076.8 1303.83 1.05021e+07 17121.3 5623.42 8.59996e+07 838624 1.18017e+06 8.15079e+06 3.08016e+07
77301 20231017.2 0.785227 43905.1 14026.7 1.88908e+07 46952.5 14219.3 1.05021e+07 17180.6 18623.7 6831.38 1.67936e+07 7232.6 6.30784e+06 4446.66 3717.65 3786.36 1459.17 1.05021e+07 1277.06 1.05021e+07 45594 1301.17 1.05021e+07 17423.7 5553.28 8.59996e+07 840943 1.17774e+06 8.17186e+06 3.13174e+07

backport/release/4.x/pr-5385

build_id build_number Commit latency factor tpcc_virtual_cft^ ls_virtual_cft^ pi_ls_virtual_cft^ ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_js_virtual_cft^ ls_full_js_virtual_cft^ ls_sgx_cft^ ls_sgx_cft_mem ls_js_jwt_virtual_cft^ pi_ls_sgx_cft^ pi_ls_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem hist_sgx_cft^ ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
77325 20231017.11 0.778644 17360.3 43842.2 47371.6 17311.3 18689.8 5610.84 8.59996e+07 4469.24 3733.81 13993.3 1.88908e+07 3779.66 14167.1 1.05021e+07 6773.57 1.88908e+07 7196.9 6.30784e+06 42424.3 1481.54 1.05021e+07 1298.41 1.05021e+07 1317.49 1.05021e+07 822489 1.17729e+06 8.17346e+06 3.0842e+07

images

@achamayou achamayou merged commit 8ec47ab into microsoft:release/4.x Oct 17, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyashton eddyashton eddyashton approved these changes

Assignees
No one assigned
Labels
4.x-backport Highlights PRs targeting the 4.x branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achamayou @eddyashton