Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that JS app code is correctly updated despite interpreter reuse #5728

Merged
merged 8 commits into from
Oct 16, 2023

Conversation

eddyashton
Copy link
Member

Just a regression test confirming current behaviour. Although the endpoint tries to reuse an interpreter, the interpreter cache is correctly flushed during app update. Note that this test will fail if the constitution is modified to not flush interpreters in set_js_app:apply.

@eddyashton eddyashton requested a review from a team October 12, 2023 14:57
@ghost
Copy link

ghost commented Oct 12, 2023

js_func_caching@77257 aka 20231016.11 vs main ewma over 20 builds from 76869 to 77236

Click to see table

main

build_id build_number pi_basic_mt_sgx_cft^ pi_basic_mt_sgx_cft_mem Commit latency factor tpcc_sgx_cft^ tpcc_sgx_cft_mem pi_basic_mt_virtual_cft^ tpcc_virtual_cft^ ls_virtual_cft^ pi_ls_virtual_cft^ pi_basic_virtual_cft^ ls_sgx_cft^ ls_sgx_cft_mem pi_ls_sgx_cft^ pi_ls_sgx_cft_mem pi_basic_sgx_cft^ pi_basic_sgx_cft_mem pi_basic_js_virtual_cft^ ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ ls_js_virtual_cft^ ls_full_js_virtual_cft^ pi_basic_js_sgx_cft^ pi_basic_js_sgx_cft_mem ls_js_jwt_virtual_cft^ ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem hist_sgx_cft^ ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
76869 20231004.22 27762.1 2.51822e+07 0.806157 5552.49 8.59996e+07 70744.9 17245.9 45658.4 48077.4 54561.1 14003.1 1.88908e+07 14065.4 1.05021e+07 15372.4 1.46964e+07 4464.3 17322.8 18923.3 17202.1 15082.4 1427 1.25993e+07 9913.2 6868.91 1.88908e+07 7022 6.30784e+06 5804.63 1.67936e+07 5756.12 1.67936e+07 45382.2 3991.19 1.67936e+07 834342 1.18098e+06 8.14978e+06 3.08076e+07
76888 20231004.30 27780.7 2.30851e+07 0.810034 5604.3 8.59996e+07 67387.1 17390.9 45776.9 48301 51883.1 13985 1.88908e+07 14115.9 1.05021e+07 15556.5 1.46964e+07 4390.1 17189.2 20048.9 15378.1 14886.4 1434.9 1.25993e+07 10356.8 6863.79 1.67936e+07 7032.1 6.30784e+06 5815.76 1.67936e+07 5751.88 1.67936e+07 42002.2 3969.63 1.67936e+07 823286 1.18056e+06 8.1555e+06 3.03318e+07
76915 20231004.42 27485.2 2.51822e+07 0.774478 5624.97 8.59996e+07 80712.1 17274.8 46033.9 48315.9 53167.5 14042.4 1.88908e+07 14174.9 1.05021e+07 15627.4 1.25993e+07 4402.4 17273.2 19310.2 17384.9 14995.5 1433.2 1.25993e+07 10159.5 6910.89 1.88908e+07 6998.2 6.30784e+06 5784.96 1.67936e+07 5748.49 1.67936e+07 40358.8 4003.02 1.67936e+07 835408 1.17924e+06 8.12898e+06 3.07817e+07
76922 20231005.1 28029.7 2.51822e+07 0.810974 5626.69 8.59996e+07 65412.6 17459.2 45898.2 48742 54118.6 14039 1.88908e+07 14080.5 1.05021e+07 15577.1 1.46964e+07 4456.3 17231.8 20034.9 17323.3 14832.9 1432.3 1.25993e+07 10275.8 6863.93 1.67936e+07 7085.2 6.30784e+06 5810.75 1.67936e+07 5719.35 1.67936e+07 42574.2 3992.52 1.67936e+07 829315 1.17285e+06 8.14651e+06 3.07836e+07
76933 20231005.5 27882.8 2.30851e+07 0.805698 5569.11 8.59996e+07 81465 17274.6 45946.3 48589.4 54166.2 14005.2 1.88908e+07 14146.2 1.05021e+07 15512.2 1.46964e+07 4463.6 17329.5 19980 17094.5 16949.3 1432.2 1.25993e+07 9763.9 6865.95 1.88908e+07 6977.1 6.30784e+06 5765.37 1.67936e+07 5766.41 1.67936e+07 39270.6 3994.82 1.67936e+07 837034 1.18428e+06 8.10377e+06 3.25923e+07
76941 20231006.1 28097.1 2.30851e+07 0.799935 5581.89 8.59996e+07 65485.1 17296.4 45618.5 48175.1 53457.3 14055.4 1.88908e+07 14129.3 1.05021e+07 15654.4 1.25993e+07 4479 17334.7 19718.8 17075.6 14603.4 1434.8 1.25993e+07 9842.12 6890.62 1.67936e+07 6976.6 6.30784e+06 5781.49 1.67936e+07 5744.04 1.67936e+07 39294.9 4009.45 1.67936e+07 839192 1.18477e+06 8.15264e+06 3.23033e+07
76953 20231006.6 27710.2 2.51822e+07 0.797479 5610.73 8.59996e+07 78324.4 16945.5 43917.9 48958.9 53263.2 14024 1.88908e+07 14122.5 1.05021e+07 15585.3 1.25993e+07 4423.9 17245.1 18721.7 17292 14773.2 1444.6 1.25993e+07 9748.83 7252.76 1.67936e+07 7058.2 6.30784e+06 5820.86 1.67936e+07 5773.73 1.67936e+07 45657 4008.93 1.67936e+07 835912 1.17953e+06 8.07625e+06 2.6895e+07
76967 20231006.11 28032.2 2.30851e+07 0.799426 5542.39 8.59996e+07 64719 17341.4 45691.3 48875.1 54004.5 13951.2 1.88908e+07 14077.9 1.05021e+07 15519.1 1.25993e+07 4469.9 17300.7 19158.2 16934.3 14583.1 1421.7 1.25993e+07 9795.4 6820.04 1.88908e+07 6884.1 6.30784e+06 5770.08 1.67936e+07 5760.09 1.88908e+07 47130.7 4004.62 1.67936e+07 835081 1.17659e+06 8.17304e+06 3.09852e+07
76976 20231007.2 27833 2.51822e+07 0.797827 5640.74 8.59996e+07 69696.2 17276.4 45702.6 48619 53436.8 14032.5 1.88908e+07 14190 1.05021e+07 15631.1 1.46964e+07 4409.7 17184.3 19733.2 17169.5 14871.6 1433.9 1.25993e+07 9779.02 7287.64 1.67936e+07 7044.3 6.30784e+06 5786.37 1.67936e+07 5747.56 1.67936e+07 45049.2 4006.09 1.67936e+07 830418 1.18267e+06 8.17291e+06 3.07891e+07
76982 20231009.2 27935.7 2.51822e+07 0.792855 5580.01 8.59996e+07 81026 17231.2 45523.7 48581 54131 13963.1 1.88908e+07 14141.8 1.05021e+07 15380.7 1.25993e+07 4253.1 17397.5 19156 17135.7 16869.3 1439.9 1.25993e+07 9793.25 7196.39 1.67936e+07 7023.9 6.30784e+06 5773.77 1.67936e+07 5474.35 1.67936e+07 46259.3 3981.48 1.67936e+07 832879 1.18218e+06 8.14943e+06 3.15184e+07
76994 20231009.5 27792.2 2.30851e+07 0.799524 5591.29 8.59996e+07 88389.5 17106.4 45848 48779.1 53666.3 13986.8 1.88908e+07 14144 1.05021e+07 15585.3 1.25993e+07 4397.6 17242 19596.7 16914.5 16715.5 1431.3 1.25993e+07 9855.69 6852.61 1.67936e+07 6940.5 6.30784e+06 5808.48 1.67936e+07 5783.34 1.67936e+07 44311.9 3987.05 1.67936e+07 831717 1.18619e+06 8.15293e+06 3.07093e+07
77015 20231010.4 27777.8 2.30851e+07 0.83228 5592.78 8.59996e+07 62049.7 17372.9 45785.1 48171.9 53651.8 14023.3 1.88908e+07 14107 1.05021e+07 15597.5 1.25993e+07 4441.2 17407.2 19739.4 17105.5 16857.9 1436 1.25993e+07 9954.93 6898.77 1.88908e+07 7117.8 6.30784e+06 5804.14 1.67936e+07 5786.43 1.67936e+07 41221.6 4016.78 1.67936e+07 825345 1.18742e+06 8.12844e+06 3.06711e+07
77052 20231010.17 27851.7 2.51822e+07 0.805827 5614.03 8.59996e+07 87071.8 17123.9 45707.2 48521.1 53548.8 14004.1 1.88908e+07 14072.2 1.05021e+07 15532.7 1.25993e+07 4435.4 17238.9 19725.4 17064.9 16932.1 1434.8 1.25993e+07 9900.42 6879.16 1.88908e+07 6931.4 6.30784e+06 5811.67 1.67936e+07 5725.25 1.88908e+07 39661.9 3978.87 1.67936e+07 835356 1.17508e+06 8.12795e+06 3.02453e+07
77065 20231010.21 27866.2 2.51822e+07 0.805254 5593.79 8.59996e+07 76791.9 17453.5 45981.3 47639.7 53782.5 13984.2 1.88908e+07 14076.6 1.05021e+07 15457.8 1.46964e+07 4471.3 17159.7 19727 17221.9 16835.2 1431.7 1.25993e+07 9888.21 6839.77 1.67936e+07 6882.8 6.30784e+06 5802.59 1.67936e+07 5713.9 1.67936e+07 47354.4 3982.91 1.67936e+07 831464 1.17023e+06 8.14609e+06 3.06028e+07
77080 20231011.6 28231.3 2.30851e+07 0.805739 5614.98 8.59996e+07 77100.4 17356.8 45541.3 47443.3 53459.3 14016.4 1.67936e+07 14058.7 1.05021e+07 15607.1 1.25993e+07 4480.6 17192.9 19626.7 16932.3 16704.5 1435.6 1.25993e+07 9841.59 6865.39 1.88908e+07 6917 6.30784e+06 5768.86 1.67936e+07 5749.11 1.67936e+07 44338.6 3974.5 1.67936e+07 839572 1.1863e+06 8.14557e+06 3.07489e+07
77087 20231011.8 27891.2 2.51822e+07 0.821071 5620.28 8.59996e+07 83135 17648.9 45716.6 48214.1 53475.5 14043.4 1.88908e+07 14129.4 1.05021e+07 15619 1.46964e+07 4431.6 17316.9 19004.2 17758.2 16880.7 1427.7 1.25993e+07 9849.81 6872.29 1.67936e+07 7079.7 6.30784e+06 5780.82 1.67936e+07 5765.08 1.67936e+07 40652.5 3974.44 1.67936e+07 827510 1.16961e+06 8.14036e+06 3.30899e+07
77124 20231011.20 27859.9 2.51822e+07 0.810686 5576.3 8.59996e+07 81677.3 17272.2 45763.1 48479 54961.6 13934.9 1.88908e+07 14029.2 1.05021e+07 15421.8 1.25993e+07 4431 17497.2 19917.1 17216.9 16806.9 1419.9 1.25993e+07 9875.23 6782.48 1.67936e+07 7028.9 6.30784e+06 5759.88 1.67936e+07 5495.58 1.88908e+07 42920 3980.45 1.67936e+07 829281 1.17704e+06 8.02253e+06 3.09324e+07
77138 20231011.24 27788.7 2.51822e+07 0.817166 5505.15 8.59996e+07 79701.7 17450.2 43714.5 47439 54645.3 13944.3 1.88908e+07 14007.9 1.05021e+07 15414.3 1.46964e+07 4386.8 16999.7 19561.8 17388.6 14746.3 1420.9 1.25993e+07 9915 6826.31 1.88908e+07 6933.7 6.30784e+06 5805.03 1.67936e+07 5491.25 1.67936e+07 39122 3992.65 1.67936e+07 838714 1.18152e+06 8.09934e+06 3.09754e+07
77148 20231012.2 28066.3 2.51822e+07 0.806977 5622.22 8.59996e+07 88890.3 17218.1 46048.4 48655.6 55217 14012.7 1.88908e+07 14136.8 1.05021e+07 15607.9 1.25993e+07 4449.2 17077.4 19720.8 17064.5 15135.1 1437.4 1.25993e+07 9799.03 6885.22 1.88908e+07 6981.9 6.30784e+06 5813.57 1.67936e+07 5723.57 1.88908e+07 45326.3 4000.45 1.67936e+07 828634 1.17897e+06 8.14758e+06 3.07383e+07
77236 20231016.5 27858.7 2.51822e+07 0.79596 5620.83 8.59996e+07 59377 17148.6 45783.9 48719.4 54902.8 13995.4 1.88908e+07 14108.1 1.05021e+07 15609.7 1.46964e+07 4441 17077.1 18804.1 17198.3 15291.6 1442 1.25993e+07 9993.77 6827.74 1.67936e+07 7065.1 6.30784e+06 5817.83 1.67936e+07 5743.02 1.67936e+07 44154.4 4006.32 1.67936e+07 838342 1.17813e+06 8.15154e+06 3.18804e+07

js_func_caching

build_id build_number pi_basic_mt_sgx_cft^ pi_basic_mt_sgx_cft_mem pi_basic_mt_virtual_cft^ Commit latency factor tpcc_virtual_cft^ ls_virtual_cft^ pi_ls_virtual_cft^ pi_basic_virtual_cft^ tpcc_sgx_cft^ tpcc_sgx_cft_mem pi_basic_js_virtual_cft^ ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ ls_js_virtual_cft^ ls_sgx_cft^ ls_sgx_cft_mem ls_full_js_virtual_cft^ pi_ls_sgx_cft^ pi_ls_sgx_cft_mem ls_js_jwt_virtual_cft^ pi_basic_sgx_cft^ pi_basic_sgx_cft_mem pi_basic_js_sgx_cft^ pi_basic_js_sgx_cft_mem hist_sgx_cft^ ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
77182 20231012.15 27240.6 2.51822e+07 68399.7 0.818384 17260.6 45617.6 48088 55055.5 5603.49 8.59996e+07 4436.3 17183.2 19484.4 16905.4 14020.1 1.88908e+07 14929.1 14076.4 1.05021e+07 9857.6 15518.1 1.46964e+07 1430.2 1.25993e+07 44420.4 7256.97 1.67936e+07 6939.9 6.30784e+06 5812.57 1.67936e+07 5760.09 1.67936e+07 3998.35 1.67936e+07 833725 1.18493e+06 8.15115e+06 3.1027e+07
77186 20231012.16 27450.7 2.51822e+07 63444.4 0.81089 17278.1 45687.5 47578 55834.5 5615.23 8.80968e+07 4425.1 17113.5 19765.6 17078.2 13861.2 1.88908e+07 16748.4 14047.4 1.05021e+07 9883.92 15376 1.46964e+07 1418.6 1.25993e+07 45349.4 6777.74 1.88908e+07 6819.4 6.30784e+06 5751.43 1.67936e+07 5473.23 1.67936e+07 3982.66 1.67936e+07 835325 1.17949e+06 8.13334e+06 3.11071e+07
77251 20231016.9 27436.9 2.30851e+07 79882.7 0.77975 17147.7 45890.6 48494.5 56575.9 5583.28 8.59996e+07 4457.3 17143.2 19270.4 17135.9 14008.8 1.88908e+07 15060 14088.2 1.05021e+07 9860.37 15594.1 1.46964e+07 1424.6 1.25993e+07 43876.1 6854.92 1.88908e+07 6931.1 6.30784e+06 5766.1 1.67936e+07 5724.16 1.88908e+07 3992.03 1.67936e+07 832441 1.18101e+06 8.14826e+06 3.13365e+07
77257 20231016.11 27670.6 2.30851e+07 78886.6 0.762997 17044.5 43721.6 47798.6 53620.8 5589.81 8.59996e+07 4396.6 17092.7 19261.5 17425.2 14012.5 1.88908e+07 14957.3 14115.1 1.05021e+07 9925.22 15647.7 1.25993e+07 1420.1 1.25993e+07 40628.2 7216.12 1.88908e+07 6925 6.30784e+06 5797.08 1.67936e+07 5776.06 1.67936e+07 4002.22 1.67936e+07 833043 1.18347e+06 8.14823e+06 3.08359e+07

images

@eddyashton eddyashton enabled auto-merge (squash) October 16, 2023 13:02
@eddyashton eddyashton merged commit a8b1fe5 into microsoft:main Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants