-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intermediate fix for JS KV handle caching - TypedKvMap does lazy lookup #5717
Merged
eddyashton
merged 4 commits into
microsoft:main
from
eddyashton:interp_reuse_handle_caching
Oct 10, 2023
Merged
Intermediate fix for JS KV handle caching - TypedKvMap does lazy lookup #5717
eddyashton
merged 4 commits into
microsoft:main
from
eddyashton:interp_reuse_handle_caching
Oct 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achamayou
approved these changes
Oct 10, 2023
interp_reuse_handle_caching@77042 aka 20231010.13 vs main ewma over 20 builds from 76674 to 77015 Click to see tablemain
interp_reuse_handle_caching
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have found an issue with interpreter reuse, where caching of KV handles can result in memory violations (attempting to access handles from a previous Tx). A full fix for this will land in future, marking such handles as dirty so they are refreshed in future invocations. This is a temporary/partial fix, resolving the issue for TypeScript applications by making all handle lookups lazy.