Add basic backpressure mechanism if primary has too many in-flight transactions #5692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achamayou
changed the title
Report error rate, fail if non-zero Pros: safe, provided an exception is made for Report error rate, don't fail if non-zero Pros: can run tests close to the cap in CI Report error rates and plot them Pros: can run tests close to the cap in CI |
|
committable_threshold_backpressure@76588 aka 20230928.29 vs main ewma over 20 builds from 76284 to 76583 Click to see tablemain
committable_threshold_backpressure
|
|
Summary of discussion with @eddyashton:
|
|
The change seems to work as intended in performance runs: 
Still to do, add:
|
eddyashton
reviewed
Sep 28, 2023
eddyashton
reviewed
Sep 28, 2023
eddyashton
approved these changes
Sep 28, 2023
Co-authored-by: Eddy Ashton <[email protected]>
achamayou
added
auto-backport
eddyashton
approved these changes
Sep 28, 2023
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
ghost
mentioned this pull request
ghost
mentioned this pull request
achamayou
added a commit
to achamayou/CCF
that referenced
this pull request
Oct 18, 2023
…ansactions (microsoft#5692) (cherry picked from commit d1d9d8e) # Conflicts: # CHANGELOG.md # tests/infra/basicperf.py # tests/infra/remote.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #3871 and #5690.
Added a
consensus.max_uncommitted_tx_count, which caps the maximum number of uncommitted transactions a primary allows before pushing back with HTTP errors. An exception is carved out for the/nodefrontend, to avoid hampering diagnostic attempts on a primary that may be stuck at the cap (for example because >fnodes have died).Working on the tests (see comments), but the change itself is ready to review.