Implement Azure-compliant governance interface #5660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achamayou
reviewed
Sep 27, 2023
achamayou
reviewed
Sep 27, 2023
achamayou
approved these changes
Sep 27, 2023
Co-authored-by: Amaury Chamayou <[email protected]>
achamayou
approved these changes
Sep 27, 2023
eddyashton
added
auto-backport
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
ghost
mentioned this pull request
achamayou
pushed a commit
to achamayou/CCF
that referenced
this pull request
Oct 17, 2023
(cherry picked from commit 88cb1ea) # Conflicts: # CMakeLists.txt # src/node/rpc/member_frontend.h # src/node/share_manager.h # src/service/genesis_gen.h # tests/infra/clients.py # tests/requirements.txt
achamayou
added
backported
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
achamayou
pushed a commit
to achamayou/CCF
that referenced
this pull request
Oct 18, 2023
(cherry picked from commit 88cb1ea) # Conflicts: # CMakeLists.txt # tests/infra/clients.py # tests/requirements.txt
achamayou
added a commit
that referenced
this pull request
Oct 18, 2023
…face (#5660) (#5743) Co-authored-by: Eddy Ashton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5211.
Initial open comment:
This contains some TODOs highlighting behaviour changes that may need discussing, or tracking in issues.This implements a new API for governance, matching a TypeSpec source located here. Behaviourally this is very similar to
member_frontend.h, but extracted for clarity and with manual construction of responses to try and make API-compliance explicit. Unlike other frontends, the endpoints here are registered by several independent static functions rather than directly in theRegistryconstructor. This is to confirm that such a code division is viable, and an attempt to mirror the source TypeSpec layout to aid conformance validation.The current testing is incomplete. A few end-to-end tests of the governance API have new
_az_apivariants, which use the new APIs when calling anything inmember.py. There are many other tests that call endpoints directly, so I'll look at wrapping those separately. There's likely some improvement in naming/access of this variant test too. For now we want to test both APIs, but we will shortly deprecate the old API and then be able to convert most testing to this replacement API.A remaining axis for testing is how closely this aligns to the TypeSpec/OpenAPI - I think the correct way to do that is with a generated
autorestclient, but current testing suggests that's surprisingly lax on response schema validation. I'll explore this separately.