Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Amaury Chamayou <[email protected]>
  • Loading branch information
eddyashton and achamayou authored Sep 27, 2023
1 parent 6966996 commit cfca822
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
2 changes: 1 addition & 1 deletion src/node/gov/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@ Implementation notes:

- All endpoints validate and process an `api-version` parameter, modifying their behaviour accordingly.
- To present both under the `/gov` prefix, the old frontend is a subclass of the new frontend.
- The frontend implementation into distinct components which can be more easily moved around, rather than a single monolithic frontend implementation.
- The frontend implementation is split into distinct components which can be more easily moved around, rather than a single monolithic frontend implementation.
6 changes: 2 additions & 4 deletions tests/infra/consortium.py
Original file line number Diff line number Diff line change
Expand Up @@ -304,10 +304,8 @@ def vote_using_majority(
if response.status_code != http.HTTPStatus.OK.value:
raise infra.proposal.ProposalNotAccepted(proposal, response)
body = response.body.json()
for k in ("state", "proposalState"):
if k in body:
proposal_state = body[k]
break
proposal_state = body.get("state", body.get("proposalState"))
assert proposal_state, f"Could not find proposal state in {body}"
proposal.state = infra.proposal.ProposalState(proposal_state)
proposal.increment_votes_for(member.service_id)

Expand Down

0 comments on commit cfca822

Please sign in to comment.