Usability improvements for no series #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Successfully linked to Azure Boards work item(s): |
1 similar comment
|
✅ Successfully linked to Azure Boards work item(s): |
AndreasMoth
commented
Feb 9, 2024
src/Business Foundation/App/NoSeries/src/Setup/NoSeries.Page.al
Outdated
Show resolved
Hide resolved
darjoo
reviewed
Feb 9, 2024
src/Business Foundation/App/NoSeries/src/Setup/NoSeries.Page.al
Outdated
Show resolved
Hide resolved
src/Business Foundation/App/NoSeries/src/Setup/NoSeries.Page.al
Outdated
Show resolved
Hide resolved
darjoo
previously approved these changes
Feb 9, 2024
grobyns
previously approved these changes
Feb 9, 2024
grobyns
previously approved these changes
Feb 9, 2024
…te/anmoth/UsabilityImprovementsForNoSeries
JesperSchulz
approved these changes
Feb 9, 2024
darjoo
approved these changes
Feb 12, 2024
AndreasMoth
deleted the
private/anmoth/UsabilityImprovementsForNoSeries
branch
grobyns
requested changes
Feb 12, 2024
| [MessageHandler] | ||
| procedure TestSeriesSuccessMessageHandler(Message: Text[1024]) | ||
| begin | ||
| LibraryAssert.IsTrue(Message.StartsWith('The test was successful.'), 'The test series was not successful, message: ' + Message); |
There was a problem hiding this comment.
Suggested change
| LibraryAssert.IsTrue(Message.StartsWith('The test was successful.'), 'The test series was not successful, message: ' + Message); | |
| LibraryAssert.ExpectedMessage('The test was successful.', Message); |
There was a problem hiding this comment.
Also, just copy the label and use that...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a success/failure message to Check No. Series, promoting Lines and Relations actions on No. Series page to always show and adding a FactBox on No. Series page to show the relations a No. Series has.
Fixes AB#476364