Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move obsolete fields to table extension #545

Merged
merged 1 commit into from
Feb 8, 2024
Merged

move obsolete fields to table extension #545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
90 changes: 69 additions & 21 deletions src/Business Foundation/App/NoSeries/src/Legacy/NoSeriesLineObsolete.TableExt.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,27 +12,19 @@ tableextension 309 NoSeriesLineObsolete extends "No. Series Line"
{
fields
{
#if not CLEAN24
#pragma warning disable AL0432
modify(Implementation)
field(11; "Allow Gaps in Nos."; Boolean)
{
trigger OnAfterValidate()
var
NoSeriesSetupImpl: Codeunit "No. Series - Setup Impl.";
begin
if Rec.Implementation = xRec.Implementation then
exit;
Caption = 'Allow Gaps in Nos.';
DataClassification = CustomerContent;
ObsoleteReason = 'The specific implementation is defined by the Implementation field and whether the implementation may produce gaps can be determined through the implementation interface or the procedure MayProduceGaps.';
#if CLEAN24
ObsoleteState = Removed;
ObsoleteTag = '27.0';
#else
ObsoleteState = Pending;
ObsoleteTag = '24.0';

#pragma warning disable AA0206
SkipAllowGapsValidationTrigger := true;
#pragma warning restore AA0206

Validate("Allow Gaps in Nos.", NoSeriesSetupImpl.MayProduceGaps(Rec)); // Keep the Allow Gaps field in sync with the implementation
end;
}
modify("Allow Gaps in Nos.")
{
trigger OnAfterValidate()
trigger OnValidate()
var
NoSeries: Record "No. Series";
begin
Expand All @@ -52,14 +44,70 @@ tableextension 309 NoSeriesLineObsolete extends "No. Series Line"
if "Line No." <> 0 then
Modify();
end;
#endif
}
modify("Authorization Year")
field(10000; Series; Code[10]) // NA (MX) Functionality
{
trigger OnAfterValidate()
Caption = 'Series';
DataClassification = CustomerContent;
ObsoleteReason = 'The No. Series module cannot reference tax features.';
#if CLEAN24
ObsoleteState = Removed;
ObsoleteTag = '27.0';
#else
ObsoleteState = Pending;
ObsoleteTag = '24.0';
#endif
}
field(10001; "Authorization Code"; Integer) // NA (MX) Functionality
{
Caption = 'Authorization Code';
DataClassification = CustomerContent;
ObsoleteReason = 'The No. Series module cannot reference tax features.';
#if CLEAN24
ObsoleteState = Removed;
ObsoleteTag = '27.0';
#else
ObsoleteState = Pending;
ObsoleteTag = '24.0';
#endif
}
field(10002; "Authorization Year"; Integer) // NA (MX) Functionality
{
Caption = 'Authorization Year';
DataClassification = CustomerContent;
ObsoleteReason = 'The No. Series module cannot reference tax features.';
#if CLEAN24
ObsoleteState = Removed;
ObsoleteTag = '27.0';
#else
ObsoleteState = Pending;
ObsoleteTag = '24.0';

trigger OnValidate()
begin
if StrLen(Format("Authorization Year")) <> 4 then
Message(ShouldBeValidYearErr);
end;
#endif
}
#if not CLEAN24
#pragma warning disable AL0432
modify(Implementation)
{
trigger OnAfterValidate()
var
NoSeriesSetupImpl: Codeunit "No. Series - Setup Impl.";
begin
if Rec.Implementation = xRec.Implementation then
exit;

#pragma warning disable AA0206
SkipAllowGapsValidationTrigger := true;
#pragma warning restore AA0206

Validate("Allow Gaps in Nos.", NoSeriesSetupImpl.MayProduceGaps(Rec)); // Keep the Allow Gaps field in sync with the implementation
end;
}
#pragma warning restore AL0432
#endif
Expand Down
8 changes: 8 additions & 0 deletions src/Business Foundation/App/NoSeries/src/Legacy/NoSeriesObsolete.TableExt.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,14 @@ tableextension 308 NoSeriesObsolete extends "No. Series"
{
fields
{
field(11790; Mask; Text[20]) // CZ Functionality
grobyns marked this conversation as resolved.
Show resolved Hide resolved
{
Caption = 'Mask';
DataClassification = CustomerContent;
ObsoleteReason = 'The field is used in CZ localization only. The functionality of No. Series Enhancements will be removed and this field should not be used. (Obsolete::Removed in release 01.2021)';
ObsoleteState = Removed;
ObsoleteTag = '18.0';
}
#pragma warning disable AL0432
field(12100; "No. Series Type"; Integer)
#pragma warning restore AL0432
Expand Down
8 changes: 0 additions & 8 deletions src/Business Foundation/App/NoSeries/src/Setup/NoSeries.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,14 +56,6 @@ table 308 "No. Series"
{
Caption = 'Date Order';
}
field(11790; Mask; Text[20]) // CZ Functionality
{
Caption = 'Mask';
DataClassification = CustomerContent;
ObsoleteReason = 'The field is used in CZ localization only. The functionality of No. Series Enhancements will be removed and this field should not be used. (Obsolete::Removed in release 01.2021)';
ObsoleteState = Removed;
ObsoleteTag = '18.0';
}
}

keys
Expand Down
52 changes: 0 additions & 52 deletions src/Business Foundation/App/NoSeries/src/Setup/NoSeriesLine.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,19 +108,6 @@ table 309 "No. Series Line"
{
Caption = 'Last Date Used';
}
field(11; "Allow Gaps in Nos."; Boolean)
{
Caption = 'Allow Gaps in Nos.';
DataClassification = CustomerContent;
ObsoleteReason = 'The specific implementation is defined by the Implementation field and whether the implementation may produce gaps can be determined through the implementation interface or the procedure MayProduceGaps.';
#if CLEAN24
ObsoleteState = Removed;
ObsoleteTag = '27.0';
#else
ObsoleteState = Pending;
ObsoleteTag = '24.0';
#endif
}
field(12; "Sequence Name"; Code[40])
{
Caption = 'Sequence Name';
Expand All @@ -139,45 +126,6 @@ table 309 "No. Series Line"
DataClassification = SystemMetadata;

}
field(10000; Series; Code[10]) // NA (MX) Functionality
{
Caption = 'Series';
DataClassification = CustomerContent;
ObsoleteReason = 'The No. Series module cannot reference tax features.';
#if CLEAN24
ObsoleteState = Removed;
ObsoleteTag = '27.0';
#else
ObsoleteState = Pending;
ObsoleteTag = '24.0';
#endif
}
field(10001; "Authorization Code"; Integer) // NA (MX) Functionality
{
Caption = 'Authorization Code';
DataClassification = CustomerContent;
ObsoleteReason = 'The No. Series module cannot reference tax features.';
#if CLEAN24
ObsoleteState = Removed;
ObsoleteTag = '27.0';
#else
ObsoleteState = Pending;
ObsoleteTag = '24.0';
#endif
}
field(10002; "Authorization Year"; Integer) // NA (MX) Functionality
{
Caption = 'Authorization Year';
DataClassification = CustomerContent;
ObsoleteReason = 'The No. Series module cannot reference tax features.';
#if CLEAN24
ObsoleteState = Removed;
ObsoleteTag = '27.0';
#else
ObsoleteState = Pending;
ObsoleteTag = '24.0';
#endif
}
}

keys
Expand Down
Loading