#437 Expose an event to skip suite errors #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exposes an event to make it possible to skip errors from unhandled handler functions.
JesperSchulz
added
Linked
grobyns
previously requested changes
Jan 30, 2024
src/Tools/Performance Toolkit/App/src/BCPTTestSuite.Codeunit.al
Outdated
Show resolved
Hide resolved
TKapitan
suggested changes
Jan 30, 2024
src/Tools/Performance Toolkit/App/src/BCPTTestSuite.Codeunit.al
Outdated
Show resolved
Hide resolved
grobyns
reviewed
Feb 4, 2024
src/Tools/Performance Toolkit/App/src/BCPTTestSuite.Codeunit.al
Outdated
Show resolved
Hide resolved
grobyns
reviewed
Feb 4, 2024
grobyns
reviewed
Feb 4, 2024
src/Tools/Performance Toolkit/App/src/BCPTTestSuite.Codeunit.al
Outdated
Show resolved
Hide resolved
grobyns
reviewed
Feb 4, 2024
grobyns
reviewed
Feb 4, 2024
src/Tools/Performance Toolkit/App/src/BCPTTestSuite.Codeunit.al
Outdated
Show resolved
Hide resolved
grobyns
reviewed
Feb 5, 2024
grobyns
reviewed
Feb 5, 2024
grobyns
reviewed
Feb 5, 2024
henrikfrovst
previously approved these changes
Feb 9, 2024
ChethanT
requested changes
Feb 13, 2024
|
@ChethanT do you think this can go into next release? Meaning do you have time to merge it before the break? 😬 |
ChethanT
requested changes
Feb 21, 2024
ChethanT
previously approved these changes
Feb 21, 2024
Co-authored-by: Chethan Thopaiah <[email protected]>
Co-authored-by: Chethan Thopaiah <[email protected]>
ChethanT
previously approved these changes
Feb 26, 2024
|
We've got approval from @ChethanT, but the build is failing. Seems just to be some unused variables though, which should be easy to fix. One more round, and we can get this PR merged 😊 |
added 2 commits
February 26, 2024 10:49
ChethanT
approved these changes
Feb 26, 2024
JesperSchulz
approved these changes
Feb 26, 2024
JesperSchulz
dismissed
grobyns’s stale review
Review comments have been addressed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR exposes an event to make it possible to skip an unwanted error when running a BCPT suit.
The idea was to expose an event i BCPTLine codeunit.
However, during the implementation I discovered that [BCPTLine codeunit has access internal] (https://github.com/microsoft/BCApps/blob/faeca5adabaa2e2b7644d744e21f9a1f97d1d971/src/Tools/Performance%20Toolkit/App/src/BCPTLine.Codeunit.al#L12).
To solve this I created a wrapper subscriber in BCPTTestSuite and calls another event that is public.
I hope this workaround is acceptable.
Work Item(s)
Fixes #437
Fixes AB#498190
Fixes AB#498190