Bug 557680: [Instability][NAV.master] Tests are unstable in task RunALTests_CZ_Bucket1. (AUTODETECTED) - T001_PostingDateIsInNotAllowedPeriodInGLSetup #2480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could not find a linked ADO work item. Please link one by using the pattern 'AB#' followed by the relevant work item number. You may use the 'Fixes' keyword to automatically resolve the work item when the pull request is merged. E.g. 'Fixes AB#1234' |
|
Issue #557680 is not valid. Please make sure you link an issue that exists, is open and is approved. |
AndreasMoth
reviewed
Dec 9, 2024
| @@ -11,7 +11,7 @@ codeunit 134510 "Library - No. Series" | |||
| NoSeries.Code := NoSeriesCode; | |||
| NoSeries.Description := NoSeriesCode; | |||
| NoSeries."Default Nos." := true; | |||
| NoSeries.Insert(); | |||
| if NoSeries.Insert() then; | |||
There was a problem hiding this comment.
What about exiting this instead? if you expect a new no. series it's good to get an error, if you don't care whether it already exists then you can do if-then around this call.
|
Skipping this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Often tests are run in parallel, and these library functions cause race conditions (=unstable tests) since they don't consider other processes. The change is just to try to insert the new no. series record.
Work Item(s)
Fixes #AB557680