Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add approval by default to privacy notices #2368

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

edwardUL99
Copy link

@edwardUL99 edwardUL99 commented Nov 18, 2024

Summary

Quick outline of new learn api requirements form Ayrton and Jacob:

  1. Implement a privacy notice which is “enabled” by default for the learn integration.
  2. Implement an experience for when the privacy notice is declined by either an admin or individual user. This involves showing a UI component on the help pane notifying the user that the experience may be limited.
    a. If admin, the text will have a link for them to open the privacy notices page to enable it
    b. If user and the notice is not yet set by them or an admin, the text will have a link to open the wizard for approval
    c. If user and the notice is disabled by admin, the card will simply tell them to reach out to an administrator
    For on-prem, this isn’t supported, so no privacy notice or search box necessary.

To implement 2, the current Privacy notice table does not allow us to differentiate if it is enabled by default. It simply calculates if it is approved/disabled for all users or the user decides. So I am adding a new column which will identify if it is enabled by default so that the checks for approval will return approved if approved by default or admin approved. Hence, the questions on trying to add a new column to the system tables.

Work Item(s)

Fixes AB#556896

This comment was marked as outdated.

@edwardUL99
Copy link
Author

edwardUL99 commented Nov 18, 2024

@microsoft-github-policy-service agree company="Microsoft"

1 similar comment
@edwardUL99
Copy link
Author

@microsoft-github-policy-service agree company="Microsoft"

@github-actions github-actions bot added this to the Version 26.0 milestone Nov 18, 2024
@haoranpb haoranpb requested a review from darjoo November 18, 2024 14:41
@darjoo
Copy link
Contributor

darjoo commented Nov 20, 2024

No other comments to add. LGTM besides Haoran's comment.

@edwardUL99 edwardUL99 self-assigned this Nov 20, 2024
@edwardUL99 edwardUL99 marked this pull request as ready for review November 20, 2024 11:10
@edwardUL99 edwardUL99 requested review from a team as code owners November 20, 2024 11:10
@JesperSchulz JesperSchulz added the Integration GitHub request for Integration area label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AL: System Application Integration GitHub request for Integration area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants