[241][Copilot] Marketing Text Improvements - Functions and GPT4o #1573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> Add tests for deleting Tools and an additional API for clearing all tools without having to loop through. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#522487](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/522487)
…ctionResponse (#928) <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> Minor changes to the internals of OperationResponse and FunctionResponse. Conforming closer to facade principals #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#493212](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/493212)
#### Summary <!-- Provide a general summary of your changes --> Fix return value for procedure `ProcessFunctionCall`. Also explicit return value false #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#525473](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/525473)
…ls Calling Results in Message History (#719) Enable JSON mode for chat completion, requiring "json" in messages, and maintain tool call history. This update prepares the system to return valid JSON objects as chat completions, facilitating better integration with tools and enhancing the user experience. <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary 1. Adding Json Mode support to the completion 2. When AOAI respond with tool calling message, this message is saved in the message history, marked as tool. New function implemented to parse tool message response. When tool was called we can now add the tool result back to the chat message history in a correct format, so AOAI will respond back taking into account tool result. #### Work Item(s) Fixes #718 Fixes [AB#503148](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/503148) --------- Co-authored-by: Jesper Schulz-Wedde <[email protected]> Co-authored-by: Darrick <[email protected]>
qasimikram
changed the title
darjoo
previously approved these changes
Jul 15, 2024
PredragMaricic
previously approved these changes
Jul 16, 2024
darjoo
approved these changes
Jul 18, 2024
msft-sam
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improvements done to marketing text feature by introduction functions and upgrading the model to gpt4o. The changes were merged into main as part of this PR #1275
This PR backports all the commits related to functions/tools that needs to be backported to make the above changes work in 24. Following are the list of commits that were cherry-picked in the same order:
Work Item(s)
Fixes # AB#521281