Remove public permissions from image store blob in favor of SAS #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rozele
force-pushed
the
blobPermissions
branch
from
b7b6a5d to
d74545c
Compare
We ran into an issue where we didn't initially notice that the OCR images were being stored in a public blob when testing on our own documents. This change would prevent others from making the same mistake.
rozele
force-pushed
the
blobPermissions
branch
from
d74545c to
af91722
Compare
|
I am going to test this soon to confirm it works still, but I am likely going to end up merging it if it does as it seems like a very nice change, let me know if anyone has any objections. |
Careyjmac
reviewed
Jun 7, 2019
| @@ -18,6 +18,9 @@ namespace Microsoft.CognitiveSearch.WebApiSkills | |||
| { | |||
| public static class JfkWebApiSkills | |||
| { | |||
| // Configure duration of SAS token for image store blobs here | |||
| private static readonly TimeSpan s_imageBlobSASDuration = TimeSpan.FromDays(365); | |||
There was a problem hiding this comment.
Could you possibly change this to be effectively forever (i.e. some day in the year 9999) so that in case anyone uses this demo long term they don't become frustrated if it stops working and the only way to fix it is to reindex?
|
You'd also want to update the README to remove the note about publicy readable storage containers. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into an issue where we didn't initially notice that the OCR images were being stored in a public blob when testing on our own documents. This change would prevent others from making the same mistake.